From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D6A2C3DA45 for ; Fri, 12 Jul 2024 07:40:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C47D76B0096; Fri, 12 Jul 2024 03:40:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF6656B0098; Fri, 12 Jul 2024 03:40:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6F9F6B0099; Fri, 12 Jul 2024 03:40:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 848356B0096 for ; Fri, 12 Jul 2024 03:40:28 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 333D81C17E7 for ; Fri, 12 Jul 2024 07:40:28 +0000 (UTC) X-FDA: 82330302936.01.7726B1D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf01.hostedemail.com (Postfix) with ESMTP id A54FD4001C for ; Fri, 12 Jul 2024 07:40:25 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BEM9wecV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PXXB22wb; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XFTBjjLK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vTtaiPYe; dmarc=none; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720769988; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sd5eFu+eggVHqY1TdIadFkTrAzXQKitA/ubhvFmT3QA=; b=aK2ixFobn/G7wqpuaZo17uY12kt8WHpzCCiublhSiVh4aF7yio1fDoHsQZcGp1kb6yP7+m +EWr2keAHTGD89FJQs0m6nszrFmnLOLQtdTY9J75S5icVfuh0eQQ0mkByqBAB14cICJq3G CLM6HNCziq7V8rWD5hhKRmJqisL17sI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720769988; a=rsa-sha256; cv=none; b=OiZ2FDY4mi8urQfbfbFjVNsOOmMbrQWGfdKGSxr5FPL7YQ70F9TXUv6P6+mwbYxMLs2x7O 56OMbm6Gj75hiMIIW5/V0WWFuDlaPwlbuaHIDrLfSzUQ/IYFUeML8OyRGxf0tB+4vZ/d18 fX6CWN7dOIDFUSsZ01pUJdSQjkibOEc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BEM9wecV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PXXB22wb; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XFTBjjLK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vTtaiPYe; dmarc=none; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E8DEE21AB9; Fri, 12 Jul 2024 07:40:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1720770024; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Sd5eFu+eggVHqY1TdIadFkTrAzXQKitA/ubhvFmT3QA=; b=BEM9wecVaKnODA5H/vcBnrOyJi56DekkJgOonUfARheCFGZ8M02qvMyaaHuN6dPP0qRb5s MLdb+g1Ffzdil29PhHlarr7LUp882qusp90MtXPk6cyOM7EZ6z0giC7B55GwU3UwfwUZFe eyMdGjgvmpHxO6DedDIc+rx6xnaHOMA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1720770024; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Sd5eFu+eggVHqY1TdIadFkTrAzXQKitA/ubhvFmT3QA=; b=PXXB22wb8q42JhQCqCpYkf7l5WbPk1OSglFtxEgBN/91ZV/Dx1/OAndMHwjvjS7loB3Ssx vIGzX6NqJCNlcYBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1720770023; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Sd5eFu+eggVHqY1TdIadFkTrAzXQKitA/ubhvFmT3QA=; b=XFTBjjLKDaWGJgE7b6nxfPg6MyKdFoQRSDiwrFm1yTLwKO1dWJzPnTFgIO1qNCWI7YahOb MiqiAoDORoFZ/gOVaMamTlKlmf1BmPjd1eIRlPzUBmMECQ5aEfWvcXLhvH4FObqw7j5Ipt U5pOlrw1R1kziO8Er4QT8vCpVZG9/HU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1720770023; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Sd5eFu+eggVHqY1TdIadFkTrAzXQKitA/ubhvFmT3QA=; b=vTtaiPYe3Yh00rk7iRu2x70fj2cf8+67Hik7W65Y0UeLqqdpPLT9kTPk+jXTmtUhWnIT/e GNe8K/ybwpf/WRCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C7F9C13686; Fri, 12 Jul 2024 07:40:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VUVzMOfdkGb9dAAAD6G6ig (envelope-from ); Fri, 12 Jul 2024 07:40:23 +0000 Message-ID: <4404e6f4-84f5-41c8-95ca-ed2f40617319@suse.cz> Date: Fri, 12 Jul 2024 09:40:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm/memcg: alignment memcg_data define condition Content-Language: en-US To: alexs@kernel.org, Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Randy Dunlap , Yoann Congal , Masahiro Yamada , Petr Mladek , Suren Baghdasaryan References: <20240712041435.301314-1-alexs@kernel.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240712041435.301314-1-alexs@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Spamd-Bar: + X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A54FD4001C X-Stat-Signature: 1h6i6c4kgamn8npyee8kg838ft9tyaqr X-Rspam-User: X-HE-Tag: 1720770025-792834 X-HE-Meta: U2FsdGVkX1/0spKvO1OJ4eFnypSaVT/0Gj0oNA71FZYnBZGMKnSNWSPlVxK/qrEOfhV3MhG5Rp20WN3BXSyg0lvfn/iJB05NddnIKFLT5PaxFN+GDwnWFF8yPli4XUCzGVuzocDMUJHez9wuR7NzDnWuc8rhU2kXWTXEkYhmsncamzoNdxQN+UZ7qG+eQC09Q6V64TX215e6FWN5JqjJ0iWNkxpxVeN1B7nfc3uScv/KiR80D26BTb9vRiGiEfTjIm7HCf++GZKVNpNi1456CKR2yTCMB3yXABXYuwPIgkYA/DvlXlBu9+gtuna+WtwOQS4l4ZCA78Ga/J+DGnv++V+ZHfchZQjZ4XRqAeycvvU6HRK0dv8xOC1Dx357YOil8UhRqs1lGE+iWYH3UFZeoKFX2LL3lh7yykSvn5pkOui8HhMvCSiuIZlIlomlx7dwK1agVcMH31nTsPeaeckHWiPuFnXDpcLWCOWVhKK6PgPWVFbdooEy5Cmz+7w6T1v5b2MzSZ2/FWDHSo6C2d3Xd85mzSYZmdOWOQcbLbJoLzfK7oUXQC5YoOGWyoac3j8dFRU37Ni2ZG323OajfEbzB8N6Q7cnTYUbDOz82qrgF8MDkeftrMdTEqhwgeSsGzLmfKHXIh4MnT9yO/27zF7ga/7Z9jekAN4SEUrXqK0mupgVnP8XI7BQs5glgLVzBw99fuJ0uYLsYkDsQKEPfTRWlKWz6t6twoRWoHaj4xVkP4hyTYL3QZRgy2EJf7hHnh/X/X59Vwo4JZaT9QPdFuTaZK/8fAaE+IBXLiGOTnM4JrOK7I8r2gunfZXQrWoFvxRHqq3MyNjrrC6rcoXyqmtlt+t/xp+aGYzLG4Iq+zKyQJYaXWlb325HntCJS4L0jAtlHNNZ4o2gkQJDRhYUpaGk5YMCI3eZNzKAEDd7DEg4+uIp5WDtPr+3aU8WjBi/wIW9l4QYsIOjYRNsVRKeBvx YBx03wUx Grskn5aIDgigB8rJ7jqkvFH7xAK5w7RA5Vl8aS9ihTdGfFd7OwGceVjlbaMN/iAdaQ4Uuye1z498dY2vHMVgQEHCfpcFol1qUh+0xUtXnTPNtEne307DadBP/S8+JdHDK/MUehZEfDFY+FMIGuckHButNvpgWULGI+jwiEYGsN12tz/uZ2t1TGTXFEzM36EJo2iEhM4IapFVxBoeWM3IZG9HCI6UMa0h4ixw6joyGDDTlYoFlKzpWhj6j8Uk69wzxhUp/ovWlY7gfTpZxqm6xCyFxdgWKldkxnqmsMVGLnCDqARyLyMXoYirki0eoFpbU7cYK7loWLnF/AccACGhFycsv+ENPofaPUO+4kKf2mUETGM3jkv7zucMhfu0jLdTBKHseLEYzdRle99oC6eCZ/TR39hz2N0qrz+ZimXRXaksLeGglKj6NwNMuh5yi/5BDzPke3tnXUCXf+6VPaEarf/mpH+Oh9H7dO4cdRU+yNU7x3u6ijpCrBqbLC0R2NTv9QErYXPvaKit7WfmesrZ+OQ6cAwB7B1kSZXOgTpeAHxDpVJVXNGJTbO/wXu6ZwSeOV1rGC8J3Hvtvao8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/12/24 6:14 AM, alexs@kernel.org wrote: > From: "Alex Shi (Tencent)" > > commit 21c690a349ba ("mm: introduce slabobj_ext to support slab object > extensions") changed the folio/page->memcg_data define condition from > MEMCG to SLAB_OBJ_EXT. This action make memcg_data exposed while !MEMCG. > > As Vlastimil Babka suggested, let's add _unused_slab_obj_ext for > SLAB_MATCH for slab.obj_exts while !MEMCG. That could resolve the match > issue, clean up the feature logical. > > Signed-off-by: Alex Shi (Tencent) > Cc: Randy Dunlap > Cc: Yoann Congal > Cc: Masahiro Yamada > Cc: Petr Mladek > Cc: Suren Baghdasaryan > Cc: Vlastimil Babka Thanks, added to slab/for-next