From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE02C6FD1D for ; Tue, 21 Mar 2023 07:59:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA7276B0075; Tue, 21 Mar 2023 03:59:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A57B06B0078; Tue, 21 Mar 2023 03:59:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F8586B007B; Tue, 21 Mar 2023 03:59:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7C83E6B0075 for ; Tue, 21 Mar 2023 03:59:33 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 47E311411E2 for ; Tue, 21 Mar 2023 07:59:33 +0000 (UTC) X-FDA: 80592155826.22.A5C2A00 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf14.hostedemail.com (Postfix) with ESMTP id 4946B100005 for ; Tue, 21 Mar 2023 07:59:31 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zjxpGIdq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=oLQr4pkw; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679385571; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BoniuNoO5eexUIW/xsTozOoB3FVZQwYyoAwklqRuey4=; b=7Q9ky+/0fEhPxyWOhup8KRJSecgnAv9Q5kSnwWvC/ZPHF1YNNz1NB8hwSlJIBniJr3OG45 3WXr9jNTWyeefaJ9pnp3veK37X9IQzKFhHf3ivuhWG9RLeSLKpzrjiDS35gy6O7+CN2V9D ukoPu0mR0Bf9BjCsNSzZmh97+ftvOD8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zjxpGIdq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=oLQr4pkw; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679385571; a=rsa-sha256; cv=none; b=Mq6UZV4xwvT8sprM20taeavoho2gwT8q2g3lt7bB5uVSSjdTIDg2d1EjN43X9os/G8+4Jc sY9acHorQO7owGOg3g2h3cB59UgauvF3TZx9qWcfoFDjHb8ZBDI9GfsHlsZfkWr+bL0fEk mMTc39E1tnBrL/EpH0XIdlysMjpOoCo= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 316BE1FD6A; Tue, 21 Mar 2023 07:59:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679385570; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BoniuNoO5eexUIW/xsTozOoB3FVZQwYyoAwklqRuey4=; b=zjxpGIdqWELDFEDxkAHsCYlf6NUYnC4Afb9mFGLEZIU2tCkKaMHlVE1MgxiIROEBfKA4cD WWcDxGy9muk1ZRV5L0o+eUyfrhYoSiFeLpKUHZLKfthu7/oUKZXeJKBz55rU4ykwK/hwJB vd77cT5gc6NQkv0rGwnNYUb5VjrEpjc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679385570; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BoniuNoO5eexUIW/xsTozOoB3FVZQwYyoAwklqRuey4=; b=oLQr4pkw2ZENRscA4RqfFGSWD8iPFnevuyWvBmG1NsnCaylopl3HHJBa8/sgeiFUUeK2HB DCceznv08Fy996AQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0ED8713440; Tue, 21 Mar 2023 07:59:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id D0ncAuJjGWRoOQAAMHmgww (envelope-from ); Tue, 21 Mar 2023 07:59:30 +0000 Message-ID: <44049b2c-42af-f9be-2af3-46716dd83344@suse.cz> Date: Tue, 21 Mar 2023 08:59:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 05/10] genwqe: Fix MAX_ORDER usage Content-Language: en-US To: "Kirill A. Shutemov" , Andrew Morton , Mel Gorman , David Hildenbrand Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Frank Haverkamp References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> <20230315113133.11326-6-kirill.shutemov@linux.intel.com> From: Vlastimil Babka In-Reply-To: <20230315113133.11326-6-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4946B100005 X-Stat-Signature: d9yz9sxdd5dshuw8azi3ya9zd9sicmcf X-Rspam-User: X-HE-Tag: 1679385571-303488 X-HE-Meta: U2FsdGVkX18rJ11aNPa8f1ZF0bsjInRVx6b+4F/ZoSFocYQQMH3r7pxUmsc1rsPFpJZYoQ3U8L3rHXmzcP2qgcvtYB2jouyZgtoPBd1bgWh0FRLgC79/dfdlUJ7YCnv4oQjIklfE/XmYERvRdCkw/EZ8qMu4qb3hKLsDRb4wji/Hcn65MIx/9tWsrQROGX5cGzzHooHMj8dg3BjIin2/Oh0rTUsAwxHjxtES5ja3Qvr6Ssh+RI7YQZmzNt+byJh+zYgwfvLvvI3o5Kp9AxpchU/D8cFBKyLmkcpINbpWGqdgj46KqXDxTh96AjvdcRyQmGh5pW4Rfryudmy1StnyjzgpkHHLnhsFtcXbGBKAxOfziPxWJTzEortWab6OSeVVoHXajpvzENVWht2btYSOL19QK5LmVO/5gEeifrqwbKdkGo9RtvB17CL44vTcQ+xJKSLwK7JaZgEYb1GJU2MChGSSNHmWb7W6OZjOj/aF/jZKjYVxC7I/+YEACUEXC/sWoUsHYABnQXI05NnO9SosIS7h8+NG/1h2I+Lye+fNVbZhn9p5qdmbJTVtA2DU+0VSwV6M6gecuSDg458avrqX1bx6/FRgDfugwuzZ+MHXT5JJOpgUKxxeM8Dui1mRlee32SkfAxBXVr5Rp45UH6gRjkjK92JGLR9VwgCzMl4mRb11NC2p2IosMqkDBqugycLp2lVE2jv1UA4JI8udpmqpXZs72+Mcod+sLbIhQK98coCyvut3QlCJZY8Fg5GYt5dd13ORqIZIUlUkFTFUZ0Dw3GTMhAAlOxYSx3zeQ6K9lwv/AS3/Lo0sJ9faD7TbaNVjYxYyhjCfvUsq1aI4JiqMQ9jpMrrfCbu/kchsNOsENXiu85uXz1lY62BHEUgPhWXYdAkmjuAlt+xzMCmZMcRoyQBgd9HoC1oLj4Wp1/4jqmmObDebu5yuqRsM2MSHklaioce7vB6nPfF042Fewie TsWjP3no AEgRuDc/J8zX/qEoLg+GiaGd0GRN8D0pw//WcrxoV5EcJfm8ePO+OJF861c3QjrpqENdxWVswqbkF8XS0kXKZSasJOXEOLJok3RkMsAri1CrIhXNgEX6NUkNxaqzaXf7ybkcPO/o2czhLfkyZQmanKiND1WUbSfvlZai1C+t5oetPxliNK9E/mb75k6kSkdmlTnrRCALxbuIZNdSmsRPAG6JLlWAOqVKUJ/JASjEFRi/qJ6z24JiUFZEhDI8yu4Z/zZElrf0ssrdCvSVOJs9uWCpGaSDOOxWnx7HC0/h8Af7vxtJXZ5c8BqyAXg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/15/23 12:31, Kirill A. Shutemov wrote: > MAX_ORDER is not inclusive: the maximum allocation order buddy allocator > can deliver is MAX_ORDER-1. > > Fix MAX_ORDER usage in genwqe driver. > > Signed-off-by: Kirill A. Shutemov Acked-by: Vlastimil Babka > Cc: Frank Haverkamp > --- > drivers/misc/genwqe/card_dev.c | 2 +- > drivers/misc/genwqe/card_utils.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/misc/genwqe/card_dev.c b/drivers/misc/genwqe/card_dev.c > index 55fc5b80e649..d0e27438a73c 100644 > --- a/drivers/misc/genwqe/card_dev.c > +++ b/drivers/misc/genwqe/card_dev.c > @@ -443,7 +443,7 @@ static int genwqe_mmap(struct file *filp, struct vm_area_struct *vma) > if (vsize == 0) > return -EINVAL; > > - if (get_order(vsize) > MAX_ORDER) > + if (get_order(vsize) >= MAX_ORDER) > return -ENOMEM; > > dma_map = kzalloc(sizeof(struct dma_mapping), GFP_KERNEL); > diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c > index f778e11237a6..ac29698d085a 100644 > --- a/drivers/misc/genwqe/card_utils.c > +++ b/drivers/misc/genwqe/card_utils.c > @@ -308,7 +308,7 @@ int genwqe_alloc_sync_sgl(struct genwqe_dev *cd, struct genwqe_sgl *sgl, > sgl->write = write; > sgl->sgl_size = genwqe_sgl_size(sgl->nr_pages); > > - if (get_order(sgl->sgl_size) > MAX_ORDER) { > + if (get_order(sgl->sgl_size) >= MAX_ORDER) { > dev_err(&pci_dev->dev, > "[%s] err: too much memory requested!\n", __func__); > return ret;