From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B988C369D9 for ; Wed, 30 Apr 2025 09:14:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B9CC6B00BA; Wed, 30 Apr 2025 05:14:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 440876B00C3; Wed, 30 Apr 2025 05:14:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B6FD6B00C4; Wed, 30 Apr 2025 05:14:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0780F6B00BA for ; Wed, 30 Apr 2025 05:14:16 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2C7561CE5DA for ; Wed, 30 Apr 2025 09:14:17 +0000 (UTC) X-FDA: 83390148954.09.6485449 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by imf25.hostedemail.com (Postfix) with ESMTP id 7898FA0007 for ; Wed, 30 Apr 2025 09:14:14 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ks8NopbR; spf=none (imf25.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.20) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746004455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=omhnYRBdaL841RJzZ4hQpQ17+dmRPdVnHpDjI8pZM+A=; b=hZTMdet/feTZHBEztNC2Z9YBzVtUkrAWDE/7cvr7uxaWbTy4hhXph/H+CMiqzqraZnbh7D PnApnPDaFWaacktbQyJI4sGZcdocMiYno0eT785Zut7tZf7GnBZe/g7dRU5YQwDq+9YY19 aGDl2vmOK4tZz49fSg1ZMThjkNO/aM0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ks8NopbR; spf=none (imf25.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.20) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746004455; a=rsa-sha256; cv=none; b=s9M2XlYtxsr+CmCkVLUtIUNHt8ynkr4YKcNrLgi64+v+RcZl/yvF22GQAm1RszYYTxBY/t dfb0NuPlXjdWhTfsJFEm4oFc2djcVAsLwGr2moXcgoNLxJh/gWbMO6wa4e/IobzTkdxMCV kWECH1vjJqdxcIH9bzKTmF4nNlUZShY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746004455; x=1777540455; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=kHVEc8zjUPMH7G4HGjTeGTenLpyMSz3DwGmSVQIByDo=; b=ks8NopbRRmvEmPGCVHioH/AIwVwe/Q5KfzMtHeQSqHTS4+oAjfIR0EWX LLo53sAjnpl0W1CrPLj9Q5xJvEgamMi6dzuzyIpSzRjPVR1TMi8UIwJRG PMkY20bdm3ra8QTrQ0XC+I4CNn0Sj+wcDiA44UXLPzycEo3wLUIoZN9YS THF+NUS+ph01qQJaK7tjcCIdI+VkfPIHd/GLmipwZ+28Ra1UVGf7JOTwm 9zRxOmr6rlLIlpyl+1To7TYqPwH83hu75DFzu6EXfxHyMuXX4GRM6fupI 0f18g8u+f+O3Asf06tTFnhv+sPmz5XpRkC4xXJnxEUW8/l6zWT5tsd3l/ Q==; X-CSE-ConnectionGUID: AaxK3yylQJ2EHCSYA1aaVA== X-CSE-MsgGUID: CXPJt89VQwO5Ge2YKzWbGA== X-IronPort-AV: E=McAfee;i="6700,10204,11418"; a="47373606" X-IronPort-AV: E=Sophos;i="6.15,251,1739865600"; d="scan'208";a="47373606" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2025 02:14:13 -0700 X-CSE-ConnectionGUID: YEXECjo8RKCKjIXwu16b/g== X-CSE-MsgGUID: RKGbql3uQCmIb7VhTCfVLw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,251,1739865600"; d="scan'208";a="134013731" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa007.fm.intel.com with ESMTP; 30 Apr 2025 02:14:09 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id 266AF207; Wed, 30 Apr 2025 12:14:08 +0300 (EEST) Date: Wed, 30 Apr 2025 12:14:08 +0300 From: "Kirill A. Shutemov" To: Mike Rapoport , David Hildenbrand Cc: Tom Lendacky , Andrew Morton , Vlastimil Babka , Mel Gorman , "Kalra, Ashish" , Rick Edgecombe , linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Roth Subject: Re: SNP guest crash in memblock with unaccepted memory Message-ID: <43o2gni2stscuwjfr2cyawn4ikcfhsroact6t7civ3ud3e6sgi@jizmzw7lpzvt> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: bga5dcrxft6qb3mqzk4nntn7yog5tc5b X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7898FA0007 X-Rspam-User: X-HE-Tag: 1746004454-591688 X-HE-Meta: U2FsdGVkX197IdYDjkb1PJmLHPLhFq0rAilIDrfeTR5QfwNLb5vNx5zx0VV+b1mmtJ/JzmQGpsP/Cizqcb0c1fLS1cwqvPL6UsOxXixKF9/e2G8U03XiMV+FsKkbsfc7VKTh6oSTF0bSYd85RX3BuopMEiugq+10DtVFiLSo4bzlirHdkurQmNfOKzHroDdu4aImY19GKNpW+DQ5lwqI1GrhsyZ8Q0CSBCYKC13eSXIsOnuLpMhhZpdPhNkZCwVdOFVyNfe64FuIJhs/pYGYUlXEBNSDEvCeTx3ILu1q3s3Z4d7yVegyPfPZcA6o2iYy/UVXZBPZ/KEvELhih2xZLnLOSJTLTbwtbddUyLPpjqrVGOv+/mmdJ7/Fq2H/doesjvCdeqFuOeXvc7NqJdtWjD8eWoyLZvvpdRS/pcf9yco7igUICLwF3Y2WWVa60qP1aIDsfj/e8dSuL3DZFG74PhNvx8oysgkXj70E6JuXp8QBg4YaTTImP/C76VuvDCU5Jbm27FCxKLzDmw7F0SnvpyEx+bhi14LkodA0/aWJS110L8uzG75tmPj7Gp94jfR8chRRkwADRoB3koHIdBEj57K1gQIlOJ8d+oD8wJz5xJu69HneqiQPvh9LPaCsgMPXEhaD0cQyn0FEzqMzNcY1XP6YQNQ3oxjFThNBQ/H8YXjinrojsh6sEM/SMyzrQXbY5vmY2OJ65tccxKYXawl5sbaKoQ22f2fRINJ/4hVC9OpD759DftzsTayRk+W+opNy5o+cTzqZskLUm0SkZvSGAFG25rp5PpE8tYIdvKPPCdGeW6gmB9+23M50Ym3LHfZv9Q7C4kNvoTXX6VX5+Uwg/h8oFAZ5Zn/BjcPTfJdeHyFtJk5Du6va+n0aHkd+JOW4L4OYgb/51PrMMGnXqHPNSOEehG8ndcRRdNtjGZ2Pn1GLUzvOUOYFBdNz1gv2DyrLhT1zirfpYU+mpr8OkeM UpjE79pt gcZyTrmTjy7LnJxd7ZdiwFgI0OyHMyr8MJiFXyaYcuH7d5Gvr6nOgE5kF644wGdI7+Dg3EaiaN8Fxy2AkgaX68hgWicqySKBfXOcoU3XIk0HgqjS23slBDlndHni+GQ0lv0Mr3RU6EBrfd2jjmDU5sNXkZsN97Awoz6Xg4ZT7AhgSRFlcXZlswIMR9A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 04:04:50PM +0200, David Hildenbrand wrote: > On 27.04.25 17:01, Tom Lendacky wrote: > > Hi Kirill, > > > > Every now and then I experience an SNP guest boot failure for accessing > > memory that hasn't been accepted. I managed to get a back trace: > > > > RIP: 0010:memcpy_orig+0x68/0x130 > > Code: ... > > RSP: 0000:ffffffff9cc03ce8 EFLAGS: 00010006 > > RAX: ff11001ff83e5000 RBX: 0000000000000000 RCX: fffffffffffff000 > > RDX: 0000000000000bc0 RSI: ffffffff9dba8860 RDI: ff11001ff83e5c00 > > RBP: 0000000000002000 R08: 0000000000000000 R09: 0000000000002000 > > R10: 000000207fffe000 R11: 0000040000000000 R12: ffffffff9d06ef78 > > R13: ff11001ff83e5000 R14: ffffffff9dba7c60 R15: 0000000000000c00 > > memblock_double_array+0xff/0x310 > > memblock_add_range+0x1fb/0x2f0 > > memblock_reserve+0x4f/0xa0 > > memblock_alloc_range_nid+0xac/0x130 > > memblock_alloc_internal+0x53/0xc0 > > memblock_alloc_try_nid+0x3d/0xa0 > > swiotlb_init_remap+0x149/0x2f0 > > mem_init+0xb/0xb0 > > mm_core_init+0x8f/0x350 > > start_kernel+0x17e/0x5d0 > > x86_64_start_reservations+0x14/0x30 > > x86_64_start_kernel+0x92/0xa0 > > secondary_startup_64_no_verify+0x194/0x19b > > > > I don't know a lot about memblock, but it appears that it needs to > > allocate more memory for it's regions array and returns a range of memory > > that hasn't been accepted. When the memcpy() runs, the SNP guest gets a > > #VC 0x404 because of this. > > > > Do you think it is as simple as calling accept_memory() on the memory > > range returned from memblock_find_in_range() in memblock_double_array()? > > (not Kirill, but replying :) ) > > Yeah, we seem to be effectively allocating memory from memblock ("from > ourselves") without considering that memory must be accepted first. > > accept_memory() on the new memory (in case of !slab) should be the right > thing to do. Right, it should do the trick. BTW, Mike, is there any other codepath where memblock allocates memory for itself? We need to cover them too. -- Kiryl Shutsemau / Kirill A. Shutemov