From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75057C433E2 for ; Wed, 16 Sep 2020 13:05:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C037522274 for ; Wed, 16 Sep 2020 13:05:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C037522274 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1EEB26B0062; Wed, 16 Sep 2020 09:05:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 178286B0068; Wed, 16 Sep 2020 09:05:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 067F16B006C; Wed, 16 Sep 2020 09:05:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id E142B6B0062 for ; Wed, 16 Sep 2020 09:05:56 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 97396181AC9BF for ; Wed, 16 Sep 2020 13:05:56 +0000 (UTC) X-FDA: 77268947112.05.brick83_38136102711a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id B4BB11802A365 for ; Wed, 16 Sep 2020 13:05:52 +0000 (UTC) X-HE-Tag: brick83_38136102711a X-Filterd-Recvd-Size: 3030 Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Sep 2020 13:05:50 +0000 (UTC) Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 974EABA62EEEB2F306B2; Wed, 16 Sep 2020 21:05:43 +0800 (CST) Received: from [127.0.0.1] (10.57.60.129) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Wed, 16 Sep 2020 21:05:34 +0800 Subject: Re: [PATCH] mm/madvise.c: Remove the unused include statements To: Wei Yang , Tian Tao CC: , , , References: <1599823111-51431-1-git-send-email-tiantao6@hisilicon.com> <20200916125956.GA48267@L-31X9LVDL-1304.local> From: "tiantao (H)" Message-ID: <43fd7997-9a1d-1baf-943b-4e4320d94339@huawei.com> Date: Wed, 16 Sep 2020 21:05:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20200916125956.GA48267@L-31X9LVDL-1304.local> Content-Type: text/plain; charset="gbk"; format=flowed X-Originating-IP: [10.57.60.129] X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: B4BB11802A365 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: #include #include #include #include #include #include #include #include #include #include #include #include #include <--------- #include #include #include #include #include #include #include #include #include #include #include #include <--------- git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git you can see the linux/sched/mm.h is included more than once =D4=DA 2020/9/16 20:59, Wei Yang =D0=B4=B5=C0: > On Fri, Sep 11, 2020 at 07:18:31PM +0800, Tian Tao wrote: >> linux/sched/mm.h is included more than once, Remove the one that isn't >> necessary. >> >=20 > Would you mind giving more detail about this re-include? I don't see th= e file > linux/sched/mm.h is included for more than once. >=20 >> Signed-off-by: Tian Tao >> --- >> mm/madvise.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/mm/madvise.c b/mm/madvise.c >> index c5acc2b..8c175f9 100644 >> --- a/mm/madvise.c >> +++ b/mm/madvise.c >> @@ -30,7 +30,6 @@ >> #include >> #include >> #include >> -#include >> >> #include >> >> --=20 >> 2.7.4 >=20