From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93BE8C2BD09 for ; Wed, 10 Jul 2024 03:16:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C6596B00A1; Tue, 9 Jul 2024 23:16:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 077206B00A4; Tue, 9 Jul 2024 23:16:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E80246B00A5; Tue, 9 Jul 2024 23:16:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CA0136B00A1 for ; Tue, 9 Jul 2024 23:16:15 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 684DB41B45 for ; Wed, 10 Jul 2024 03:16:15 +0000 (UTC) X-FDA: 82322379510.24.5B063EF Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) by imf15.hostedemail.com (Postfix) with ESMTP id 25E5BA0011 for ; Wed, 10 Jul 2024 03:16:10 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=gzxK4JI1; spf=pass (imf15.hostedemail.com: domain of xiongwei.song@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=xiongwei.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720581331; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ab57vPDAVW6n2fvyGHo7nNxLm+m7V/+rr2GUI7WVKJg=; b=G4OxX4WKrzWBJBXRXwzblMD5Moq82MeXI3lCafum2pLym1ddSGWJ1TTvsrTdBUNrgQ3duE IUfJhRDkHj17o4bFpa8DnoJIPXZCEtn8hDFN3uyA6y82qHPHpnmfNGB7IgnAkPAVJz9n8C 6QqbCoP1q1meZVAbWzDJCpUIBKQEe0Q= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=gzxK4JI1; spf=pass (imf15.hostedemail.com: domain of xiongwei.song@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=xiongwei.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720581331; a=rsa-sha256; cv=none; b=M6vOMTpFA6/P5O4ytPnu2V1EF+X4//fYu0m1Hvz0NcQ0AxPnKhfDtE5mubADpJtY13sBcs TmqEUy1EECcM2RyrVi5sw0uQLtPKJn+BZG3sLBW01NmJPI0a2Fbkrn/4pZTxIH8Wfg5SJw sXNF9jNz7yX6K+dnv8ulHoydj9UnhAE= X-Envelope-To: willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1720581368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ab57vPDAVW6n2fvyGHo7nNxLm+m7V/+rr2GUI7WVKJg=; b=gzxK4JI1hQdkiilYBppppSxd6E3NMcRJKQ17Oo7M30MovjFrxG/DZRb8AnPKrmzVltEPuB 5N9bCEZScgcOdj1UHAU1R2KzTV91DfI7BUDhmsGMjLcKuAhM55xDtLhWe0yLXR8ZMykuZq 9ETXsSCuUJzWaKvlJ+o9F5ijarLjnTM= X-Envelope-To: vbabka@suse.cz X-Envelope-To: surenb@google.com X-Envelope-To: cl@linux.co X-Envelope-To: penberg@kernel.org X-Envelope-To: rientjes@google.com X-Envelope-To: iamjoonsoo.kim@lge.com X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: roman.gushchin@linux.dev X-Envelope-To: 42.hyeyoo@gmail.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: lkp@intel.com X-Envelope-To: nathan@kernel.org X-Envelope-To: llvm@lists.linux.dev X-Envelope-To: ndesaulniers@google.com X-Envelope-To: sxwjean@me.com MIME-Version: 1.0 Date: Wed, 10 Jul 2024 03:16:06 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: xiongwei.song@linux.dev Message-ID: <43ca4cc6d11f2cff96f2596783442d5ca4b9358e@linux.dev> TLS-Required: No Subject: Re: [PATCH] mm/slub: quiet the clang warning with -Wunused-function enabled To: "Matthew Wilcox" Cc: vbabka@suse.cz, surenb@google.com, cl@linux.co, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "kernel test robot" , "Nathan Chancellor" , llvm@lists.linux.dev, "Nick Desaulniers" , sxwjean@me.com In-Reply-To: References: <20240710025418.394321-1-sxwjean@me.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 25E5BA0011 X-Stat-Signature: t1p5fbyiei1gt5p4x74ztyefb9yiyisb X-Rspam-User: X-HE-Tag: 1720581370-742281 X-HE-Meta: U2FsdGVkX19fhb/RD9ADxM5m8KMe1L3xWQA/0xB0RC20Urn+PqMBViGxAfwkSgxeuAqLD+fRLBQOqkHS5/peAO8EtCpghVJqxY7SDJdhHZD5rFcP7FGo2jF6rhcZyO1rN3uLb9/TB8x5ZBJdHcM8sElIhHrWEG0iSvbCHgbzk0aTJrfkfzxfYJ2Nj+b9Xa0LEHuxbEiW7enfsJHdyw6SU2vWYBDp5MJsSoxpcjuMD1teuZfggUBzGHxgD+Pz/9aGM7CxMwM6YSmFQDT10X6hQIPaZGkxq+nhXJzARbJSmwGBwb4F6aIpuatKehliay92fqqdGLmbbEdunUn9Mt3z6BNSL5SUgt/me+54Afj7AtfnSKGWN29mnj74V5C3OaZI+GF62ugLwH2WBoyo1OKdEoQ3/2LKc3w0XRY7Mo+Z9lpcPLfLsBBKhzkA0kQE8qIyRTHusfPTHGr2zV7+37XnY+Htdu16iZ+30ci4SWlUveLTkw3sRJgtY1OA8ZS7P11itlDHjN/pWWQ3yIjVKBwZkkUiMzj4wsxMdKSK5Su7FLspHI3si4DFShVbrGpWetP8jKRd+N0myTm/cXovIDD02wfpIz67Q3VeXOxBqrik8i50n2YLg954lE0VUGUMVKZFsuf6vmWYT+6kMo8+8yeEsRDTjn7zdT9jXNb3ak5P4h972fG+VWCArcbKDk/16LP/G3f5J+TwA1uGRUX9DZYBSSXsrxwleRAY82Cgp1AdlNXlCXXyybDvNl2jMYFqIc6OmR3PjmvXSe9OhZGCfKqLNTt+noRnmC8d3BPm/MrfPnRwF5YieBSLPD/WvdhDONT26pW8tYDSl7yFcqKS2NV0Se7uiEegrhYJB4uWjDUAN8Z4iPfd02lJYBiSqP/SRoi6Yxq1BvKpii/T+80R3w9Pxb5cp7hAb/TQzBfkJ7RIJoShCblaS/5XJAgQWqxBgRjBhmxPq+nZMBzqa8BkFkd F0icemNt PAgT6OWuMwfClRcRMq7G2M9JKysWJhLat+8/hdgEZaM8s6xfBvdHi5/5AGpS/00s+d5IbUSDS89R4z1PBAN4ESidINtTpIrZnmAThuXxlLRYAITCrSdlR35A6nILhANQrfK3Kj2IhimNPBO2MTqSUH0D+ApeAjuVftSRR1gZoLFgHcxSbq5q2bsBxjcTsytPDjNl4E1PACOUw0r+xJMq+NsQEoieky/H87izHfpdbl+n7eWwqaHfb2MuBp+C6//E/NFHQ8joVNNxurD0FVnmzVyDgdFs4/Wj7OpM8n0mxi0Ea6XWx+0T3+zGLoM40vFtHLifcJFVIe0PpgHFWlAKwfZpEAZIejWnbFmfeH5RY5z+96rs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: July 10, 2024 at 11:03 AM, "Matthew Wilcox" wrote: >=20 >=20On Wed, Jul 10, 2024 at 10:54:18AM +0800, sxwjean@me.com wrote: >=20 >=20>=20 >=20> From: Xiongwei Song > >=20 >=20>=20=20 >=20>=20 >=20> The only user of prepare_slab_obj_exts_hook() is > >=20 >=20> alloc_tagging_slab_alloc_hook(), which can build with > >=20 >=20> CONFIG_MEM_ALLOC_PROFILING enabled. So, the warning was triggerred > >=20 >=20> when disabling CONFIG_MEM_ALLOC_PROFILING. Let's add "__maybe_unus= ed" > >=20 >=20> for prepare_slab_obj_exts_hook(). > >=20 >=20 > Perhaps instead clang can be fixed to match gcc's behaviour? Maybe, I'm not sure.=20 Thanks, Xiongwei >=20 > >=20 >=20> Reported-by: kernel test robot > >=20 >=20> Closes: https://lore.kernel.org/oe-kbuild-all/202407050845.zNONqau= D-lkp@intel.com/ > >=20 >=20> Signed-off-by: Xiongwei Song > >=20 >=20> --- > >=20 >=20> mm/slub.c | 4 ++-- > >=20 >=20> 1 file changed, 2 insertions(+), 2 deletions(-) > >=20 >=20>=20=20 >=20>=20 >=20> diff --git a/mm/slub.c b/mm/slub.c > >=20 >=20> index ce39544acf7c..2e26f20759c0 100644 > >=20 >=20> --- a/mm/slub.c > >=20 >=20> +++ b/mm/slub.c > >=20 >=20> @@ -2027,7 +2027,7 @@ static inline bool need_slab_obj_ext(void) > >=20 >=20> return false; > >=20 >=20> } > >=20 >=20>=20=20 >=20>=20 >=20> -static inline struct slabobj_ext * > >=20 >=20> +static inline struct slabobj_ext * __maybe_unused > >=20 >=20> prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void= *p) > >=20 >=20> { > >=20 >=20> struct slab *slab; > >=20 >=20> @@ -2068,7 +2068,7 @@ static inline bool need_slab_obj_ext(void) > >=20 >=20> return false; > >=20 >=20> } > >=20 >=20>=20=20 >=20>=20 >=20> -static inline struct slabobj_ext * > >=20 >=20> +static inline struct slabobj_ext * __maybe_unused > >=20 >=20> prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void= *p) > >=20 >=20> { > >=20 >=20> return NULL; > >=20 >=20> --=20 >=20>=20 >=20> 2.34.1 > > >