From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 734C7C4167B for ; Mon, 4 Dec 2023 06:53:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00F2C6B027F; Mon, 4 Dec 2023 01:53:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F27C96B0280; Mon, 4 Dec 2023 01:53:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF0A76B0281; Mon, 4 Dec 2023 01:53:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CBE746B027F for ; Mon, 4 Dec 2023 01:53:31 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 98032140111 for ; Mon, 4 Dec 2023 06:53:31 +0000 (UTC) X-FDA: 81528219822.30.FF781BC Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf20.hostedemail.com (Postfix) with ESMTP id BC16C1C001B for ; Mon, 4 Dec 2023 06:53:29 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=IfwoErcS; spf=pass (imf20.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.46 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701672809; a=rsa-sha256; cv=none; b=NV3GO0XdudKpHyYBaHG53nC5dI7HFgu51l8YWY2oFhbDXtBpCMZQ5RktwAcbErGnuWOJRH 2Uu7AWBxyKU7QjSm8mv6uO+ThhkSCMcFZT+n+uwRcNuCt8Lu+vis1P6ULYtXRik4J9b4Xl nWHzCizj47HZlc1M2mk5iMTOL6242Oo= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=IfwoErcS; spf=pass (imf20.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.46 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701672809; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=7HssFuAN0FmKtkeeOfUTQqNEnbKypEzyj8/UffXjzYs=; b=LjqUXpJN48ZenO8UnqaiZSqmstZPvMrQh2y21hCetNY/puORcV9JYQRyIXmwm3dX0WLHGC LOL4QHmfWXs4jNWbS/Gm46nT/CEnJ8ziA1plhZB933Vguh+bga0wy+DLuqRxf/F49+d3Xp hW4B/BgsSU83Yrk5L6OjXEQgXg+WqHE= Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-40c09fcfa9fso9004455e9.2 for ; Sun, 03 Dec 2023 22:53:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701672808; x=1702277608; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7HssFuAN0FmKtkeeOfUTQqNEnbKypEzyj8/UffXjzYs=; b=IfwoErcS5KL4fkKMtMlTreg83jd1Aqgg1AkkGVgAAWaewFbT+NR5dhVN6HWrQdh1Tt 86kYZ339fTC3GuSw5q/VDdfIryFrk8qMnHAVE7vTL89hcZJhmn7PutqUZA4g2Tn48gF8 MS58xTE1xaO4+FEpXelXYsItVsJLMl/O6oyU3yWxT6A0UkgmrhYkgn7sW8pb6ypyBlF/ qKOFenuQqHR6ZBSKuBLXqhh0y3RK/GyT/r/7Z7NyVf0wiMOHtv033uTM3RJNSBi6M7C7 N59D9GKBaqFCZlhxrPdsAim9a4SaVg+dtMarJW672/+2wz4BwVZboYPT0batnO6qMPHc 5XXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701672808; x=1702277608; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7HssFuAN0FmKtkeeOfUTQqNEnbKypEzyj8/UffXjzYs=; b=nGCfYXYE6a9JEJDSbgZWYmMviG80H/jeJUHZcS0TI0F7tNej1rhEFJFDC62X7L+dmP +iBAw6U9W1xtyV21MGsvcKxBsSwUj/1fPsyn8HdO8ok/Bb2YfDOf9q6ctJ/u5a52mVOC EZUyXTIM25h2Dds3bQlkiNjtd7QmlDeDXyl3V+oDpTywO4fPU0e1qn0Tj1wLxC6RO3lY cWYgGnenZsGPKqfWq0HVPujdY43hmkQN90RVfpdueyTATe0Ha4Xv0wvfDs118whLi9jN NIHJyijyWRxAWeWWJWxhmyeJjcdY41OAwCtvmmcCmBrjuengSaAGFXUQZlQCq1X295lE iiBg== X-Gm-Message-State: AOJu0YyMuwG5t9qhiBids4yimfdMhf9xvvq4rK+F+3q91BO/PmsMOvBZ oBS4uJjHJn++qOqugaERenhEsw== X-Google-Smtp-Source: AGHT+IHtHa+5n4xN3AEKMSwT6hpelKtTdR3K3TiRCO07QqooArIjEdGOaVc05secXlj0uyQfVGAD9w== X-Received: by 2002:a05:600c:4fcf:b0:40b:5f03:b3b7 with SMTP id o15-20020a05600c4fcf00b0040b5f03b3b7mr968898wmq.217.1701672808259; Sun, 03 Dec 2023 22:53:28 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id q4-20020a05600000c400b003333fa3d043sm4558913wrx.12.2023.12.03.22.53.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Dec 2023 22:53:28 -0800 (PST) Date: Mon, 4 Dec 2023 09:53:24 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Huan Yang , Tejun Heo , Zefan Li , Johannes Weiner , Jonathan Corbet , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , David Hildenbrand , Matthew Wilcox , Huang Ying , Yosry Ahmed , Kefeng Wang , Peter Xu , "Vishal Moola (Oracle)" , Liu Shixin , Yue Zhao , Hugh Dickins , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , opensource.kernel@vivo.com, Huan Yang Subject: Re: [PATCH 2/4] mm: multi-gen LRU: MGLRU unbalance reclaim Message-ID: <43b48148-fdfb-4ea3-8d7b-d3ebce7a04da@suswa.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231108065818.19932-3-link@vivo.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: BC16C1C001B X-Stat-Signature: qdqhr8th1sn4m6p9htccizr38goa7h9a X-Rspam-User: X-HE-Tag: 1701672809-884927 X-HE-Meta: U2FsdGVkX18Gch0qKAAtNHB/TkaLXq/PKi4KokDdd5cB0XO291/YzTag0n4qZVRUHwJMpQ62NNwS7VIx3K6lEUySHaGTIr75B3Fd0qtibyf0HCy4tf0JBms+edTJvjz0gPFWnFdafD3y7O+TcUspJbN0F2ZvNpCaP5JmRllF+vRVmtXfgL/CxWiPwVramHF/W3Fz7EKyC79aw2DbH9M4aB/n4Hbs91oxiAHD2b+UslVnuVPXyPPD1a2Hw2DCYFROcEx3giMrInSWKPDBoLnyqEUQTou8aBzODWkD7KZ3hEt6v9BiXLzPfik0AG3GhUj78A7eWrKB97GOSm+SRoTIBgmoq7mBAGjdVRu0JumMKtcOcB+vjC2GPIsw4l8q1Ji5W9tqrYO6PLDVps0tjK7tmVL/ZGQkNpDD/t7R6ufwG/EPawtPDbGxpRl2jLcRaqzXRKdVsHJxvtkk7i15CYjrjrD35Sl5APHJOzTMx41ABj1MTRMy7esSp7hJWZF+7XWYNyLBiI7Lp002r+Db2fGYme3WTOp7K/hE5ahP8E7oFSpLhclwFgUPMHJf+L/FbFU7fO+rqGhtBGTY/Ebcf3bfM7OkXW62GmDQODAN9aEzwVuvNq2jdK2C6VDNlz5itAxhfyDOz+QMiw5RkrxZVbutBCsbPpmhkeJzVJ+3WbZXIENxJ8JjGw3cAuZWfD8Qf5Acw9FDwlTDLoaFPlIVCzAlxSi4j5EXsaJcOft/rYMVRJ+6zGks3Qs249fJDIJ3CuK54eeFmjzeV3cmUoxhH3ZoU/GB78L+Q9y7GG/QEiaBPbHc1e9xcMRxVG07AYsufpzHqNRMNF5ArkaTNE0YxK0jhXYmrDyONIKfaYIc/GHpOgdjLFuEHAMQ8lxeRO1g/cNzu4ol0JDurIuR+uBB+sMSv8F52x15YQMNB7v79uo9jyspxQ+rFea5WsBFu313EgEzXTieRFtaBhPEFSZ+Az5 ycJP1bPk mv9yDVWW1uItjrbw9TE88B7gg27l9TvhBc0PmQXqBeYZWWin82Tz+Bs8MJf0lXBM3qbOgs3Aoy9Cw/WZtZFCw1eFDBogaRb1P8zLJDI12ML746SVUJsr9QD13fT1ly+kISZMkCu17/TS+cj90L4PD6n2SkC+egWXPl1/PYDbibz/lhBWg3Tjoy6jEnkritUfp/RovtclRa2hcG0Yciwzh9QgoPyMAI4vwH4TJDUkI3vy43ImtmNtmNc4KeVycvEkM1AKw5YyHEZtwoSGp4tPbQ95NKqDW2pt78SQsHs1y5G1ZR8OcEaLUpyS/XLXl2FQ9Qa/rldDyp4NxlwAugljpkYAODfHMDvRswcVA9QE5GnPVz5KKGyqs3XSp1iuHMDge4JJGHZrib994MeEU+eLjqnryb3ExsRj3TQdN8slv/YwnWCIvuSyF4h/UEgv40+e8jDqOH8dEfpxe/QcsptEeyT9WlVVnc3aotl4pxpYgDAz35xgtOUFrmwNyx8gV/pRhAnLwD+39ZD2KEeEY2j2npuZkM37GD+twRWv2Nupe8K7S1uYHn42FVRRW1fOY/SOrwEtfEbQLqSnCk6Ng7D3OpvuWHeNaTDwi+ergwKgp0npSv1HZBlqsjKvFYA4PpTzJ/Oguo4AAzNNoMiZr07Q6GgCfaHIfM52OSjg3inX1VxxA4muJHHuFi27IKMam3yRawZK3tl2ZTHTUrM8RJGKf5gwgiA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Huan, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Huan-Yang/mm-vmscan-LRU-unbalance-cgroup-reclaim/20231108-151757 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20231108065818.19932-3-link%40vivo.com patch subject: [PATCH 2/4] mm: multi-gen LRU: MGLRU unbalance reclaim config: x86_64-randconfig-161-20231108 (https://download.01.org/0day-ci/archive/20231204/202312040256.guajrRNm-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20231204/202312040256.guajrRNm-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202312040256.guajrRNm-lkp@intel.com/ smatch warnings: mm/vmscan.c:4518 isolate_folios() error: uninitialized symbol 'unbalance'. vim +/unbalance +4518 mm/vmscan.c ac35a490237446 Yu Zhao 2022-09-18 4481 static int isolate_folios(struct lruvec *lruvec, struct scan_control *sc, int swappiness, ac35a490237446 Yu Zhao 2022-09-18 4482 int *type_scanned, struct list_head *list) ac35a490237446 Yu Zhao 2022-09-18 4483 { ac35a490237446 Yu Zhao 2022-09-18 4484 int i; ac35a490237446 Yu Zhao 2022-09-18 4485 int type; ac35a490237446 Yu Zhao 2022-09-18 4486 int scanned; ac35a490237446 Yu Zhao 2022-09-18 4487 int tier = -1; 9da842af0b17c7 Huan Yang 2023-11-08 4488 bool unbalance; unbalance is never set to false. Only to true. ac35a490237446 Yu Zhao 2022-09-18 4489 DEFINE_MIN_SEQ(lruvec); ac35a490237446 Yu Zhao 2022-09-18 4490 ac35a490237446 Yu Zhao 2022-09-18 4491 /* ac35a490237446 Yu Zhao 2022-09-18 4492 * Try to make the obvious choice first. When anon and file are both ac35a490237446 Yu Zhao 2022-09-18 4493 * available from the same generation, interpret swappiness 1 as file ac35a490237446 Yu Zhao 2022-09-18 4494 * first and 200 as anon first. ac35a490237446 Yu Zhao 2022-09-18 4495 */ 9da842af0b17c7 Huan Yang 2023-11-08 4496 if (unlikely(unbalance_file_reclaim(sc, swappiness))) { 9da842af0b17c7 Huan Yang 2023-11-08 4497 unbalance = true; 9da842af0b17c7 Huan Yang 2023-11-08 4498 type = LRU_GEN_FILE; 9da842af0b17c7 Huan Yang 2023-11-08 4499 } else if (unlikely(unbalance_anon_reclaim(sc, swappiness))) { 9da842af0b17c7 Huan Yang 2023-11-08 4500 unbalance = true; 9da842af0b17c7 Huan Yang 2023-11-08 4501 type = LRU_GEN_ANON; 9da842af0b17c7 Huan Yang 2023-11-08 4502 } else if (!swappiness) ac35a490237446 Yu Zhao 2022-09-18 4503 type = LRU_GEN_FILE; ac35a490237446 Yu Zhao 2022-09-18 4504 else if (min_seq[LRU_GEN_ANON] < min_seq[LRU_GEN_FILE]) ac35a490237446 Yu Zhao 2022-09-18 4505 type = LRU_GEN_ANON; ac35a490237446 Yu Zhao 2022-09-18 4506 else if (swappiness == 1) ac35a490237446 Yu Zhao 2022-09-18 4507 type = LRU_GEN_FILE; ac35a490237446 Yu Zhao 2022-09-18 4508 else if (swappiness == 200) ac35a490237446 Yu Zhao 2022-09-18 4509 type = LRU_GEN_ANON; ac35a490237446 Yu Zhao 2022-09-18 4510 else ac35a490237446 Yu Zhao 2022-09-18 4511 type = get_type_to_scan(lruvec, swappiness, &tier); ac35a490237446 Yu Zhao 2022-09-18 4512 ac35a490237446 Yu Zhao 2022-09-18 4513 for (i = !swappiness; i < ANON_AND_FILE; i++) { ac35a490237446 Yu Zhao 2022-09-18 4514 if (tier < 0) ac35a490237446 Yu Zhao 2022-09-18 4515 tier = get_tier_idx(lruvec, type); ac35a490237446 Yu Zhao 2022-09-18 4516 ac35a490237446 Yu Zhao 2022-09-18 4517 scanned = scan_folios(lruvec, sc, type, tier, list); 9da842af0b17c7 Huan Yang 2023-11-08 @4518 if (scanned || unbalance) ^^^^^^^^^ ac35a490237446 Yu Zhao 2022-09-18 4519 break; ac35a490237446 Yu Zhao 2022-09-18 4520 ac35a490237446 Yu Zhao 2022-09-18 4521 type = !type; ac35a490237446 Yu Zhao 2022-09-18 4522 tier = -1; ac35a490237446 Yu Zhao 2022-09-18 4523 } ac35a490237446 Yu Zhao 2022-09-18 4524 ac35a490237446 Yu Zhao 2022-09-18 4525 *type_scanned = type; ac35a490237446 Yu Zhao 2022-09-18 4526 ac35a490237446 Yu Zhao 2022-09-18 4527 return scanned; ac35a490237446 Yu Zhao 2022-09-18 4528 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki