From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: kernel@kolivas.org, linux-mm@kvack.org, ck@vds.kolivas.org,
pj@sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Implement Swap Prefetching v23
Date: Fri, 10 Feb 2006 16:01:02 +1100 [thread overview]
Message-ID: <43EC1E0E.6060702@yahoo.com.au> (raw)
In-Reply-To: <20060209205559.409c0290.akpm@osdl.org>
Andrew Morton wrote:
> Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
>>Andrew Morton wrote:
>>
>>>Con Kolivas <kernel@kolivas.org> wrote:
>>>
>>>
>>>>Ok I see. We don't have a way to add to the tail of that list though?
>>>
>>>
>>>del_page_from_lru() + (new) add_page_to_inactive_list_tail().
>>>
>>>
>>>
>>>>Is that
>>>>a worthwhile addition to this (ever growing) project? That would definitely
>>>>have an impact on the other code if not all done within swap_prefetch.c..
>>>>which would also be quite a large open coded something.
>>>
>>>
>>>Do both of the above in a new function in swap.c.
>>>
>>
>>That'll require the caller to do lru locking.
>>
>>I'd add an lru_cache_add_tail, use it instead of the current lru_cache_add
>>that Con's got now, and just implement it in a simple manner, without
>>pagevecs.
>
>
> umm, that's what I said ;)
>
You said del_page_from_lru(), which doesn't belong in a function
called lru_cache_add_tail.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-02-10 5:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-10 2:55 Con Kolivas
2006-02-10 3:25 ` Andrew Morton
2006-02-10 3:49 ` Con Kolivas
2006-02-10 4:07 ` Nick Piggin
2006-02-10 4:14 ` Con Kolivas
2006-02-10 4:17 ` Nick Piggin
2006-02-10 4:25 ` Andrew Morton
2006-02-10 4:45 ` Nick Piggin
2006-02-10 4:55 ` Andrew Morton
2006-02-10 5:01 ` Nick Piggin [this message]
2006-02-10 5:26 ` Con Kolivas
2006-02-10 5:32 ` Nick Piggin
2006-02-10 5:37 ` Con Kolivas
2006-02-10 5:43 ` Nick Piggin
2006-02-10 5:48 ` Con Kolivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43EC1E0E.6060702@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=ck@vds.kolivas.org \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox