From: Manfred Spraul <manfred@colorfullife.com>
To: Ravikiran G Thirumalai <kiran@scalex86.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-mm@kvack.org, clameter@engr.sgi.com,
Alok Kataria <alokk@calsoftinc.com>
Subject: Re: [patch 3/3] mm: NUMA slab -- minor optimizations
Date: Tue, 27 Dec 2005 00:42:33 +0100 [thread overview]
Message-ID: <43B07FE9.4000803@colorfullife.com> (raw)
In-Reply-To: <20051129085456.GC3573@localhost.localdomain>
Ravikiran G Thirumalai wrote:
>Patch adds some minor optimizations:
>1. Keeps on chip interrupts enabled for a bit longer while draining cpu
>caches
>2. Calls numa_node_id once in cache_reap
>
>Signed-off-by: Alok N Kataria <alokk@calsoftinc.com>
>Signed-off-by: Ravikiran Thirumalai <kiran@scalex86.org>
>Signed-off-by: Shai Fultheim <shai@scalex86.org>
>
>Index: linux-2.6.15-rc1/mm/slab.c
>===================================================================
>--- linux-2.6.15-rc1.orig/mm/slab.c 2005-11-17 21:32:43.000000000 -0800
>+++ linux-2.6.15-rc1/mm/slab.c 2005-11-17 21:32:50.000000000 -0800
>@@ -1914,18 +1914,18 @@
>
> smp_call_function_all_cpus(do_drain, cachep);
> check_irq_on();
>- spin_lock_irq(&cachep->spinlock);
>+ spin_lock(&cachep->spinlock);
>
>
Isn't that a bug? What prevents an interrupt from occuring after the
spin_lock() and then causing a deadlock on cachep->spinlock?
--
Manfred
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-12-26 23:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-29 8:50 [patch 1/3] mm: NUMA slab -- add alien cache drain statistics Ravikiran G Thirumalai
2005-11-29 8:53 ` [patch 2/3] mm: NUMA slab -- node local memory for off slab slab descriptors Ravikiran G Thirumalai
2005-11-29 17:48 ` Christoph Lameter
2005-11-29 8:54 ` [patch 3/3] mm: NUMA slab -- minor optimizations Ravikiran G Thirumalai
2005-11-29 17:53 ` Christoph Lameter
2005-12-26 23:42 ` Manfred Spraul [this message]
2005-12-27 20:35 ` Christoph Lameter
2005-11-29 9:25 ` [patch 1/3] mm: NUMA slab -- add alien cache drain statistics Andrew Morton
2005-11-29 17:57 ` Christoph Lameter
2005-11-29 18:49 ` Ravikiran G Thirumalai
2006-01-02 15:27 [patch 3/3] mm: NUMA slab -- minor optimizations Alok Kataria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43B07FE9.4000803@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=akpm@osdl.org \
--cc=alokk@calsoftinc.com \
--cc=clameter@engr.sgi.com \
--cc=kiran@scalex86.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox