From: Joel Schopp <jschopp@austin.ibm.com>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: linux-mm <linux-mm@kvack.org>,
Linux Hotplug Memory Support <lhms-devel@lists.sourceforge.net>
Subject: Re: [Patch] New zone ZONE_EASY_RECLAIM take 3. (define ZONE_EASY_RECLAIM)[2/5]
Date: Thu, 15 Dec 2005 15:58:28 -0600 [thread overview]
Message-ID: <43A1E704.6040106@austin.ibm.com> (raw)
In-Reply-To: <20051210193849.4828.Y-GOTO@jp.fujitsu.com>
Sorry for the slow reply. Hope feedback isn't too late.
> Index: zone_reclaim/include/linux/mmzone.h
> ===================================================================
> --- zone_reclaim.orig/include/linux/mmzone.h 2005-12-10 17:12:58.000000000 +0900
> +++ zone_reclaim/include/linux/mmzone.h 2005-12-10 17:13:16.000000000 +0900
> @@ -73,9 +73,10 @@ struct per_cpu_pageset {
> #define ZONE_DMA32 1
> #define ZONE_NORMAL 2
> #define ZONE_HIGHMEM 3
> +#define ZONE_EASY_RECLAIM 4
>
> -#define MAX_NR_ZONES 4 /* Sync this with ZONES_SHIFT */
> -#define ZONES_SHIFT 2 /* ceil(log2(MAX_NR_ZONES)) */
> +#define MAX_NR_ZONES 5 /* Sync this with ZONES_SHIFT */
> +#define ZONES_SHIFT 3 /* ceil(log2(MAX_NR_ZONES)) */
>
>
> /*
> Index: zone_reclaim/mm/page_alloc.c
> ===================================================================
> --- zone_reclaim.orig/mm/page_alloc.c 2005-12-10 17:13:15.000000000 +0900
> +++ zone_reclaim/mm/page_alloc.c 2005-12-10 17:15:10.000000000 +0900
> @@ -66,7 +66,7 @@ static void fastcall free_hot_cold_page(
> * TBD: should special case ZONE_DMA32 machines here - in those we normally
> * don't need any ZONE_NORMAL reservation
> */
> -int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES-1] = { 256, 256, 32 };
> +int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES-1] = { 256, 256, 256, 32 ,32};
This line looks wrong. It looks you are initializing a 4 element array with 5
elements.
>
> EXPORT_SYMBOL(totalram_pages);
>
> @@ -77,7 +77,7 @@ EXPORT_SYMBOL(totalram_pages);
> struct zone *zone_table[1 << ZONETABLE_SHIFT] __read_mostly;
> EXPORT_SYMBOL(zone_table);
>
> -static char *zone_names[MAX_NR_ZONES] = { "DMA", "DMA32", "Normal", "HighMem" };
> +static char *zone_names[MAX_NR_ZONES] = { "DMA", "DMA32", "Normal", "HighMem", "Easy Reclaim"};
> int min_free_kbytes = 1024;
>
> unsigned long __initdata nr_kernel_pages;
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-12-15 21:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-10 11:02 Yasunori Goto
2005-12-15 21:58 ` Joel Schopp [this message]
2005-12-16 0:55 ` Yasunori Goto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43A1E704.6040106@austin.ibm.com \
--to=jschopp@austin.ibm.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-mm@kvack.org \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox