From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 933A1D15DB7 for ; Mon, 21 Oct 2024 16:27:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AB246B0085; Mon, 21 Oct 2024 12:27:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05BA26B0088; Mon, 21 Oct 2024 12:27:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8B876B0089; Mon, 21 Oct 2024 12:27:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CB5DB6B0085 for ; Mon, 21 Oct 2024 12:27:52 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 657B1141B5E for ; Mon, 21 Oct 2024 16:27:36 +0000 (UTC) X-FDA: 82698140448.05.1D3505E Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf09.hostedemail.com (Postfix) with ESMTP id 304F814000C for ; Mon, 21 Oct 2024 16:27:39 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=NQXwK2Hn; dmarc=pass (policy=reject) header.from=gentwo.org; spf=pass (imf09.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729527960; a=rsa-sha256; cv=none; b=24afLH3TLBbcgfBJuM6np2Y36DuhjJSF5LIpQnnrCJQWomJvBop1lyq7+DfHm6nll8Qa7w 4kaFclRutHG9zAK3yqaEhmeaVxdfTZ1XQG80q6M2P1hw2LB9TYSVj+3Hu/713apNIUXMFt 3fqzSFt32SuFb8fjp/n22Qse+WGnghg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=NQXwK2Hn; dmarc=pass (policy=reject) header.from=gentwo.org; spf=pass (imf09.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729527960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4dAT0E4ZHVn8f/JfPfuKnMGBQKukdzdZQJDTO+9vUME=; b=a+C/o8Dp0ExlQ8v25NsBLQ1yxnynwzPksAVyWoIaE46LzNpJ5wuF/5Lj92dyM/JJTW6+g7 uXnzXqi/ieY0HzFeOHtMA0LtbYvkDxUbhLTa4j6WFZTt6oWSijmB1WLXXP77ALqsPP8fdt cwODvLAxUYHiNote67PQmlwZtSiTBu8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.org; s=default; t=1729528069; bh=4dAT0E4ZHVn8f/JfPfuKnMGBQKukdzdZQJDTO+9vUME=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=NQXwK2HnmNFMYe+MfTz5MEJ6OMW+TMp0q78gmsVnpN0bXY+gpVpZda0jJCzeUmR45 17u0reya1d9Eq0SOG7XW0ytAnNJ43T8sA7/ePxVBwflEIMmQZ8djYbck+TBIJwUmer CWtLHyRxpJxh7o90mWMXprkdrrwogUjsz0yVhkmM= Received: by gentwo.org (Postfix, from userid 1003) id 86BED4026F; Mon, 21 Oct 2024 09:27:49 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 82EE74026D; Mon, 21 Oct 2024 09:27:49 -0700 (PDT) Date: Mon, 21 Oct 2024 09:27:49 -0700 (PDT) From: "Christoph Lameter (Ampere)" To: Vlastimil Babka cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , linux-mm@kvack.org Subject: Re: [RFC PATCH] mm/slab: fix a memory leak on kobject_init_and_add() failure In-Reply-To: <77d5c04b-9b97-4aee-85a9-c5efb2fa21fe@suse.cz> Message-ID: <439eed20-d0c7-8332-2f17-d785321d3310@gentwo.org> References: <20241021091413.154775-1-42.hyeyoo@gmail.com> <77d5c04b-9b97-4aee-85a9-c5efb2fa21fe@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 304F814000C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qe39wiu96gd8g5rq86gmn7aoqepudnpa X-HE-Tag: 1729528059-51129 X-HE-Meta: U2FsdGVkX1/AdKK56/5No/0PQzfMxzwIPd+eAbKQUGJM7S3eTPl62650GR3dy0I1OgmXc6VkyYyBo/3l6VF+/h0B4fieruIt6/VZ1HVnaPa5oiy3fIkuSwINRSHcVrXSptMPOFi/MXRC1ssm6jOZl0OkMdhaU26kqtEu+rcqAEQNMQoHJac1kZH5XfxK4PBkL7kfj0nBwrn1dJEcaQy85/2ijnzNEj+gdE+xVBJ/DZWvmDZDFYkEyQ3mUfuPeEtW3/7IzWNHi9ou7FWEeMKIYVbMgN55QxnpF/Rkqxvj2KuoNaFnveyZMhxQ8wg0DDcSbDPbQCfu7XZgW8MTU7i3hg6nkmJkSVeqUOWy/TlQVFAAlpCeDReVJIo8/VWuLf7iBM6Ba1MMP80+qrHE2dtuBJ6nZ1V6qEw4t43nFLndqEOH+5ME56Rn0GSFnBhputqar9q8tfX7/3p3NCwz5ccx24cHx6sxl1212W9ziVmjt2VSk7/TFWvUP0IQCfEHP3FxLzyt70HzQCq4WAaGG/qs2G4zFED9uLW4IP6dNrJ6cB4RxB4K/wG806mkzLg+Kgk8XZ0SbRYRojdmG8LlfVX9axjtW0/7PmdZP9ERZRRbTt9Vb3eywKSX8CvunfQtRerIxsizX/Vmg1srhFTWYbU81td/cfoYlHPj5860EtRsFx8StWRhG9EPJPEiFF+kaf0TxMrMo2RIpqYjDQnEPgSKg5cKOe6WFonwxjdZXrW6STr7i6LvNqI9X5O0NwZq8V4oF3zoMl2eHlZmx0+LIbEWv8JNIF6h0i+2l7rgnEAEtP5r0kL6bL5h6afSp+eNLhVDP2a741c+M+rJ6q1CKXAVuTSF3zDeBYP3xIXjqbs4RXrC9/uS4GgNyuQExEzzxltZDg7D1rgUwB5iA9V2dtdXqZYCzv2XfrsBNW1TMVzzLKk7ZRpLA5HpJbpBidSFMLYlasjt9XlKnTudiHWOXEa m1QutOaQ /Jj0+nRo0ZDrNHm7cSXsn3muRiiuQ9ug8H6ruZ9lVY4ekDi/3/e0qTafb2ioHEvHYmHjuYNjGMtZB1/BdtyG2Uv3qD9Fm8BtdNlxHl1SUPbY47LT1/SztjeHZNsJGYc4z9p/bvMpBCi/YOdttzlD84MvaEHuEvXoUQsXzEnFkFpS1mKC/irEqOMGSGAKBQgp78EjedR0TGXzp/eCApnKF9Wz76dy7Mf79O9RBVWL3GZ6DmuMtsgUSGJg7BQMroStmwC/uay3n7MycG38hOHdhAxdPTAqeEw9OovL98bpolnLopLPK/Jdx4JErhiUpad1op8ij X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 21 Oct 2024, Vlastimil Babka wrote: > I think the comment "If this function returns an error, kobject_put() must > be called" means that *if* you want to destroy it due to the failure, you > must use kobject_put() and not e.g. kfree(). But IMHO it doesn't mean you > must destroy it because of the kobject_add() failure. Right. The simplest solution is to see the sysfs stuff as optional. If it fails to create the sysfs pieces then write a warning to syslog but let the cache creation succeed.