From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83F1AE7717D for ; Mon, 9 Dec 2024 22:13:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12B796B00C1; Mon, 9 Dec 2024 17:13:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DC866B00C2; Mon, 9 Dec 2024 17:13:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E48C96B00C3; Mon, 9 Dec 2024 17:13:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C010E6B00C1 for ; Mon, 9 Dec 2024 17:13:08 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7CD62C0529 for ; Mon, 9 Dec 2024 22:13:08 +0000 (UTC) X-FDA: 82876821636.16.28643EB Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf26.hostedemail.com (Postfix) with ESMTP id EDC89140004 for ; Mon, 9 Dec 2024 22:12:49 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=y6cBCICn; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="Vle/n26K"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=y6cBCICn; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="Vle/n26K"; dmarc=none; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733782376; a=rsa-sha256; cv=none; b=IZqhFBXlX5anDUlIl21gNMPHY4W9HfdCXV1xBbT9p69wIYkhBA5+7IWaQA13XcxvyKQ1l+ EzCoMHgdOTOo0vohx90vphFTwuZlFZq5fOwQAY/7tdqxJGCmGl5C+GEythSuOKbJ8l2/Ry LzSZUBDmTC5zNiM7CxahMqOJWdr78gM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=y6cBCICn; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="Vle/n26K"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=y6cBCICn; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="Vle/n26K"; dmarc=none; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733782376; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KCb8IbRo1eRqiNwck2SVw3jDeaAI+uIKJSKUQSk/SbM=; b=AaU0d5m41rkpytHfAWOglSRiPLMUlpyEF3u08wEbL/CdP31Ixuf+/AGj2Vfk0Ij2sEDXAh aHE71tLP3TjzVechuHhpoEz2L2DRDosNCPsXqDcc9yzBKBN2vX2NESoD/3bzS9bmh8oni7 adGnSFsyf+/xwHz/M/E20NhhI2rAklk= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 082E91F441; Mon, 9 Dec 2024 22:13:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733782384; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KCb8IbRo1eRqiNwck2SVw3jDeaAI+uIKJSKUQSk/SbM=; b=y6cBCICnD4Pof/huJL2g05EyPgoyEeV09I4pjcl7sXHC5wA+SfEp1LKA5uu3/JICYNANdc gOGIBfSPsm5kzdi7VEuRmLZZw3jkavcAvQ/eCcpqE0d3ps43rAIEuqoyq+2BGBiYRaTQ+v rJg/gDTxV2h97QJsOOyC0MB0sNtwULQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733782384; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KCb8IbRo1eRqiNwck2SVw3jDeaAI+uIKJSKUQSk/SbM=; b=Vle/n26K8ykOwrTWyNVP2vMIh/tVttSfK4qq2Vjoz3T+OiCc8etEjEY8EUG8VkO60tgRXw WlqIB0YyhGvGiiCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733782384; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KCb8IbRo1eRqiNwck2SVw3jDeaAI+uIKJSKUQSk/SbM=; b=y6cBCICnD4Pof/huJL2g05EyPgoyEeV09I4pjcl7sXHC5wA+SfEp1LKA5uu3/JICYNANdc gOGIBfSPsm5kzdi7VEuRmLZZw3jkavcAvQ/eCcpqE0d3ps43rAIEuqoyq+2BGBiYRaTQ+v rJg/gDTxV2h97QJsOOyC0MB0sNtwULQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733782384; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KCb8IbRo1eRqiNwck2SVw3jDeaAI+uIKJSKUQSk/SbM=; b=Vle/n26K8ykOwrTWyNVP2vMIh/tVttSfK4qq2Vjoz3T+OiCc8etEjEY8EUG8VkO60tgRXw WlqIB0YyhGvGiiCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EA50B138D2; Mon, 9 Dec 2024 22:13:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id DmzQN29rV2f4BgAAD6G6ig (envelope-from ); Mon, 09 Dec 2024 22:13:03 +0000 Message-ID: <439de2f1-ee5c-482e-a6c9-c7e3240be80d@suse.cz> Date: Mon, 9 Dec 2024 23:13:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] mm/page_isolation: fixup isolate_single_pageblock() comment regarding splitting free pages Content-Language: en-US To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , Zi Yan , Yu Zhao References: <20241206095951.98007-1-david@redhat.com> <20241206095951.98007-3-david@redhat.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241206095951.98007-3-david@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EDC89140004 X-Stat-Signature: quxrmz4aumbd7q3k3kwcbnsfetih78cf X-HE-Tag: 1733782369-507363 X-HE-Meta: U2FsdGVkX19jII/uJ3grWbx+n84IknXY2GCdr9OFGz5qOGcH7OCCn8gq2YdPNi7ri6dFQBNlRyAbvA9qwRbaP6cg2lwUAoj7hWiHAj4bjJ69xmVw/z84hIghfXmYXaiidUw7HTYuJAJQQYV5oRWtlmgHYtQ0TQh8tTUqxmLs8QDF2M+1tNOudEbmWDoUnIr8c61LnWnUK0sq+wgD4krjdO5ogigirRZolOrbtTDqmdjTUgFP3zIRQxwY6lUidx4FyFQGR8jVBE/qHYJOANhcc5MvXqdF+HFGbwl1LzveAdPTwS2kec4j9aXTwqRLpKo9xEgXnrk1PeUyEj9NqB4clPpwFOmou9QVVf/cdsVIZzjgSE6VxExrRXkssmNPrariAlZZ06hgaYMMysayZLdmKGmnjbcAqx4uuSpgBYutfKy51j8fDyPCJyAynY4F+AMBhgsi9TJk++QzBuNrJkDmb5fTEPfOIzJ1jb8/f6n5Uyb6JGDGj65SxQg5kWATEm9wxG+f04ZfifAMmuHDNxtg5MahEy40tLajuUnj0dRBJg4KyMhOy7/eHehNXLAYQFhD+MO3XCWoIm5cQ0ISNVk4yS8NJiYF0ET8gOr7YCTnoqf4nj7fd42aqMTEJCdCe4Sbv1KDlGXFMzIOZfPdOy4ui9UYgxy41VlJXxWDUzO6qinnKnKFl/QGT8MLCBTGJ7vfZlS9RuTrnfhuBG9iV14B8F0EY8oMBDfFWM3MPSJ48JEoxj+aZ//V2cOjT20MY0cvAlU5FagBWZteZdCLpw2NMvtlFivqi1lV/dH5qt5M2v4y0+V/Genln7IWTbEduN3Euf9ilxkMQwDiWL4xxQG7ulDUj4d3NW7fW/tl79IlYcDi+AZ/lucKaWumuW/JDLb/SEgRsE6nKanz4Ojb8y37HQV/wDM9pFDWfgXeI+FWIJgv3LXrlIWf4VfpTmDe0uI8Wr/oX113NY6SnYZ+mLt SUO0dnhB cFcbdYAbv20m9qR3gYAwgNAYOp70z26n7164K50sJvWFi9tef4/7nrnAMr9vseo23KwVENqqSt8QUkfcQDSh/1vlHlQlYwtWpGLduq922OUAn5Mm6C+hzwAxa4opbuPlVKwCMKawc3n5fvKRJUdL9baVJmcS+6o/NkphmC7pNy3N3lZdQfFOmOON5w3GqKlOKwmmrrY/NinZ+xHhgjaQX2vPMWxPjmF6i1Z0qtlGGNUA7r3Glxo+rTVil6QMVkRuSi2OAOgb4VTGqYmHyAQQsFL2udo/JwvLL5H9VxGO93Ny9EEKMdW/7ElwmhPVwO353rznzEEnhBxgGaxu24px0LIsXN5+ALzxypdi6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/6/24 10:59, David Hildenbrand wrote: > Let's fixup the comment, documenting how free_one_page_maybe_split() > comes into play. > > Signed-off-by: David Hildenbrand Acked-by: Vlastimil Babka > --- > mm/page_isolation.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > index c608e9d728655..63fddf283e681 100644 > --- a/mm/page_isolation.c > +++ b/mm/page_isolation.c > @@ -298,11 +298,10 @@ __first_valid_page(unsigned long pfn, unsigned long nr_pages) > * pagelbocks. > * [ MAX_PAGE_ORDER ] > * [ pageblock0 | pageblock1 ] > - * When either pageblock is isolated, if it is a free page, the page is not > - * split into separate migratetype lists, which is supposed to; if it is an > - * in-use page and freed later, __free_one_page() does not split the free page > - * either. The function handles this by splitting the free page or migrating > - * the in-use page then splitting the free page. > + * When either pageblock is isolated, if it is an in-use page and freed later, > + * __free_one_page_maybe_split() will split the free page if required. If the > + * page is already free, this function handles this by splitting the free page > + * through move_freepages_block_isolate()->__free_one_page_maybe_split(). > */ > static int isolate_single_pageblock(unsigned long boundary_pfn, int flags, > bool isolate_before, bool skip_isolation, int migratetype)