From: Nick Piggin <nickpiggin@yahoo.com.au>
To: "David S. Miller" <davem@davemloft.net>
Cc: Linux-Kernel@Vger.Kernel.ORG, linux-mm@kvack.org,
paul.mckenney@us.ibm.com, wfg@mail.ustc.edu.cn
Subject: Re: [RFC] lockless radix tree readside
Date: Tue, 06 Dec 2005 16:48:12 +1100 [thread overview]
Message-ID: <4395261C.8000907@yahoo.com.au> (raw)
In-Reply-To: <20051205.191153.19905732.davem@davemloft.net>
David S. Miller wrote:
> From: Nick Piggin <nickpiggin@yahoo.com.au>
> Date: Tue, 06 Dec 2005 12:40:56 +1100
>
>
>>I realise that radix-tree.c isn't a trivial bit of code so I don't
>>expect reviews to be forthcoming, but if anyone had some spare time
>>to glance over it that would be great.
>
>
> I went over this a few times and didn't find any obvious
> problems with the RCU aspect of this.
>
Thanks!
>
>>Is my given detail of the implementation clear? Sufficient? Would
>>diagrams be helpful?
>
>
> If I were to suggest an ascii diagram for a comment, it would be
> one which would show the height invariant this patch takes advantage
> of.
>
I'll see if I can make something reasonably descriptive. And possibly
another diagram to show the node insertion concurrency cases vs lookup.
These things are the main concepts to understand, so I agree diagrams
might be helpful.
Nick
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-12-06 5:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-06 1:40 Nick Piggin
2005-12-06 3:11 ` David S. Miller, Nick Piggin
2005-12-06 5:48 ` Nick Piggin [this message]
2005-12-06 15:53 ` Joe Seigh
2005-12-06 22:36 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4395261C.8000907@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=Linux-Kernel@Vger.Kernel.ORG \
--cc=davem@davemloft.net \
--cc=linux-mm@kvack.org \
--cc=paul.mckenney@us.ibm.com \
--cc=wfg@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox