From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD96CC10F1A for ; Thu, 9 May 2024 21:59:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 285BC6B009D; Thu, 9 May 2024 17:59:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 236A86B009F; Thu, 9 May 2024 17:59:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FDF16B00A0; Thu, 9 May 2024 17:59:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E582F6B009D for ; Thu, 9 May 2024 17:59:51 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 919AA1C1AE0 for ; Thu, 9 May 2024 21:59:51 +0000 (UTC) X-FDA: 82100225382.03.6103EEB Received: from ale.deltatee.com (ale.deltatee.com [204.191.154.188]) by imf27.hostedemail.com (Postfix) with ESMTP id 7387A4000A for ; Thu, 9 May 2024 21:59:49 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=deltatee.com header.s=20200525 header.b="n+/oc90g"; spf=pass (imf27.hostedemail.com: domain of logang@deltatee.com designates 204.191.154.188 as permitted sender) smtp.mailfrom=logang@deltatee.com; dmarc=pass (policy=quarantine) header.from=deltatee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715291989; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6ReveTWWElOwm+nOGbREtwyDH8pYqac9yedB8poPIGw=; b=xsLtvznIaUruHlLnhcev4bf+tetsWm46/xNvhForhwuToT4yByakYRmzX/SaNOUi+O3KV4 YmQ/4yeL5xK5EWAgWrSQptnfAgy26t0JZsOS5dE8kXlQl7BZpmUrJLE5RYUf17AHKPp8Vr u39MGNA8xHDA7Y7Hilw06711N4fL0Gg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715291989; a=rsa-sha256; cv=none; b=RDOrw5w8bKGDg5HrAyM1qnplgjulqgn0w6/2pwDvkSf4K1mxAc40jTipPU2vMQsptXdEsR eNke6l3q6XGKuW1jtxGAzs/n2phUl+F3e0Lr0rZwWI+6bg0Y7rvUKTCTmHAibUMRiYa9Ri GzbsulKuxmtY9rgSyU9VVrtjj+wt5JI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=deltatee.com header.s=20200525 header.b="n+/oc90g"; spf=pass (imf27.hostedemail.com: domain of logang@deltatee.com designates 204.191.154.188 as permitted sender) smtp.mailfrom=logang@deltatee.com; dmarc=pass (policy=quarantine) header.from=deltatee.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:In-Reply-To:From:References:Cc:To: MIME-Version:Date:Message-ID:content-disposition; bh=6ReveTWWElOwm+nOGbREtwyDH8pYqac9yedB8poPIGw=; b=n+/oc90gcMIoirqjRPYU5I+I7c jBk0Nz3akXqr9z99aU970UhzNXSLgCnlcK7LnHN+/lW7cpL+5Hiz3MfmYRc6MY55VS71LgnfXZYMy zit14EOdpEv/3Qh9w/CjkjyL8XVSzIFBkWpEAt42olr05QNVrWNQmcv33eddLZG5BCD8kq+lMeg4P lyRU9T5CFUq8vCTh8O6GSTaYD5Xi8MJJQ7ZGjCWfPece1jKNA+2sfHBqjUG/jAAiK7r82JCXHguRg MzUsWIALL2EHT8tx+bKCpU/qj7O1TP0rOm0u2rcm0I3lwI/U+OnKQbsPUDGRMdW05H1VcUKMgvUkG FPrQ88mw==; Received: from d104-157-31-28.abhsia.telus.net ([104.157.31.28] helo=[192.168.1.250]) by ale.deltatee.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1s5Bnn-00EPCu-8r; Thu, 09 May 2024 15:59:48 -0600 Message-ID: <4393e0d9-28c5-4b85-b603-40e457c9beba@deltatee.com> Date: Thu, 9 May 2024 15:59:35 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Alistair Popple , linux-mm@kvack.org Cc: david@fromorbit.com, dan.j.williams@intel.com, jhubbard@nvidia.com, rcampbell@nvidia.com, willy@infradead.org, jgg@nvidia.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, djwong@kernel.org, hch@lst.de, david@redhat.com, ruansy.fnst@fujitsu.com, nvdimm@lists.linux.dev, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, jglisse@redhat.com References: Content-Language: en-CA From: Logan Gunthorpe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 104.157.31.28 X-SA-Exim-Rcpt-To: apopple@nvidia.com, linux-mm@kvack.org, david@fromorbit.com, dan.j.williams@intel.com, jhubbard@nvidia.com, rcampbell@nvidia.com, willy@infradead.org, jgg@nvidia.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, djwong@kernel.org, hch@lst.de, david@redhat.com, ruansy.fnst@fujitsu.com, nvdimm@lists.linux.dev, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, jglisse@redhat.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [RFC 03/10] pci/p2pdma: Don't initialise page refcount to one X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) X-Rspam-User: X-Stat-Signature: dju445t7dgfb7hqfp3w8cpjqpcar6p77 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 7387A4000A X-HE-Tag: 1715291989-948863 X-HE-Meta: U2FsdGVkX19CK6a908emZt0Hz00qO/CO8pODnqzbzuhnImiYczATAlsLH2B8Wgc8CC3b3Sy6LNikOqJIYWMJGIIeC9+5xu0IBKrGrPH56mMA3puw6LwfUCZI2zN9SvBvGpnB5X/FQZKT4ICwhAbdZIfc9ewI86C3DmMWMrrUxkvp7XEuqraa6EDYun6eGmATNNPFoL6ICJwz/X/6PQkN9aPeLA8jfw1xdQG5u1yP6oHinTcAdqPU/TaOjoKB01EcBqCX2D0ff12BOSQEThQbrKS+utdu2876s0SZ3Y+KklJxaIy9j/YnwTonIIdeTWiT1/T0fMwAP4ko7nmcG47ByF7wktocX/8HOR8b9LSxEHJn+jUliYpZEraH/Kbk5gw2J+55TypignFmQyCgNfvA6c00yS45AEtVywNYeWaOqfP4G4p+2AKpyyqykUtl070CtyBtb9e3m3O9mMyGroGjwe14jzvVr7dbdLQVFGZA7M1lJRkr18pv+iqpuZ4v3+RPRF+GgUpsKvZPG7FjuU18FbSCKZdcM6BplS8EwLLToDp7tuOZAD2nea/ZIbcLzpppwnODs6XKPz2YOUDM8BHq0NPxiybm4CTPUwl6LEHTviV++DI+giecUSctmIwsdL5HeZirMVKB2m1d2dmlA+d6PBX6iXGbJ1zjg2r7yUAri/0SVeglUIrBl0fPUkX7EZGNwOe2QMlkYs44HVF0fmu9f7+quXvew6z4vW2R3tygYcoPUJkGElkMVs/ojGuCqs8+/ieOUPZX0e6WdTx2CxTH7i/WCljY7qckv9Rm3/dvyno4k4YWOb96Da0WAmlO7aG3nI4p4kPBbC/iOgFCpYh5WYnSVtH0u3+YmZTGK6Pr/HPdj+iQcqyEcx3oG8PnApe7CNOfLMdfJhST6tUKaM4pcdqvTkwN6u+Ixr6LzRI93Hs9XqpkwujVJR5VSHHTzxBOH68tPpI0m1wWSOigkV6 Jo8U1ZZv vf0cRVHaw+b0sS8XJtBXZw1MmOxdDVXpGoW7rVeNO0OaOg9w78iDL4ygnD8eeW+3snWR01CeYaUeV/YxpFOmUCCXSDyaqJ4wEkV39DUL6dRYvDNaStWOk4sPyO7uW80w5SMDQkvKxIAYiAW/ye5VezzDqw6pvonNUgXPKrDSKEDfelDEqdxtQOZK2RdB/6LBLwltS9EtCmdB67bmSSQmzQKZEEUL4BhWog44ZkasCnaPcO/xsRyO+VKV4Gw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Alistair, I was working on testing your patch set, however I'm dealing with some hardware issues at the moment so I haven't fully tested everything yet. I managed to find one issue though: On 2024-04-10 18:57, Alistair Popple wrote: > diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c > index fa7370f..ab7ef18 100644 > --- a/drivers/pci/p2pdma.c > +++ b/drivers/pci/p2pdma.c > @@ -128,6 +128,8 @@ static int p2pmem_alloc_mmap(struct file *filp, struct kobject *kobj, > goto out; > } > > + get_page(virt_to_page(kaddr)); > + kaddr may represent more than one page, so this will fail to map anything if the mapping size is greater than 4KB. There is a loop just below this that calls vm_insert_page(). Moving a set_page_count() call just before vm_insert_page() fixes the issue. Thanks! Logan