From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21CB0C54E58 for ; Fri, 15 Mar 2024 11:13:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0DE280121; Fri, 15 Mar 2024 07:13:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A9767800B4; Fri, 15 Mar 2024 07:13:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C39B80121; Fri, 15 Mar 2024 07:13:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 78FA7800B4 for ; Fri, 15 Mar 2024 07:13:24 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1A209140C13 for ; Fri, 15 Mar 2024 11:13:24 +0000 (UTC) X-FDA: 81899012328.22.CEC264C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id A9C1D14001E for ; Fri, 15 Mar 2024 11:13:21 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SchrBO4m; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710501201; a=rsa-sha256; cv=none; b=EqD8qln3UMOb6O0JPYvXKZt60OWlGp8bG0n3NWnPfNsIJ4EStulagAihbmLgMWsZRgsrfr 2Pp3j0Z9qOVjVRqiXV1A1kFZ40Ai0Lyw4EBqHdK51Eck8Mj1YZnc6swJTTvUivLUX5zU7Q oY28bYYmTdyw1ScWeYenlrK/h6HX/bg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SchrBO4m; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710501201; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r4cElLn6uNMmXPxj+P875fJp8PjCHUjjbl/SitvMXfI=; b=vM0f2hrfv6DWpMqJqYZVI3ZCcrghl0lDhZSdgZsrIVo8h50prA+582Aq9t9pQAD43yPNeS +hJwo5CVpr6+DGIBWKnPSh9sWHpijcVKjasEp31xYqooXX0dKiPIW5c74MxsrJuU7sG8E8 +ArmYav4VF1WAGIega5UPECVitEsyvs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710501200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=r4cElLn6uNMmXPxj+P875fJp8PjCHUjjbl/SitvMXfI=; b=SchrBO4mLz97pwrVBriF3GhAxbB6ZaGAaGYGFA9lyysaIwlt1EdBu25E3x4ZJh3zspxMMV HEgwFtOrvMRvD3tT2k9ZF/5bMxe7BWdqMRkKIaq2sPAustDXoHj6UjtPDCWH3O1Bt3lU90 rHYOi3aegdt15VifPznDLCpzO1sVskA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-ayeSXxLDPvSQ7JetsOFlkQ-1; Fri, 15 Mar 2024 07:13:17 -0400 X-MC-Unique: ayeSXxLDPvSQ7JetsOFlkQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4132cf7b23aso10030125e9.1 for ; Fri, 15 Mar 2024 04:13:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710501196; x=1711105996; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=r4cElLn6uNMmXPxj+P875fJp8PjCHUjjbl/SitvMXfI=; b=cpB72NGZ1uvXEBCH1QKQJyADUQhOZOAFAbZeUyrhDrhOJLeneEFK3ezkVhGrGrXbN9 6bgJctBwhkNHCHTuErq8G5NIYO8O1L0cAMvez2Jy4HKimvlHou+3Dstfe2R6AGrUMisC H4sCMcSrbvif69eJDkx9THI/7BiQPZC8vSD2lYjugTjdBTz6uDG/aUtqGuqFTztawzZd qS7lAmlRmer2X9o4AplZvZhhRnyGcgaVkDkVpH8h++lk1+v5+HCFtGX8JPlfMEhLziRf rTWSFwbQSvsPuH7QAyPpONgn+Lo7opCfmDRE4hfRLS7GuZ9WercmY7GFYDSXSXdzxNbL 5GgA== X-Gm-Message-State: AOJu0YyyjOpsXuz4fqxPtOFvfh3foKJSeZRxHmW+bha5aOAEhrBqyaMg 8ZsUkUWFqOqiOsnQJS5CiUBgTDJnd1noC0DfXmhQWoLFi6U6pJj1BF3gSjLDqwARet8TwW4GMdZ a4Sg1EMTxVDHVcIEsNVaGuPhxW8OlhwfyE/dADFxe1ev9oS++ X-Received: by 2002:a05:600c:3ac9:b0:413:27ac:d2fa with SMTP id d9-20020a05600c3ac900b0041327acd2famr1934148wms.6.1710501196265; Fri, 15 Mar 2024 04:13:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEaQWyjM4P/4JwYIguoRLXoHbrQa6ZdqSnlrmJV6H+8tyH+pmgoWrWD+VUpnv7R77+Eie5yYg== X-Received: by 2002:a05:600c:3ac9:b0:413:27ac:d2fa with SMTP id d9-20020a05600c3ac900b0041327acd2famr1934124wms.6.1710501195872; Fri, 15 Mar 2024 04:13:15 -0700 (PDT) Received: from ?IPV6:2003:cb:c719:7700:ef08:112b:278d:7d90? (p200300cbc7197700ef08112b278d7d90.dip0.t-ipconnect.de. [2003:cb:c719:7700:ef08:112b:278d:7d90]) by smtp.gmail.com with ESMTPSA id n41-20020a05600c502900b00413fe69037dsm2850831wmr.44.2024.03.15.04.13.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Mar 2024 04:13:15 -0700 (PDT) Message-ID: <4388c2c5-7346-447a-b76a-de97a1fe1ad2@redhat.com> Date: Fri, 15 Mar 2024 12:13:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 6/6] mm: madvise: Avoid split during MADV_PAGEOUT and MADV_COLD To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Huang Ying , Gao Xiang , Yu Zhao , Yang Shi , Michal Hocko , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Chris Li Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240311150058.1122862-1-ryan.roberts@arm.com> <20240311150058.1122862-7-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A9C1D14001E X-Stat-Signature: 9q7zezw4gdoko7r6o3z1w5zt3u5j4mtn X-HE-Tag: 1710501201-608831 X-HE-Meta: U2FsdGVkX1/vVv1/+n4L4CDjs0iskgQTxQVSIHlEmV7zjws1dnsgCMHAgnJK+EUOfBCDjv8AmkpcwE7B2PVFaHMJfLYt5hc+iw7SAwvB89bF25yDoU+A6NqXoi+Srp9jkcwM+iGV2tI6JyQfCePo9teGSB/v/2xLgtMpALPAl4Z2EX6RlyHGvEDOy5T+HHgWhzlhCgE8QvbETidm6co+hjvcxwnQltgqAlLiU4u3buKSrqdpExM1OJAtImPoVVZl2iL37+2Ta3dt48NJ13CYHEC1I3XsZgkj3e4vgBayA+VVeYnp1sp2oR5vd6i7TWvZhMwH0BkXCN4vvNqSmYFM9nwL6pX2rzOW9OUZkcFPFVhfKz/W/jI6VyC3huiRiStM1EY8m3mgLtzfepr+SGg9N34Y7ucyQSezJhlWNKCi3qNIVExg78QgdF/bnfSx/w9PlYfyz9CDxpeJV7Mlq93cnBV24CTJ3DDmZ0e5EaamZ/tgt2XK9XWb8XUaczcSnJmGO0inVYAV9PlAdkL6KAUZ+CGtAzjqW4N8B2WR3/dbXv9NhMP00f0ErvepI+3L4MeTgrh+0E3OYDTVoEFWe5M4RdFm7Fyh6MNv33VEGFMcuYV23RatCWsI203sRq9dj1yICRjfjwRhl31I6difudn3M3Q5e4fxD4WKWzIXOULEAT7mLLaciZZY+54vPV/ixwMWyG0jARsnSuDlimANs5bY6Yt7JhFS3C9lVcKV/fXBzOMncsUjczKu5jgMXu51SXD1vZnd3T4MyXcDak5O2dQQlKrA7Ip7ZIbveDj5xRNGzLQ5jCfuMo0B7STSYavTwRGfS0/B9mZPHC6o5qeOlkihHODHkfwkmO6ZCoj8QF9A4O+eGk9oNsE3/yxh3V5TT9YWY+A32y7GOLF78MdDffCPaimwgt1WD8LqST4/38/XsZXN2RGPCd/t/lHiHH9/ee1XhyKv4Dn3s8rlsgA45bw wOpFcrp+ 1Vaj5xPn/UXkAAiiRssqFR5ug7OlgUomBHGP/4uBhwACjQFr5Wjbr72NXUzsJB3RXrBW3DE99AAMvYyz+0seHrbe6c9w882eYMFYE+ukmjBO60i/vUVSiRYC2BLbt2dFHMU1kzUr2uUYhFvxenVv3og5TKSWJ/1SiaKobdV8Yk7Qc7hEhA3ryQO3ryWIyV3/R8XoJC3eZ3TKAYncHovZyhWwk7cGLlAWHc3pPQODN3E+dKCfhgqeZBN6gzxhna7w4wqe7DNn0ExYNJ/eAXBsTJax+Kaxaxf79qiBw3SHMns4WATknkJAQYGek5UtwSa/kiXCrw4UaODb6khl7wzGyJdJ+uZPFSxj6c8BsOv6haCpzsL5BhoY0dOqCx0zmV13+Y79jM+ByznClR1uwHR/E2NNqX5lUwwYJdnT0qUngppNlOKmf8xhaVhKT9ygQaRg8dwTHSHZYRpu/VVMkOMG/rmAW/464gRf2hhrG5Wb80W5oz0SWccdyxdjecQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.03.24 11:55, Ryan Roberts wrote: > On 15/03/2024 10:35, David Hildenbrand wrote: >>> -        if (!pageout && pte_young(ptent)) { >>> -            ptent = ptep_get_and_clear_full(mm, addr, pte, >>> -                            tlb->fullmm); >>> -            ptent = pte_mkold(ptent); >>> -            set_pte_at(mm, addr, pte, ptent); >>> -            tlb_remove_tlb_entry(tlb, pte, addr); >>> +        if (!pageout) { >>> +            for (; nr != 0; nr--, pte++, addr += PAGE_SIZE) { >>> +                if (ptep_test_and_clear_young(vma, addr, pte)) >>> +                    tlb_remove_tlb_entry(tlb, pte, addr); >>> +            } >>>           } >> >> >> The following might turn out a bit nicer: Make folio_pte_batch() collect >> "any_young", then doing something like we do with "any_writable" in the fork() >> case: >> >> ... >>     nr = folio_pte_batch(folio, addr, pte, ptent, max_nr, >>                  fpb_flags, NULL, any_young); >>     if (any_young) >>         pte_mkyoung(ptent) >> ... >> >> if (!pageout && pte_young(ptent)) { >>     mkold_full_ptes(mm, addr, pte, nr, tlb->fullmm); >>     tlb_remove_tlb_entries(tlb, pte, nr, addr); >> } >> > > I thought about that but decided that it would be better to only TLBI the actual > entries that were young. Although looking at tlb_remove_tlb_entry() I see that > it just maintains a range between the lowest and highest address, so this won't > actually make any difference. Yes, tlb_remove_tlb_entries() looks scarier than it actually is :) -- Cheers, David / dhildenb