From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 903AFC2D0BF for ; Tue, 17 Dec 2019 15:04:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5498E24680 for ; Tue, 17 Dec 2019 15:04:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="IYatTteW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5498E24680 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E1ECF8E007E; Tue, 17 Dec 2019 10:04:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DCFDD8E0079; Tue, 17 Dec 2019 10:04:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE6918E007E; Tue, 17 Dec 2019 10:04:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id B9C028E0079 for ; Tue, 17 Dec 2019 10:04:39 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 6BD471803DDCF for ; Tue, 17 Dec 2019 15:04:39 +0000 (UTC) X-FDA: 76274955078.17.touch92_b746dec18140 X-HE-Tag: touch92_b746dec18140 X-Filterd-Recvd-Size: 3652 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Dec 2019 15:04:38 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id t129so2263152qke.10 for ; Tue, 17 Dec 2019 07:04:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=KWvMnp6WnFUpycSP8rv3DWkxz/r0qpxVC39yfCQNPZc=; b=IYatTteW5y6ti8LEqO+/zdTUGmCv1KDv68bKa61tkxNA/krQNPJ1DcjdPIRpuOQLC3 CQOpF0MVR3hP3jJVnCgTINdUmiwkvge6ogGB8p+KpBWDIf6ejcEzpsE2U1eNGaPv9sIQ GF2AUiR4gIIR/kxu9qTp2EaJ2HYUJgsv9IZXk/PxhrE7pOPhIrGf/0JpEBXcEl3tBWk3 BErm+rW/yMR4fReQaGo/GSsnxoxkPELI5fdYm2psftBMpuKG1M8MjB1sbfNP/s4N4Wkl J8uf4/kz+JjLvRoPmXI0VkUKEv9SwZscKFi+6nhMH/+7bEsK52Pwc6VQW+kOmZVgKMG0 pEKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=KWvMnp6WnFUpycSP8rv3DWkxz/r0qpxVC39yfCQNPZc=; b=NE78GWnJtS9TReVExQYeMQGBoH6buZPtEppH3c6IxaOXTJFp6lUXRoeRzZRWmn9iJ2 FI+Vr+zbGKeM/Ht6IXYu/65/M/M5Kgnniyfph+FhTZPsDXQOH8pmP0hnHlgHO+yo5CfY ixS8NGMnmSbHmLJhCPS0p6bYQ2HXdxV3+231eaXAe+Ggt4buDLy7hkE9GgF0xEskyYmt odVvWw4sQSyV2pr2jsHMSE1MsgJiVh6w0+T2ykV0pJq8l6Ve4YeHrMBvJWJj4ASOdDN8 4rdvPdj8U9Bsc54VNMkQ9e7B+9/VBQdrZ0lmnkvrxoD50UPlU+mEG6Q0LqU4vpASORPq ntvA== X-Gm-Message-State: APjAAAXbkltyeilOSRu7EWHVPC+qRiWy+kvGDPEGZDmtPLxEezzsxPMz ZTWQOHVatjBO4E61EEaYBSUyQIMMkM0= X-Google-Smtp-Source: APXvYqwB3tefmBijBbhtpmgp6Z8XZFIqVXA5SBPXcJUiqBJ+dz6d2gWsnzuhtCFCOn9Z/7d4kKYFSg== X-Received: by 2002:a37:96c2:: with SMTP id y185mr5834810qkd.202.1576595077972; Tue, 17 Dec 2019 07:04:37 -0800 (PST) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id 13sm7050492qke.85.2019.12.17.07.04.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Dec 2019 07:04:37 -0800 (PST) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] mm: memcontrol.c: move mem_cgroup_id_get_many under CONFIG_MMU Date: Tue, 17 Dec 2019 10:04:36 -0500 Message-Id: <43881F9C-90D0-4DE0-BA1E-B74ACF8567BD@lca.pw> References: <20191217144652.GA7272@dhcp22.suse.cz> Cc: Chris Down , Kuninori Morimoto , Johannes Weiner , Vladimir Davydov , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: <20191217144652.GA7272@dhcp22.suse.cz> To: Michal Hocko X-Mailer: iPhone Mail (17C54) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Dec 17, 2019, at 9:46 AM, Michal Hocko wrote: >=20 > yes, I would just ignore this warning. Btw. it seems that this is > enabled by default for -Wall. Is this useful for kernel builds at > all? Does it realistically help discovering real issues? If not then > can we simply blacklist it? -Wunused-function is useful in-general as it caught many dead code that some= commits left unintentionally with real-world configs.=