From: "Iram Shahzad" <iram.shahzad@jp.fujitsu.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: linux-mm@kvack.org
Subject: Re: compaction: trying to understand the code
Date: Wed, 18 Aug 2010 17:19:21 +0900 [thread overview]
Message-ID: <4385155269B445AEAF27DC8639A953D7@rainbow> (raw)
In-Reply-To: <20100817111018.GQ19797@csn.ul.ie>
>> In other words, what is it that is supposed to increase the "inactive"
>> or decrease the "isolated" so that isolated > inactive becomes false?
>>
>
> See places that update the NR_ISOLATED_ANON and NR_ISOLATED_FILE
> counters.
Many thanks for the advice.
So far as I understand, to come out of the loop, somehow NR_ISOLATED_*
has to be decremented. And the code that decrements it is called here:
mm/migrate.c migrate_pages() -> unmap_and_move()
In compaction.c, migrate_pages() is called only after returning from
isolate_migratepages().
So if it is looping inside isolate_migratepages() function, migrate_pages()
will not be called and hence there is no chance for NR_ISOLATED_*
to be decremented. Am I wrong?
Best regards
Iram
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-08-18 8:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 11:08 Iram Shahzad
2010-08-17 11:10 ` Mel Gorman
2010-08-18 8:19 ` Iram Shahzad [this message]
2010-08-18 15:41 ` Wu Fengguang
2010-08-19 7:09 ` Iram Shahzad
2010-08-19 7:45 ` Wu Fengguang
2010-08-19 7:46 ` Mel Gorman
2010-08-19 8:08 ` Wu Fengguang
2010-08-19 8:15 ` Mel Gorman
2010-08-19 8:29 ` Wu Fengguang
2010-08-20 5:45 ` Iram Shahzad
2010-08-20 5:50 ` Wu Fengguang
2010-08-20 6:13 ` Iram Shahzad
2010-08-19 16:00 ` Minchan Kim
2010-08-20 5:31 ` Iram Shahzad
2010-08-20 5:34 ` Wu Fengguang
2010-08-20 9:35 ` Mel Gorman
2010-08-20 10:22 ` Minchan Kim
2010-08-22 15:31 ` Minchan Kim
2010-08-22 23:23 ` Wu Fengguang
2010-08-23 1:58 ` Minchan Kim
2010-08-23 3:03 ` Iram Shahzad
2010-08-23 9:10 ` Minchan Kim
2010-08-26 8:51 ` Mel Gorman
2010-08-23 7:18 ` Mel Gorman
2010-08-23 17:14 ` Minchan Kim
2010-08-24 0:27 ` Wu Fengguang
2010-08-24 5:07 ` Iram Shahzad
2010-08-24 6:52 ` Minchan Kim
2010-08-26 8:05 ` Iram Shahzad
2010-08-23 7:16 ` Mel Gorman
2010-08-23 9:07 ` Minchan Kim
2010-08-20 10:23 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4385155269B445AEAF27DC8639A953D7@rainbow \
--to=iram.shahzad@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox