From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CA73C02180 for ; Thu, 16 Jan 2025 00:38:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F2A46B0089; Wed, 15 Jan 2025 19:38:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A3F56B008A; Wed, 15 Jan 2025 19:38:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAC9A280001; Wed, 15 Jan 2025 19:37:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CCFA96B0089 for ; Wed, 15 Jan 2025 19:37:59 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 752E71A04A8 for ; Thu, 16 Jan 2025 00:37:59 +0000 (UTC) X-FDA: 83011452678.15.7242F92 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf03.hostedemail.com (Postfix) with ESMTP id 8DC6F20007 for ; Thu, 16 Jan 2025 00:37:57 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=QR+t8nHh; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.177 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736987877; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pLSIrWrutyEhAsKwVUKkmriRgTwNuKuxzRUa1+a45U0=; b=pPQoxn69EgDJSkNfYuyx0H+iWzeyKdsO5GQUhl8OBtFJQpITyX2dqQqYsaFNOlWDfkWf+/ pOTm9cFbqPWBAcrKJSDIckdeYV7riEGP0l5FBUvmDYmaTAU1E5Hcqn15BJvldAnUwRtaMY kk11X3RU3LHE7zzycr7HVBO1YCVoQ2U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736987877; a=rsa-sha256; cv=none; b=wEf1ykYEjCUjp4TrNicy56n0x7juOPNeRqr8DPQnzTNRs/ao3BxkSQdlMxfSAlWK4FfwkU yqEeLsDUNLOP3Upzy4dL4+Vo53tn4jN66Y3Ah3TUjsrJquBzk3BW35X4jq7tQ1bzsHnxLL 2QSsXf0yrDZrLI1HbdPnVQRKibLHLB0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=QR+t8nHh; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.177 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-21670dce0a7so7041025ad.1 for ; Wed, 15 Jan 2025 16:37:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1736987876; x=1737592676; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pLSIrWrutyEhAsKwVUKkmriRgTwNuKuxzRUa1+a45U0=; b=QR+t8nHhcAgC/qx5WabVqFmGb7+4CKeUB0xsvSULEc5+BheCXiavno7PhcgMKzdtAa CgoMgXiSzvjBDjCsulC/96gYyeECNcJd3W/47yaqg1d5PjV+LUSO2+sVx8Y6UXFC5gx8 4gqIgkebCGeHC2jRZ7a0Q8TNJs6By8hryA82Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736987876; x=1737592676; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pLSIrWrutyEhAsKwVUKkmriRgTwNuKuxzRUa1+a45U0=; b=Mr/H+x0XC8eEK+05uVqXPaRak3xroODed73WNUESfdo/9x/FbGoP44Fe3/5czDI4h5 kiByQpJ5obfsSikjYaYvZ9c9augxj+ubEAjRHB5CUWq9Os0Jhdqpyf1xtTdXOBvc+nKW QPyuTx4fclvz5ucfvbEY1dR3XN/eNqK/4UQ9KCf9+jyna7hC4sRXnZjKyXsfyCsoUQUI nk+3tF5/9iClsRyRpt1Xp3UWtQ+SHNfTYOPJYA+FoO1zdS0FiTR1n7v50GPWnjCE3xS/ qxhubhHXNgB+SLUA6uZV/k9/69x9NiUV1dMDXE2KZl6mUXy4CxE4ffgoLNSjSB8PGahJ w+Sg== X-Forwarded-Encrypted: i=1; AJvYcCV9LbFJlVedaDnmQk7N+9eNEPqaDqJEYE28kS6QcpUoOgoHN4TL2s6v/jofshe/js3QVaz67KX15g==@kvack.org X-Gm-Message-State: AOJu0Ywi61OG2tbKBeA0r9GqVDkD3KfEP55CduWEHwn6EnwmbPTAgwDO EzW5RLTwUUZHJsxhQCksy6dQecvFwgGH+89ScbOVz60SfAe0zuFCI2SeHjelzA== X-Gm-Gg: ASbGncu4WmN0oxDgru05k3o5RZgGYWoTp3UCckaGewQ/P40HjvcHE3W40DaXK8btQ/L Y5zDkVpQ9/pNZe1i40iJb3PNC4YAqiNMpkngvKlXVM2qzZPaMAhxXF0TbsZ2j6DDqN3HHa1laO5 VA/R1LCVcxkr03U7KkinKsuhuAiVsxE6eHpGS07cezeYAFCT79Y/7OI8l7qnKY30ZSADaSu/iUj giQNEBi3VuacW3lE0bfsJ2Srjsvcd5Xu/Gd6gBB1ZYIanGiVG0rke9A4N32 X-Google-Smtp-Source: AGHT+IEDPEPAhRQpfXxS/UwJ5YrFGZtWF5MJQRpOk1g6Zw2lMtWvY3ZYXHhkxL1luaGdfYJX2wIbqQ== X-Received: by 2002:a17:903:41c3:b0:215:4f3b:cb20 with SMTP id d9443c01a7336-21a83f767d7mr435851295ad.23.1736987876318; Wed, 15 Jan 2025 16:37:56 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:8be4:86b8:bd3d:aa3c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f21a8afsm87773485ad.142.2025.01.15.16.37.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 16:37:55 -0800 (PST) Date: Thu, 16 Jan 2025 09:37:50 +0900 From: Sergey Senozhatsky To: Andrew Morton Cc: Sergey Senozhatsky , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] zram: remove zcomp_stream_put() from write_incompressible_page() Message-ID: <437m2czavj4zy2dq5f7bvlivqfhdkpet4woor3orr3npl7bdlz@kwn3usnqbzjy> References: <20250115072003.380567-1-senozhatsky@chromium.org> <20250115152837.b9f721bccfd07ce903fc4539@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250115152837.b9f721bccfd07ce903fc4539@linux-foundation.org> X-Stat-Signature: e89faoi9c9sa4ma6ee43q5m3gxmwdreo X-Rspamd-Queue-Id: 8DC6F20007 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1736987877-341943 X-HE-Meta: U2FsdGVkX1+/RsNMubGe6jqnX1bMGPIlmHoRhQukliRGKhGNQrIj/jHuVyV8A1uGOzOjMAzLcJYDkKd7ltE7wLbIlGd1YeHhZDkZx9uxWqrNCa7fY0Eu4xL0gvoxZpNpbsgRpx0oVC8HoC3YRyks9+Vq8ePV9sFNwz9WoGWCPFC8c6lG3i6B1NGsr2JxkLM3bulKVM8sWdyW9oP11hN5qbxu5EIE9Qdmi323gPCxGnv92vmt0SEv9ltsuMKd4TCJLaIGv/tpVSjanaZs0lAqddG52BY5ape/7I7OJvYpGzhjFcEbvoqfBuQx6tdrXgHI7Eg1iLLCPt4XNG+S8au5EwIH8N+/LKs799sS222U7MY7Lcs75nRFVDrTuLC73B5YVfaNrOp8kZwMeNZhj8YLQN/iRSqoZbBYUYt/W+jmLb55q8YQJt3YqQbB++FzGGLzT242/vdx7GczAnU6Cj802Vs4T6kOi6VsZKFh9vmV4ZFjBJULK7uORbfmSYrGAhvivu2XmyLxhS5fmPLllI4Gbu6erw5WSpq/n+LOAcYVURCWWvroIDQqmbQ+GZgOCycqtO/DyBicmCLwR6wEGDeQNEm8dICCjldw4bie+nQlL7Ol9jyRDrHgIaHE3291/Xtvlf9RSg0mu8E9k1b981Txs1KeA+U5k7uIDbI+qyfLdch62nB3Rf4dqOGpN2f8xPC/v//onzla5B/rAKERuTPboxGKglasmhSDwY8YbXmMcGBVAj2zLtOfCUWiNQKuLfwAfeMTLhrcSOuXdCxpd+9TLcL/QR5E8wkeihvX2hcNvt+/jMV3KWFIaxnLIjgXP6xoNU/aWiaQdgzWBO6hN1N44NdK18PvMqHKY0/ouTfXy0qFBLIMAXfSyfm9qk/mGTazBc1gE0BHkAObMuBwWgRToKcQmIRDUXTlhnE87WtzVz1/iE9u1SyFGd62LA1flcAyVrtZIU5OqlBbMAlNIvi RBzaRp2o HtLM9X/ECu5Cxas+X+jzyo8U3fJBnWvxjKjFEZcj8zheC7faxEbGbOt9H521homP4OixTeEJa9y/aTxNM2OshmaERKSkmdDLcfgB8831y0s0qut80+Z7obifW+WN8MT/yWH1oKkhwnAlhfl4XuUuxL6foGlGbHhN3WgissTfNtld6xmHcfU23cMsr/AM1brWo7cbsvYD9E3YL+qxKkEOcbEnGczEkzSoqNZFGjjP2eDs2qjW/2qAfeb9OL3NRi/aTgzwpMatTe7TfNgIgKzYkXlGM6ApAgt3BiJSiv5L/H7zGRfx+/GXzmNSIBlB+0LNEB2RNRQrQD6HAaPaeH1LljEvkN8PEVruHu+TvSyPHDyvj2LFZoOv0z8DrtwbgGQXtolSJ6Npt2vOZE4ELN5XrbjlDmQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001470, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/01/15 15:28), Andrew Morton wrote: > > We cannot and should not put per-CPU compression stream in > > write_incompressible_page() because that function never gets any > > per-CPU streams in the first place. It's zram_write_page() that > > puts the stream before it calls write_incompressible_page(). > > > > ... > > > > +++ b/drivers/block/zram/zram_drv.c > > @@ -1683,7 +1683,6 @@ static int write_incompressible_page(struct zram *zram, struct page *page, > > return PTR_ERR((void *)handle); > > > > if (!zram_can_store_page(zram)) { > > - zcomp_stream_put(zram->comps[ZRAM_PRIMARY_COMP]); > > zs_free(zram->mem_pool, handle); > > return -ENOMEM; > > } > > I added > > Fixes: 485d11509d6d ("zram: factor out ZRAM_HUGE write") Thanks. > That way, anyone who backports 485d11509d6d into their earlier kernel > will have a better chance of noticing that they need this fixup. Agreed.