Create a helper function, slab_destruct(), called from slab_destroy(). This makes slab_destroy() smaller and more readable, and moves ifdefs outside the function body. Signed-off-by: Matthew Dobson Index: linux-2.6.14+critical_pool/mm/slab.c =================================================================== --- linux-2.6.14+critical_pool.orig/mm/slab.c 2005-11-14 10:52:22.427207392 -0800 +++ linux-2.6.14+critical_pool/mm/slab.c 2005-11-14 10:52:27.514434016 -0800 @@ -1388,16 +1388,13 @@ static void check_poison_obj(kmem_cache_ } #endif -/* - * Destroy all the objs in a slab, and release the mem back to the system. - * Before calling the slab must have been unlinked from the cache. - * The cache-lock is not held/needed. +#if DEBUG +/** + * slab_destruct - call the registered destructor for each object in + * a slab that is to be destroyed. */ -static void slab_destroy(kmem_cache_t *cachep, struct slab *slabp) +static void slab_destruct(kmem_cache_t *cachep, struct slab *slabp) { - void *addr = slabp->s_mem - slabp->colouroff; - -#if DEBUG int i; for (i = 0; i < cachep->num; i++) { void *objp = slabp->s_mem + cachep->objsize * i; @@ -1425,7 +1422,10 @@ static void slab_destroy(kmem_cache_t *c if (cachep->dtor && !(cachep->flags & SLAB_POISON)) (cachep->dtor)(objp + obj_dbghead(cachep), cachep, 0); } +} #else +static void slab_destruct(kmem_cache_t *cachep, struct slab *slabp) +{ if (cachep->dtor) { int i; for (i = 0; i < cachep->num; i++) { @@ -1433,8 +1433,19 @@ static void slab_destroy(kmem_cache_t *c (cachep->dtor)(objp, cachep, 0); } } +} #endif +/** + * Destroy all the objs in a slab, and release the mem back to the system. + * Before calling the slab must have been unlinked from the cache. + * The cache-lock is not held/needed. + */ +static void slab_destroy(kmem_cache_t *cachep, struct slab *slabp) +{ + void *addr = slabp->s_mem - slabp->colouroff; + + slab_destruct(cachep, slabp); if (unlikely(cachep->flags & SLAB_DESTROY_BY_RCU)) { struct slab_rcu *slab_rcu;