* DMA32 zone unusable
@ 2005-11-16 15:22 Mika Penttilä
2005-11-16 15:53 ` Andi Kleen
0 siblings, 1 reply; 2+ messages in thread
From: Mika Penttilä @ 2005-11-16 15:22 UTC (permalink / raw)
To: linux-kernel, linux-mm, Andi Kleen
The new DMA32 zone (which at least x86-64 has) is quite "interesting" :
#define __GFP_DMA32 ((__force gfp_t)0x04) <-----!!!!!
#define GFP_ZONEMASK 0x03 <------!!!!!
#define gfp_zone(mask) ((__force int)((mask) & (__force gfp_t)GFP_ZONEMASK))
static inline struct page *alloc_pages_node(int nid, gfp_t gfp_mask,
unsigned int order)
{
if (unlikely(order >= MAX_ORDER))
return NULL;
return __alloc_pages(gfp_mask, order,
NODE_DATA(nid)->node_zonelists + gfp_zone(gfp_mask));
}
So with GFP_DMA32 you never get those pages (but DMA instead).
--Mika
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: DMA32 zone unusable
2005-11-16 15:22 DMA32 zone unusable Mika Penttilä
@ 2005-11-16 15:53 ` Andi Kleen
0 siblings, 0 replies; 2+ messages in thread
From: Andi Kleen @ 2005-11-16 15:53 UTC (permalink / raw)
To: Mika Penttilä; +Cc: linux-kernel, linux-mm
On Wednesday 16 November 2005 16:22, Mika Penttila wrote:
> The new DMA32 zone (which at least x86-64 has) is quite "interesting" :
>
> #define __GFP_DMA32 ((__force gfp_t)0x04) <-----!!!!!
>
> #define GFP_ZONEMASK 0x03 <------!!!!!
>
> #define gfp_zone(mask) ((__force int)((mask) & (__force gfp_t)GFP_ZONEMASK))
Yes that was a last minute change that was wrong. I will submit
an update. Thanks for reviewing.
-Andi
> static inline struct page *alloc_pages_node(int nid, gfp_t gfp_mask,
> unsigned int order)
> {
> if (unlikely(order >= MAX_ORDER))
> return NULL;
>
> return __alloc_pages(gfp_mask, order,
> NODE_DATA(nid)->node_zonelists + gfp_zone(gfp_mask));
> }
>
>
> So with GFP_DMA32 you never get those pages (but DMA instead).
>
> --Mika
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-11-16 15:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-11-16 15:22 DMA32 zone unusable Mika Penttilä
2005-11-16 15:53 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox