From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <43589CF0.5050609@jp.fujitsu.com> Date: Fri, 21 Oct 2005 16:46:56 +0900 From: KAMEZAWA Hiroyuki MIME-Version: 1.0 Subject: Re: [PATCH 4/4] Swap migration V3: sys_migrate_pages interface References: <20051020225935.19761.57434.sendpatchset@schroedinger.engr.sgi.com> <20051020225955.19761.53060.sendpatchset@schroedinger.engr.sgi.com> <4358588D.1080307@jp.fujitsu.com> <435896CA.1000101@jp.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Simon Derr Cc: Christoph Lameter , Andrew Morton , Mike Kravetz , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Magnus Damm , Marcelo Tosatti , Paul Jackson List-ID: Simon Derr wrote: >>>Christoph Lameter wrote: >>>>>>+ /* Is the user allowed to access the target nodes? */ >>>>>>+ if (!nodes_subset(new, cpuset_mems_allowed(task))) >>>>>>+ return -EPERM; >>>>>>+ >>> >>>>How about this ? >>>>+cpuset_update_task_mems_allowed(task, new); (this isn't implemented >>>>now >> >>*new* is already guaranteed to be the subset of current mem_allowed. >>Is this violate the permission ? > > > Oh, I misunderstood your mail. > I thought you wanted to automatically add extra nodes to the cpuset, > but you actually want to do just the opposite, i.e restrict the nodemask > for this task to the one passed to sys_migrate_pages(). Is that right ? > yes. Anyway, we should modify task's mem_allowed before the first page fault. -- Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org