From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28A5EC7EE25 for ; Wed, 7 Jun 2023 15:56:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC1E96B0074; Wed, 7 Jun 2023 11:56:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B732C8E0001; Wed, 7 Jun 2023 11:56:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A39B96B0078; Wed, 7 Jun 2023 11:56:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9577F6B0074 for ; Wed, 7 Jun 2023 11:56:27 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 61D281A031B for ; Wed, 7 Jun 2023 15:56:27 +0000 (UTC) X-FDA: 80876404014.18.995A467 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 306C34001C for ; Wed, 7 Jun 2023 15:56:24 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Kv3zODtR; spf=pass (imf12.hostedemail.com: domain of mpenttil@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mpenttil@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686153384; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0iRncZtFQPeT5Zv7xlQjJ3xhPc1E7UX/btxzeRK2d/U=; b=U4gGd2Dh7/YVCPBOlxzfyuxGvUkrWJZAk8/+NahS2K9lLhrFU9MSY6OEx/ZWPRqVGtP1fD zkJY4TLVeT7IBJmzU5tPf0+O63r0ZvDKEuDZUQ0Tj/6jE+4lAzda2wWTbTkyrAb+GYVDQu 6SiWij7Qlnf5gquAFpB2sOufKhXsZ6U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686153384; a=rsa-sha256; cv=none; b=vj5KbTy0voaGsSxpyqn5vktAKbER/6VjTtw6rse3cWiuvPsHuoSdyVypHjGZ2gAjrwU9uX bQuSib0Y+AkNgNHU8wHJ15jOYFLObE8sLToAhUge2KeMBdGUVPobOrX89IUKUinjywpII+ a6VwUqDLi++g6N0QLNq7rKm3Z8KZfgM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Kv3zODtR; spf=pass (imf12.hostedemail.com: domain of mpenttil@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mpenttil@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686153383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0iRncZtFQPeT5Zv7xlQjJ3xhPc1E7UX/btxzeRK2d/U=; b=Kv3zODtRebE7xaj9U5WR0Od4zYTkFrs/VFBw6BAoNwHKAEZJLD5kbAqoCDtltbMoDDh71Z Wh8Wj9TmEpNg9/xxriu/oaIhTTwkCxG2j9AXuSMtdwXiHpHHKLr/vQmkkXIEpEbmYS6zxr run2UgFgxLNF0QpCa5HGQk3dx0BQzKs= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-19-EiHEOuvjO4m_0-UMqoDwcg-1; Wed, 07 Jun 2023 11:56:22 -0400 X-MC-Unique: EiHEOuvjO4m_0-UMqoDwcg-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2b1c60977e3so25950871fa.0 for ; Wed, 07 Jun 2023 08:56:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686153381; x=1688745381; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0iRncZtFQPeT5Zv7xlQjJ3xhPc1E7UX/btxzeRK2d/U=; b=HSpwrhtN9PVdbaeJrN3JP8u8Vff28+saa8+qNaltMo7y1ncmfTViVgnW28aKQx/Nzd u/xyKSYudJG0XYGBM98kOcYSgOymJFEuYq0xw/VilVss6ox1yeecie+y9H/rjMowvNQz /IR87jNLvoArRD975QIDCf9Mlg5vYgTQJJafFz3qwrmw0fJUL0S/M0VAYij6zcxGZdgf eiWq7FJWxyAzRBAPq155rKrtTCvcyUs5Kq9Y9UPthrZrGj9sDhYNDfUy5YFg9PuxRQIl heF23JhJCtmwOC0dm8deWQC530I741dSZY/84Jr54JozFOGH6nhSIs0lpeCvxVdQ9rkK Jqag== X-Gm-Message-State: AC+VfDyZwVsiR1sfGhtIgMXhAhbRt1AXOYiyWghmjg+i4jJ41BKWyC5/ Yd9wX6zRoHc4+xezuAlizwoko+9oYXtxcybg7vS963GST4LT8HlAXlt94lYkNmTK9NEoJXFxiWZ CF5vcsiOVzg== X-Received: by 2002:a2e:88c9:0:b0:2b2:b55:bd7e with SMTP id a9-20020a2e88c9000000b002b20b55bd7emr292162ljk.49.1686153380854; Wed, 07 Jun 2023 08:56:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7WgO2URV3ehemb/IvEATLG6LBwf3kZ2WjPiaWjIzpHWdRWQGzYz1P+l9nmx08Zyhxdl9ubmg== X-Received: by 2002:a2e:88c9:0:b0:2b2:b55:bd7e with SMTP id a9-20020a2e88c9000000b002b20b55bd7emr292150ljk.49.1686153380496; Wed, 07 Jun 2023 08:56:20 -0700 (PDT) Received: from [192.168.1.121] (62-78-130-207.bb.dnainternet.fi. [62.78.130.207]) by smtp.gmail.com with ESMTPSA id x13-20020a2e880d000000b002ac7b0fc473sm2293149ljh.38.2023.06.07.08.56.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 08:56:19 -0700 (PDT) Message-ID: <43460b82-06c0-dfca-1cfd-d99208e2c647@redhat.com> Date: Wed, 7 Jun 2023 18:56:18 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3] mm/migrate_device: Try to handle swapcache pages To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alistair Popple , John Hubbard , Ralph Campbell , "Huang, Ying" References: <20230606050149.25699-1-mpenttil@redhat.com> From: =?UTF-8?Q?Mika_Penttil=c3=a4?= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: 6pen5ckdhwm9npfskcxnoottxw9xyny3 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 306C34001C X-Rspam-User: X-HE-Tag: 1686153383-586592 X-HE-Meta: U2FsdGVkX1+VTLnl7Uu8p96VcCECKczKAJXgb8oVQX0QJGCsHcGbSJtmBcCrzaNX25x+21GCac9Jb4A+7xJp4y6b/WvywdIUzk+AvVWdX4ZiYd/PKGohankOqdIdBeu8kVMPeeHhXqwvA3YFTcb4YHa9J6u6EXwOZUWcrjmLM2lg489aLL8BwFVmJMmy0LAmLhdvQIHkyJovDYvePHoQl3b8V0aTgMpqNKwIDCgy8yH8OUbr5LDxJMZ4LjwWBINV/zzDrTH6D63UHZ2BSw8XOA9i2N1QrlZEf2wI8H2ppDwKnmrmZJ/vnytf77LuNW8ysAXmaIQwYWcENzAz4weC9u5/04C+L4X7LrvQfvwxr9gKZiLBqip37KZEawtwS1rEAeEDrdnx5TPJ/3nznkzQQQ6omo61TkJwOk6hEekurGQ9zi3Vcj6eFaW6TJHeAMXWnJqmhqxTTboui14wAxXKLU2NK3bZDO16vzZkrcSMoEpNH4NYYcX3j2hag3f25P4wQnG87mrLUb010wagY8pxOErgDwV/HEj246QSIVYlEb9f3VgSbgZwVEtebp9trphyitBXhBxqTKI3Y32PSEwTiiZJc3k8bWbowHPK0zyYs/2b4aEu9XqKeMbZjmcAryAyed+kke44rsHyfXULrCLzl35JgpIMsEWl0MjeZSZiRcFj/QUdmHQQ82PefP56DwtkVTGuO8cwmG4yveXAiMwP57a06NYgjav8998jGEJ8j/wc3owqVjc9UKq7Y0dbyu+KvXq5AwPNFZYtDH1BaxhRU6NxTmeRsvUTEeC8nb9vw0Lkzos+Qp6uIXZNF+bNws5i/lLZklT45vL3iWT8+bGQoWijiYLwMBxOxQl89mbp43pnGIg1sBmw82MLgr5tvmDQqTq8t8YB8S2uO76qGhB6Wy4LTJWo+JDQvxJs+VwtdTsm6AqAoLBmJE26yLksthx2iOLuQaUrp5CZs8dX+Vj GoTMubSg okeaFWdro+j3giuFa51KaBw1MdKIqWby8jsfVQsks4vEZ+OfqZPl1k7AGeKrRkStl7OGU/sZtqI/pbrqO2SVLJom0sifWSXue9v8qMQowGOBWrzUqzKtkTFR8YoJbx/DacWaeMCcm+pbZ50N63Nrcfaf2o3PWgpHg3K8nS5oSU5enbQZzqgvy62oIRbVnqwtqeKKiiF4inqAy0DHpKmOaRaf8Hzz+zlmLyhzDCnuurNq/BeidErKSpgJQs6rXrxe6F+diNKTXkGfnZAOVU0Wh+1joTWbyvrYtzQLgGI/z22ioSfuYQg2GVNi5toGuUaRZhDVdL6eQ1kL9yy3b9JZ283AgMGOptHyArCoNazphiAhgULEQiW40zenyvwAG1HgH+wGvMFZhbbRyGNvyAo1655MgBsMQjkSz7gUjVNsCrOUy7WtKx32Uv1NeqYPFxkDldp0SgId/KNgvjUM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 7.6.2023 17.10, Christoph Hellwig wrote: > On Tue, Jun 06, 2023 at 08:01:49AM +0300, mpenttil@redhat.com wrote: >> From: Mika Penttilä >> >> Migrating file pages and swapcache pages into device memory is not supported. >> The decision is done based on page_mapping(). For now, swapcache pages are not migrated. > > Please fix the commit log formatting, it should not exceed 7 lines. > >> if (is_device_private_page(newpage) || >> is_device_coherent_page(newpage)) { >> - /* >> - * For now only support anonymous memory migrating to >> - * device private or coherent memory. >> - */ >> + >> if (mapping) { > > Very nitpicky, but this empty line looks odd. Also isn't the comment > still (mostly) correct given that file backed memory is still not > supported? Yes the comment is mostly correct and moved a few lines lower, complemented with a comment about the swap cache. > >> + /* >> + * For now only support anonymous memory migrating to >> + * device private or coherent memory. >> + * >> + * Try to get rid of swap cache if possible. >> + * >> + */ >> + if (!folio_test_anon(folio) || !folio_free_swap(folio)) { > > Please avoid the overly long lines. > Thanks, Mika