From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wanpeng Li Subject: Re: [PATCH] slub: Don't throw away partial remote slabs if there is no local memory Date: Fri, 24 Jan 2014 11:14:12 +0800 Message-ID: <43448.5480575406$1390533292@news.gmane.org> References: <20140107132100.5b5ad198@kryten> <20140107074136.GA4011@lge.com> <52dce7fe.e5e6420a.5ff6.ffff84a0SMTPIN_ADDED_BROKEN@mx.google.com> <52e1d960.2715420a.3569.1013SMTPIN_ADDED_BROKEN@mx.google.com> Reply-To: Wanpeng Li Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <52e1d960.2715420a.3569.1013SMTPIN_ADDED_BROKEN@mx.google.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Christoph Lameter Cc: nacc@linux.vnet.ibm.com, David Rientjes , penberg@kernel.org, linux-mm@kvack.org, Han Pingtian , paulus@samba.org, Anton Blanchard , mpm@selenic.com, Joonsoo Kim , linuxppc-dev@lists.ozlabs.org List-Id: linux-mm.kvack.org On Fri, Jan 24, 2014 at 11:09:07AM +0800, Wanpeng Li wrote: >Hi Christoph, >On Mon, Jan 20, 2014 at 04:13:30PM -0600, Christoph Lameter wrote: >>On Mon, 20 Jan 2014, Wanpeng Li wrote: >> >>> >+ enum zone_type high_zoneidx = gfp_zone(flags); >>> > >>> >+ if (!node_present_pages(searchnode)) { >>> >+ zonelist = node_zonelist(searchnode, flags); >>> >+ for_each_zone_zonelist(zone, z, zonelist, high_zoneidx) { >>> >+ searchnode = zone_to_nid(zone); >>> >+ if (node_present_pages(searchnode)) >>> >+ break; >>> >+ } >>> >+ } >>> > object = get_partial_node(s, get_node(s, searchnode), c, flags); >>> > if (object || node != NUMA_NO_NODE) >>> > return object; >>> > >>> >>> The patch fix the bug. However, the kernel crashed very quickly after running >>> stress tests for a short while: >> >>This is not a good way of fixing it. How about not asking for memory from >>nodes that are memoryless? Use numa_mem_id() which gives you the next node >>that has memory instead of numa_node_id() (gives you the current node >>regardless if it has memory or not). > >diff --git a/mm/slub.c b/mm/slub.c >index 545a170..a1c6040 100644 >--- a/mm/slub.c >+++ b/mm/slub.c >@@ -1700,6 +1700,9 @@ static void *get_partial(struct kmem_cache *s, gfp_t flags, int node, > void *object; > int searchnode = (node == NUMA_NO_NODE) ? numa_node_id() : node; > >+ if (!node_present_pages(searchnode)) >+ searchnode = numa_mem_id(); >+ > object = get_partial_node(s, get_node(s, searchnode), c, flags); > if (object || node != NUMA_NO_NODE) > return object; > The bug still can't be fixed w/ this patch. Regards, Wanpeng Li >-- >To unsubscribe, send a message with 'unsubscribe linux-mm' in >the body to majordomo@kvack.org. For more info on Linux MM, >see: http://www.linux-mm.org/ . >Don't email: email@kvack.org