From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <433B8E76.9080005@yahoo.com.au> Date: Thu, 29 Sep 2005 16:49:26 +1000 From: Nick Piggin MIME-Version: 1.0 Subject: Re: [patch] Reset the high water marks in CPUs pcp list References: <20050928105009.B29282@unix-os.sc.intel.com> <1127939185.5046.17.camel@akash.sc.intel.com> <1127943168.5046.39.camel@akash.sc.intel.com> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Rohit Seth , akpm@osdl.org, linux-mm@kvack.org, Mattia Dongili , linux-kernel@vger.kernel.org, steiner@sgi.com List-ID: Christoph Lameter wrote: > >I know that Jack and Nick did something with those counts to insure that >page coloring effects are avoided. Would you comment? > > The 'batch' argument to setup_pageset should be clamped to a power of 2 minus 1 (ie. 15, 31, etc), which was found to avoid the worst of the colouring problems. pcp->high of the hotlist IMO should have been reduced to 4 anyway after its pcp->low was reduced from 2 to 0. I don't see that there would be any problems with playing with the ->high and ->low numbers so long as they are a reasonable multiple of batch, however I would question the merit of setting the high watermark of the cold queue to ->batch + 1 (should really stay at 2*batch IMO). Nick Send instant messages to your online friends http://au.messenger.yahoo.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org