From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83F8CC54791 for ; Wed, 13 Mar 2024 16:22:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1420E8003D; Wed, 13 Mar 2024 12:22:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F218940010; Wed, 13 Mar 2024 12:22:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E865A8003D; Wed, 13 Mar 2024 12:22:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D3756940010 for ; Wed, 13 Mar 2024 12:22:42 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 85473A0250 for ; Wed, 13 Mar 2024 16:22:42 +0000 (UTC) X-FDA: 81892534164.13.3CB5366 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by imf04.hostedemail.com (Postfix) with ESMTP id 711D140022 for ; Wed, 13 Mar 2024 16:22:39 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=FmQxtwWX; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf04.hostedemail.com: domain of m.szyprowski@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=m.szyprowski@samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710346960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BWYpIQ4r8Zif4LDU74qDLvjeFc0NUCjMapnqPAf0A0A=; b=aqG6mQ9uXMuyOeayzxITneaZSAMBAYdMGBM4XHBDipCw5tE2X8bXgwl/cIu+sYljctY3ZN 0ftMOJxKRZNbabGewm/jpTC0vcDdonddysa3mDuWJigDbqJ/nwHyvoCh/jb6Gbk0vT6vT7 jLE11BDyewOTL9BPFx8OAjWrTdY14aE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=FmQxtwWX; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf04.hostedemail.com: domain of m.szyprowski@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=m.szyprowski@samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710346960; a=rsa-sha256; cv=none; b=Itr9HKjjF1peg5a6hIOX/ZCNh1EiQFY8+EeXKWERNuDE4QwtsVGy5DT5loUfEjNjQo2D2r 4eyn1FNuLgT5L+g6falcEmCbJrrNkaQQhnVeqIsfGcM1I+Byraon9s/88AplVsNQ3G9FlH 633JlmULLvhAudB1qUlt4gdPuS5KjrM= Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20240313162236euoutp01f2e00cff085ec9a24a130aba51fef99c~8X37YQ1TG1040110401euoutp01W for ; Wed, 13 Mar 2024 16:22:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20240313162236euoutp01f2e00cff085ec9a24a130aba51fef99c~8X37YQ1TG1040110401euoutp01W DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1710346956; bh=BWYpIQ4r8Zif4LDU74qDLvjeFc0NUCjMapnqPAf0A0A=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=FmQxtwWXyS+ZA5MhUasJZI3KNbBCsKP2clw7HGBuxFoY717wXEtF9kkvTn/XZg2E2 Lv35CNxdbnNzKY4iyMp8QIZ/0A7TtXo7rX7N0eKKb3679//iJsULX4LO+pMqjT20os YW4RzlsbEk7vYcDOI32Pqub51y7zBWmkQspCFA6M= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20240313162236eucas1p188d08dbd27a4fc35d26ebf2f74590b6e~8X36yA8jY2090920909eucas1p1e; Wed, 13 Mar 2024 16:22:36 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 68.55.09539.CC2D1F56; Wed, 13 Mar 2024 16:22:36 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20240313162235eucas1p28985c12dd057d42fda670ff1566be92d~8X36Pwf3_1629816298eucas1p2S; Wed, 13 Mar 2024 16:22:35 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20240313162235eusmtrp1f3227630d7e3e933cdaf6b8087004dfb~8X36Ojy0i0652306523eusmtrp1H; Wed, 13 Mar 2024 16:22:35 +0000 (GMT) X-AuditID: cbfec7f2-52bff70000002543-cf-65f1d2cc6aa7 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 41.6F.10702.BC2D1F56; Wed, 13 Mar 2024 16:22:35 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20240313162234eusmtip255ffd96a8a17ee58b730fe9562d7edd7~8X35KaLOq1857618576eusmtip2O; Wed, 13 Mar 2024 16:22:34 +0000 (GMT) Message-ID: <432c1980-b00f-4b07-9e24-0bec52ccb5d6@samsung.com> Date: Wed, 13 Mar 2024 17:22:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] ARM64: Dynamically allocate cpumasks and increase supported CPUs to 512 Content-Language: en-US To: Sudeep Holla , Catalin Marinas Cc: "Christoph Lameter (Ampere)" , Mark Rutland , "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , Viresh Kumar , Will Deacon , Jonathan.Cameron@huawei.com, Matteo.Carlini@arm.com, Valentin.Schneider@arm.com, akpm@linux-foundation.org, anshuman.khandual@arm.com, Eric Mackay , dave.kleikamp@oracle.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux@armlinux.org.uk, robin.murphy@arm.com, vanshikonda@os.amperecomputing.com, yang@os.amperecomputing.com, Nishanth Menon , Stephen Boyd From: Marek Szyprowski In-Reply-To: Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA01SbUxTVxjeuff29tJZcimwnrA5QhPZGIFCxsJJYDiWqTeLLi5TF6bONXCh jILQwmDitiYgH1UJQZBaUZAgHQ0ZUj6KTIl0QPmYTD5WWFMHywqLxE4LTESkjnpx49/zPO/z vu/znhwKF1WSAVRqRjarzJApJKSA6BxY/SXs53EXG6F+JkA1Lc0k6hlMRA8azwA09eg+QLfm x3E0527kI8MVK4mMf1p5aKK7hkS/Nz/joaWzfQCZq24CdHVqDENrjSsYuv/4NoYuLVfhqPeh g4fc1lYC6Ye7CGSqXcXRPZudQG2zAyQqtL+DzjYM8d+DTPPlZsBMWMdwprDPyWOMhlKSMS5W 8JlB7RrBOCarMaat4TvGNWcjmNMT03zGMm3CmCXj6/u3fSaITWIVqV+xSmncFwL5udpuMnNl W9765XKgBg0CDfCiIB0Fh1fLcQ0QUCL6ewBnNHc3yTKAv8628zmyBOANw9/kixbt7WrAFfQA jmrdGEdcAI7XFGMel5COg3btLeDBBL0DmgcLeZzuA4cuOAgP9qcD4YxNy/dgX1oGF0x1uAfj tBjaHLUbcyjKjz4AlyyHPPNx2sqDLRuP5/GQdCTUODXPE3ltzF961L7ZGwgLOi4+vwHSGgEs a+vfjP0BrFrp53HYFy5Y2vkcfg2OnDtDcA3FANatzWAcKQdQ/ZcNcK4YaB99Qnoi4XQIbOmW cnI8XChr4XtkSHvDaacPF8IbVnRW45wshCVFIs4dDHWWH/5b23tnHC8HEt2WZ9FtOV+35Rzd /3vrAGEAYjZHlZ7CqiIz2NxwlSxdlZOREp54PN0INj7uiNuy2AUuLbjCzQCjgBlACpf4Cb8N crEiYZLs6xOs8vgxZY6CVZnBqxQhEQt3JAWyIjpFls2msWwmq3xRxSivADUWOp92Cj+RhXX7 xSzHP405eHD4zZCxe/5xCR/uif/U96WTF/YTFf4FCd46eK2/fj3UpchV7ZP2qqofTtV39gRP 2kQfmdz51wFIDzgWEZJ6JGH7zr73j1yJ65LEJueHFU3E5j1NWPlpt/5UbpSrnpqM0n+Z+Diz /8d3Q8McTUclA2/sjHjZ9IfwwdESs4GRl4JvPjm/fURakh4tv5h2xzTVn90ECnq8K8tutg49 KTzAhgff+HyO1pcN2kNm55OvO/18KsV5hzs056u011Zb3y5N/WcyendVVkVQm0J9uIjK77j7 SlCTWFucpdybVLdr1565bOdpnsaeLP9N+rFi3/rJxehRCaGSyyLfwpUq2b99bQsXJwQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOKsWRmVeSWpSXmKPExsVy+t/xe7qnL31MNZi0RMlizvo1bBb7TiRb vF/Ww2hx/dsbRosDzy4xWzz9t4zdYtXCa2wWmx5fY7W4vGsOm8W9Nf9ZLT73HmG0ODR1L6PF 0usXmSx+L/vOZPHmx1kmi7lfpjJbHPzwhNXi37WNLBbLT+1gsdg+/yezxctbd1gsNj84xmbR csfUonfJSXYHCY8189Ywely+dpHZo+XIW1aPTas62Tw2fZrE7nFixm8WjydXpjN5bF5S7/Hx 6S0Wj+7LN9g9jt/YzuTxeZNcAE+Unk1RfmlJqkJGfnGJrVK0oYWRnqGlhZ6RiaWeobF5rJWR qZK+nU1Kak5mWWqRvl2CXsbk+bvYCr7zVPydN4GxgXEJVxcjJ4eEgInEjLPTGbsYuTiEBJYy SvRebGeESMhInJzWwAphC0v8udbFBlH0nlGi/c9vsASvgJ3EnRkHwBpYBFQlDp1ogYoLSpyc +YQFxBYVkJe4f2sGO4gtLJAo8Wr7AmYQm1lAXOLWk/lMILaIQIjEgcctLCALmAWusUpcenIa 6qS/TBI7PzwFq2ITMJToegtyBicHJ9C2z9+2QE0yk+ja2sUIYctLNG+dzTyBUWgWkkNmIVk4 C0nLLCQtCxhZVjGKpJYW56bnFhvpFSfmFpfmpesl5+duYgSmmG3Hfm7Zwbjy1Ue9Q4xMHIyH GCU4mJVEeOsUP6YK8aYkVlalFuXHF5XmpBYfYjQFhsZEZinR5HxgkssriTc0MzA1NDGzNDC1 NDNWEuf1LOhIFBJITyxJzU5NLUgtgulj4uCUamCKkD+f+k7I+731pWu6Tx+47/GqOy+QU9j+ 2tTQSPzdRiepfTHxUne/M5066sJy+tCK6DqdPWFKkwM+L/9pI3E7e/P3D54mv0Ub9laFb4jm kWJ83b9ZdZnitf3/tCU1Jl5K2nCk4nD4yb+CF+02pASkFx0O01+pyzzzq+zJmptVt9sE5or7 bdy1Lv/i1ztX2Y/eOZofs5N36sa3Z5PlV8joqVdrJVuzbzJtlQ3M4w2buVjSg5Eng6fUY8eZ F8+YDR+fkKn70LV+mQVben+amtT5xKgDM37evNVb4Ffp0m/Ft7PQ4vrepsiMyfe2dc3j8Gzt lXqS3xYqOHPfmTXJDHqTagv9fldvrC69fyLWJFyJpTgj0VCLuag4EQDv/JGNugMAAA== X-CMS-MailID: 20240313162235eucas1p28985c12dd057d42fda670ff1566be92d X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20240308140130eucas1p1259c805a0b6491ce2f69c6fca0264b1f X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20240308140130eucas1p1259c805a0b6491ce2f69c6fca0264b1f References: <37099a57-b655-3b3a-56d0-5f7fbd49d7db@gentwo.org> <9352f410-9dad-ac89-181a-b3cfc86176b8@linux.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 711D140022 X-Stat-Signature: sjdsebfdojdubg9ju4khn8rrnet6hzjb X-HE-Tag: 1710346959-89485 X-HE-Meta: U2FsdGVkX1+qG8O89Sj88Ylu1eSF/nKFHiVvi35PfikeD0XQpcP7Cgbsr+RKt63jzqjB7L/SwAAdjeT6mDVDTvWouNKMMpQ8YTNIWaaDo4n7rrBRXabtwh48Bga+sv96UjjZQd3OtGVmZeLTFfrU85526xesZBjTbvst/umND20eG6102NFgKb0G5pVUS508yf/AsphmWPmwHhQn85KAgfRW/HXTbVylGSZ0kdeAOd79QxF+muP+NbNFAaussHG+gwt/SppCt+ghRHsuhfEVzN3Z28gpN9tkIzko8qtZhcgGEXG7+nFl5RvClLhar9ceU7ct4t1N1Mh4XFr6q0VvpmTArAb5uBTSxU02NCsP0Rx0xDWhjfTIHhPje36YtCGMH0ieTCgnWMpUOMuFXYi261UCHFoPemqEuSMtKiGd7V1gC8DX1Zg9HicJVnxlAnpPiSLeSJ5baln7aTwCFYZ/jx0GPyjYO9eiummO5dreAcYhGutg52D6fTNYIjSTmSXflSAtHQRsT6Fpg3jfPXAKnnakGlgz/PHYdT98rf/EbHaDTLsl7s7DHEOS3G/O8sALwwpF7Sgbv/XfT2PbH89RxH7f3vu2dRbOIX6OJMoGV5PxbnpFExhN62ASJWmjKwVRMzrTTp0k1PlWmCV4ROGru84deIlptchzFDmUexT2hO/vTHuaFzahlHKqr4lX82wEihKuXh7fglnzIMGmtX5Lc7SPbki1hW5oB1BiyUZSOGZDGERyTlHdlDAFq5vo7DPQCxL0MtEWrePZc5QVxyvXsjZJYAqnk54l7u1pW3SA8HguqjHBOsUmnoNbZqyLjI0Vq+i3FTaOzzOnDEsIDhD1d4kiRf/W8xhy9gipb+nKVWdUTnCmDYUqrIiC2dyml0nWOdB7/Q1qRg5gaBO6g8vzEUcrPTtQ3sUDHZlwQyhl+h8/IT+Drn8d1Z1GyJQdWftrBHcsbL9VQNFfhpG76xJ Iu+M3FNB 4raUPetBt8CxpO99gt52NGSEil7SzW9FYgIEbVAS4sGeYw0w4cXxgCfdwLljKYCKekE9lcBuw7/HQbmVaJax66IomuYvqgsZUBpwZ0XbHPWdz11ZCAdtyKffOUjtWP1LZejufHvJprGCzYTcPxXU2uveSO/SHqGFD9nLKKEAjUqM81bA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.03.2024 15:35, Sudeep Holla wrote: > On Tue, Mar 12, 2024 at 05:55:49PM +0000, Catalin Marinas wrote: >> On Tue, Mar 12, 2024 at 10:06:06AM -0700, Christoph Lameter (Ampere) wrote: >>> On Mon, 11 Mar 2024, Christoph Lameter (Ampere) wrote: >>> >>>> This could be an issue in the ARM64 arch code itself where there maybe >>>> an assumption elsewhere that a cpumask can always store up to NR_CPU >>>> cpus and not only nr_cpu_ids as OFFSTACK does. >>>> >>>> How can I exercise the opp driver in order to recreate the problem? >>>> >>>> I assume the opp driver is ARM specific? x86 defaults to OFFSTACK so if >>>> there is an issue with OFFSTACK in opp then it should fail with kernel >>>> default configuration on that platform. >>> I checked the ARM64 arch sources use of NR_CPUS and its all fine. >>> >>> Also verified in my testing logs that CONFIG_PM_OPP was set in all tests. >>> >>> No warnings in the kernel log during those tests. >>> >>> How to reproduce this? >> I guess you need a platform with a dts that has an "operating-points-v2" >> property. I don't have any around. >> >> Sudeep was trying to trigger this code path earlier, not sure where he >> got to. > I did try to trigger this on FVP by adding OPPs + some hacks to add dummy > clock provider to successfully probe this driver. I couldn't hit the issue > reported 🙁. It could be that with the hardware clock/regulator drivers, it > take a different path in OPP core. I can fully reproduce this issue on Khadas VIM3 and Odroid-N2 boards. Both Meson A311D SoC based. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland