From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 907796B003D for ; Thu, 19 Mar 2009 07:37:00 -0400 (EDT) Received: from m6.gw.fujitsu.co.jp ([10.0.50.76]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id n2JBaw7p021941 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Thu, 19 Mar 2009 20:36:58 +0900 Received: from smail (m6 [127.0.0.1]) by outgoing.m6.gw.fujitsu.co.jp (Postfix) with ESMTP id 11C3D45DE52 for ; Thu, 19 Mar 2009 20:36:58 +0900 (JST) Received: from s6.gw.fujitsu.co.jp (s6.gw.fujitsu.co.jp [10.0.50.96]) by m6.gw.fujitsu.co.jp (Postfix) with ESMTP id E286245DD72 for ; Thu, 19 Mar 2009 20:36:57 +0900 (JST) Received: from s6.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id CF90BE18002 for ; Thu, 19 Mar 2009 20:36:57 +0900 (JST) Received: from ml10.s.css.fujitsu.com (ml10.s.css.fujitsu.com [10.249.87.100]) by s6.gw.fujitsu.co.jp (Postfix) with ESMTP id 833D31DB803A for ; Thu, 19 Mar 2009 20:36:57 +0900 (JST) Message-ID: <432ace3655a26d2d492a56303369a88a.squirrel@webmail-b.css.fujitsu.com> In-Reply-To: <100477cfc6c3c775abc7aecd4ce8c46e.squirrel@webmail-b.css.fujitsu.com> References: <20090317135702.4222e62e.nishimura@mxp.nes.nec.co.jp> <20090317143903.a789cf57.kamezawa.hiroyu@jp.fujitsu.com> <20090317151113.79a3cc9d.nishimura@mxp.nes.nec.co.jp> <20090317162950.70c1245c.kamezawa.hiroyu@jp.fujitsu.com> <20090317183850.67c35b27.kamezawa.hiroyu@jp.fujitsu.com> <20090318101727.f00dfc2f.nishimura@mxp.nes.nec.co.jp> <20090318103418.7d38dce0.kamezawa.hiroyu@jp.fujitsu.com> <20090318125154.f8ffe652.nishimura@mxp.nes.nec.co.jp> <20090318175734.f5a8a446.kamezawa.hiroyu@jp.fujitsu.com> <20090318231738.4e042cbd.d-nishimura@mtf.biglobe.ne.jp> <20090319084523.1fbcc3cb.kamezawa.hiroyu@jp.fujitsu.com> <20090319111629.dcc9fe43.kamezawa.hiroyu@jp.fujitsu.com> <20090319180631.44b0130f.kamezawa.hiroyu@jp.fujitsu.com> <20090319190118.db8a1dd7.nishimura@mxp.nes.nec.co.jp> <20090319191321.6be9b5e8.nishimura@mxp.nes.nec.co.jp> <100477cfc6c3c775abc7aecd4ce8c46e.squirrel@webmail-b.css.fujitsu.com> Date: Thu, 19 Mar 2009 20:36:56 +0900 (JST) Subject: Re: [PATCH] fix unused/stale swap cache handling on memcg v2 From: "KAMEZAWA Hiroyuki" MIME-Version: 1.0 Content-Type: text/plain;charset=iso-2022-jp Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: Daisuke Nishimura , Daisuke Nishimura , linux-mm , Balbir Singh , Hugh Dickins List-ID: KAMEZAWA Hiroyuki さんは書きました： > Daisuke Nishimura さんは書きました： >> On Thu, 19 Mar 2009 19:01:18 +0900, Daisuke Nishimura >> wrote: >>> On Thu, 19 Mar 2009 18:06:31 +0900, KAMEZAWA Hiroyuki >>> wrote: >>> > Core logic are much improved and I confirmed this logic can reduce >>> > orphan swap-caches. (But the patch size is bigger than expected.) >>> > Long term test is required and we have to verify paramaters are >>> reasonable >>> > and whether this doesn't make swapped-out applications slow.. >>> > >>> Thank you for your patch. >>> I'll test this version and check what happens about swapcache usage. >>> >> hmm... underflow of inactive_anon seems to happen after a while. >> I've not done anything but causing memory pressure yet. >> > Hmm..maybe I miss something. maybe mem_cgroup_commit_charge() removes > Orphan flag implicitly. > I couldn't repoduce, hmm..but yes there would be something racy. > I'll dig but may not be able to post a patch in this week. > The more I consider, the more the code is complicated. Sigh...I'd like to find another way, if I can. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org