Re: [PATCH] fix unused/stale swap cache handling on memcg v2

["KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>]

KAMEZAWA Hiroyuki さんは書きました：
> Daisuke Nishimura さんは書きました：
>> On Thu, 19 Mar 2009 19:01:18 +0900, Daisuke Nishimura
>> <nishimura@mxp.nes.nec.co.jp> wrote:
>>> On Thu, 19 Mar 2009 18:06:31 +0900, KAMEZAWA Hiroyuki
>>> <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>>> > Core logic are much improved and I confirmed this logic can reduce
>>> > orphan swap-caches. (But the patch size is bigger than expected.)
>>> > Long term test is required and we have to verify paramaters are
>>> reasonable
>>> > and whether this doesn't make swapped-out applications slow..
>>> >
>>> Thank you for your patch.
>>> I'll test this version and check what happens about swapcache usage.
>>>
>> hmm... underflow of inactive_anon seems to happen after a while.
>> I've not done anything but causing memory pressure yet.
>>
> Hmm..maybe I miss something. maybe mem_cgroup_commit_charge() removes
> Orphan flag implicitly.
>
I couldn't repoduce, hmm..but yes there would be something racy.

> I'll dig but may not be able to post a patch in this week.
>
The more I consider, the more the code is complicated.
Sigh...I'd like to find another way, if I can.

Thanks,
-Kame

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>