From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9A4EC4345F for ; Mon, 22 Apr 2024 15:09:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C9E46B0087; Mon, 22 Apr 2024 11:09:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17A7C6B0089; Mon, 22 Apr 2024 11:09:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01A9B6B008A; Mon, 22 Apr 2024 11:09:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D7FC26B0087 for ; Mon, 22 Apr 2024 11:09:35 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 88BF280C13 for ; Mon, 22 Apr 2024 15:09:35 +0000 (UTC) X-FDA: 82037501910.03.553C94D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 51B3F4001D for ; Mon, 22 Apr 2024 15:09:32 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dZpCah1x; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713798572; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2l5etRFA+3zS98rLPSjEL/W080Qc09Rpjm6l7LxbWqo=; b=ereAgsNW2FpPl+mU9Op2buc98UGG1SC8EOQe2NN+sbTgkt+2wfcEbFPwsHbeIzrKGXrWKO fcQFhCvq8nN6GjD8WuAVUW1GpojDW0bUCzPyzuleHAYWKuZc6xqAu8xcUIdaEvM7KH2Vrf RMbor5k19JCiyQKyNB4Hv2NcdashAHc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dZpCah1x; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713798572; a=rsa-sha256; cv=none; b=shnWZFWH00O95qu7esn1rNMMldB7Iq/FdglxVaQAdROEev/mQmTv4QDw8aGiXQZs9+izS0 dPfm/D8Z/8HlVkoONeIEOzKRTE3s0bnjvIx5RIC95COpLwwgrXAmLTHBrTbBKkp0QAOoRx T3ex+fUo7YGlCp6bQwJmh+Pe5xpZNY8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713798571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2l5etRFA+3zS98rLPSjEL/W080Qc09Rpjm6l7LxbWqo=; b=dZpCah1xF40K7s21nKQlOH6IAwyzW8UYI05nSMv/0MV/LurjOyI4+pOoBp8mzs2BqVkOrG Ee8Ztmz47xhqkcOkJTrHm3CQuedRCQWoIiaZgZ8OTpAJ8RCQ5EUyerCIQv532DijoQd/pm kBpvOUBZUCnHhPcVcqnXCeq6L8q2ETM= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-15-7kVxV1QaNOq_KR3anPdPIw-1; Mon, 22 Apr 2024 11:09:30 -0400 X-MC-Unique: 7kVxV1QaNOq_KR3anPdPIw-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2d88271f485so37644291fa.1 for ; Mon, 22 Apr 2024 08:09:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713798569; x=1714403369; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2l5etRFA+3zS98rLPSjEL/W080Qc09Rpjm6l7LxbWqo=; b=IA52BCjqD9ElVDS7Ki9gk8bqODExdRQFlh6UPqMMQxPlt7bO95mgeejsFUl3+FrQeY Omx58zcTz/yQbbhzyQ6Wa0pTxjdioJcMdcfv194paYDUAEFNrfr5mRDQczfiWQAn25u/ k63H20lE1QBkbnoY69IXo4PDalWY9oCvyQ0fmyARkkVkG9Waqt8vRlc4S3DlSTtGFmnb Q4nKI1mFH5tbwGnpcjSm+xuua4w2g45c/oTpjPcDPBtpyANl/Q1JAmI43zNO85fKxqoV bJ93vCV1FVRubc4CdCldiTGRBs8An9rXYpASzyvExar8Rd+JYqcYFWOnR8dwFzUaW/UI 6gfQ== X-Forwarded-Encrypted: i=1; AJvYcCWXMuP48XqQRIuqK2gAXR0kOwS/zeNFsrZdaAndwz4gCpAnQvReMtkyl0d4DprVlCRGXpx0XXyvgvrH85GBMZ1O2UM= X-Gm-Message-State: AOJu0Yzk60tejKDtltMMbT4vtH8XqfXTA2vd4dqAcbIxCJ/v8flm6c5+ cY3P2PePnqU8GALQ+82Ozzrgs6I9Y13h0HnQUA98WAwZwzxFEGdygg704+tcVwMgJJk9vMWiew5 L71Dit5iQhrAy4FYoNCfzBEVvEGPmV+qk8TRlbqiupy6KLNr3 X-Received: by 2002:a2e:98d3:0:b0:2d8:f3b:d026 with SMTP id s19-20020a2e98d3000000b002d80f3bd026mr6919201ljj.14.1713798568834; Mon, 22 Apr 2024 08:09:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHH/S6k0dekbOWFX638LcGCK7Nb/JSn/s2VEj2jbLQe6bRt+XloX7Ltfx6Ru3sdcWlech/6Cw== X-Received: by 2002:a2e:98d3:0:b0:2d8:f3b:d026 with SMTP id s19-20020a2e98d3000000b002d80f3bd026mr6919123ljj.14.1713798567402; Mon, 22 Apr 2024 08:09:27 -0700 (PDT) Received: from ?IPV6:2003:cb:c739:600:d2fb:3a8a:9944:7910? (p200300cbc7390600d2fb3a8a99447910.dip0.t-ipconnect.de. [2003:cb:c739:600:d2fb:3a8a:9944:7910]) by smtp.gmail.com with ESMTPSA id t18-20020a05600c199200b00417ee784fcasm16996478wmq.45.2024.04.22.08.09.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Apr 2024 08:09:26 -0700 (PDT) Message-ID: <4328e879-f5dc-4b90-89bd-d7969afba350@redhat.com> Date: Mon, 22 Apr 2024 17:09:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/userfaultfd: Reset ptes when close() for wr-protected ones To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Nadav Amit , Andrew Morton , syzbot+d8426b591c36b21c750e@syzkaller.appspotmail.com References: <20240422133311.2987675-1-peterx@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240422133311.2987675-1-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: z7g1hjpnkzrjzcbpttgp8kni66eymo5p X-Rspamd-Queue-Id: 51B3F4001D X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1713798572-115147 X-HE-Meta: U2FsdGVkX19fBv9Axdu/ZkDrmpXKr7uFJK390Hw3HELgYfkmShZalMadme3zIdiVQhsrr42SRBMTCEgruYXYcBD7FH2RkfXYsO7NNb6skNru3GYeXFFTCWELlloPDe9sLVRkR53IeiJDb1OK964V2XkmpdDkN/JCHycQ+xwOg32XbBAxQxFIYpwHKY9YHL1/jgIeUW4ordCQkgdtW+5gmaEMPWzrTrl2ErlasGf+KWNTSVt5ib0H5X9+afZmNwwj0NVuAwUx6NQ+0wsUZK9Y7QPCVzx12csqDH5ip1DiRISIaynnBs9hkYYtH7kL3rQumOuEBXkjNSp+RmwirCxTmavmdLbxybcEggFvudG5yTqrfrdSukntQyuvWPg2Iikp0mhOR8DbyPW+68FThEBFDXrD1vQI2yhTWCD2DDQy85tBzhaCl/mEE33cwHOAG7gth+WJ1Z8IcTwbH7QnJ6g77eyun/1XE/6yRzb84eWV24y+j9vM8FxZMamtPLerGKC9oWFj6LnGjjG8r4LrtAQAXzzO5L4KJWwx8m1s1T7GW5/nUMcRBGSw8bzSzcMMH3bgYyr/yWl8RCrS6PEs5GKYYI61gcw47NiwQnuO/FQMColXIsN3SjucFcMSkKXgA2xwi/b9Qmmp6XNVxKfeaXS4C0dj6oLMHzc/eiaKVrb/I1bf6w1uvpOsbb/tGjF7z7N3ggORRr60BMctP9G60el2itaAUhSVhpK3Oap+oSwPCvYHPRsRWWUlVLwV25p/U31TPY3FJNnX90Bzs749nsPy+Va4CEHJrzLxnE3xonjz5IHyieozR3FfTwMkHE7/JbpBwoZtcXBFECWG1i0QTvMtaaBnPHiPTNhs8Kz5xb3nTchidLQUiRPbHU5oCXdNrqRMEl3BYN1rW+dZBf+HbWCLSGwOASORyE8XlBKFOY14GD7lZDJHxUEPwmo1I0GrShcNH8kjBzGNonEiy9pN0st 5Fwp0jZv qOK1k7U+eGRdfQ2vqq7WruKuVEUxwIKEWWtEJO3BPmiePGPiFeTuW/7LXMAXztFfnbIgZii6UhXCELp4yTMxdtBjlEg5HOPCMymezxQvJm9zx8Hk+QKaqk9j7mQ95SWyfwvARUtT405x+0h8gn1Fz2wAfFYI8sqfsJGY0hOtJxUexgB82USntxiFG9z28/v+gnvKEHc7oRjy1SzXb5JO94TitX6aVAjUBGCUG2RZmMKuRUebzO7nMMu/SZOdKHQ+S4xrmjTFMiGcxZO2DvlNzCAbNuda50RXOrBm5s9P4Lx0wRQLS1semuEUjCqwB1R2xvfu4nZJALLticXoNNCRaRomqnLiYRPrVTrqRtQBHphfE8StmbfALqCYQdy+jd5eN6hIhimqlgKcU0SQEfc7Y7ZklGGeQhfPx/t5kV/QjuWfD1OBf2uD94g5bS7VMJaVjqryNg7Eps+jekZSDR7bcbr6mKJjfs97j5UZU+cBNoajh5/sBIP8YTyBGXAMUOvHCsyW0XYmy0JT8oXHbDCvQe95QUgkd1pPnYJYoZwATTB5VrIu8EQEjvlG5sMChOZ4/zzq4+HwVM/2VUj5iSZ7098+4XRxWD58VpIPFi5usCWITDSbHdqvCJxWTq0jiGRpqCHsbuqVaroYdab2ik2FzwhlDrWy9CHKeM74D7sWfdDzKCss= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.04.24 15:33, Peter Xu wrote: > Userfaultfd unregister includes a step to remove wr-protect bits from all > the relevant pgtable entries, but that only covered an explicit > UFFDIO_UNREGISTER ioctl, not a close() on the userfaultfd itself. Cover > that too. > > Link: https://lore.kernel.org/all/000000000000ca4df20616a0fe16@google.com/ > Analyzed-by: David Hildenbrand > Reported-by: syzbot+d8426b591c36b21c750e@syzkaller.appspotmail.com > Signed-off-by: Peter Xu > --- > fs/userfaultfd.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c > index 3e6ddda6f159..d2c3879745e5 100644 > --- a/fs/userfaultfd.c > +++ b/fs/userfaultfd.c > @@ -898,6 +898,10 @@ static int userfaultfd_release(struct inode *inode, struct file *file) > prev = vma; > continue; > } > + /* Reset ptes for the whole vma range if wr-protected */ > + if (userfaultfd_wp(vma)) > + uffd_wp_range(vma, vma->vm_start, > + vma->vm_end - vma->vm_start, false); > new_flags = vma->vm_flags & ~__VM_UFFD_FLAGS; > vma = vma_modify_flags_uffd(&vmi, prev, vma, vma->vm_start, > vma->vm_end, new_flags, LGTM Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb