From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8878C02182 for ; Mon, 20 Jan 2025 20:14:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3446A6B007B; Mon, 20 Jan 2025 15:14:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CD476B0083; Mon, 20 Jan 2025 15:14:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11FD66B0085; Mon, 20 Jan 2025 15:14:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E3FE66B007B for ; Mon, 20 Jan 2025 15:14:18 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 84CFAC0339 for ; Mon, 20 Jan 2025 20:14:18 +0000 (UTC) X-FDA: 83028932196.29.29415FF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 0EC5B100002 for ; Mon, 20 Jan 2025 20:14:15 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=haE6BH4P; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737404056; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kkNwxsqydWvbAxFVzgZ2uAaynW73vTt/6ab2/wVgs7c=; b=EPI3lx/FOgtrCFK9mpc2E6nbyO3PL75ApttY6s0bcs/ilA12YFBzjRtcKcuZ7X4NDSEvqu CdKXbs8iW7IhuvLCaAcH6xVRFTb5TTAkFBYA3mLffBp7WYxJykRUmXVu+oC2VwHtpPvs0h oYUzbNSYBD822sho5gDgxTXf/2iI1V0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737404056; a=rsa-sha256; cv=none; b=KQdiapU3P9o3c/B7+fDc9yCML/q6crrMiCfyBwp5YIkJsHqp2pKNbcUpcTmECe9Elba8mI 548xq5I2kBYQ/wjgf7YKFAlWBYQZsf5crYP9dqFnxBdxzBBq92GvAq/5J9w6wA0P0G7Hc+ 820NG2t4Id81Riq2T0xJibSk8gRJVDs= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=haE6BH4P; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737404055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kkNwxsqydWvbAxFVzgZ2uAaynW73vTt/6ab2/wVgs7c=; b=haE6BH4P2rbgda7OP4auzvtErG2RZiXfELO/yI47g/7RuQdrYmV9kilkklM2yOaPBtIpZe 93dzsjWKAARES0poflKfUOD5ehg8GFpZDvKacd0ED9CjANgBeX3bg+/by/sa6kXGMrFjxk 9I64M4YVrDJFhGYrKqrLEMtKjvYnHGA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-493-WW5JNNASMC-6n2QdVGZ2yw-1; Mon, 20 Jan 2025 15:14:14 -0500 X-MC-Unique: WW5JNNASMC-6n2QdVGZ2yw-1 X-Mimecast-MFC-AGG-ID: WW5JNNASMC-6n2QdVGZ2yw Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4361ac8b25fso26047675e9.2 for ; Mon, 20 Jan 2025 12:14:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737404053; x=1738008853; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kkNwxsqydWvbAxFVzgZ2uAaynW73vTt/6ab2/wVgs7c=; b=p/dj8Ms7RjMt7HwMaE8ZMOpINVvuYfBZBpPcdRvclKjHChMHqgtYaOmk+/gKQ0X/qk sMgRWIE2Ha1whr6sgiFDTRSxmaAVs8B0PFRU0lFJPoq9nI2QcpOz2lh8rCWLg20EeyJV H/pjyrxOupPgRHBWt1NYYRHI311lVWATzV+A1/HfmA9Sd6/7QfxCxfGVK8KuPws2cDxk DETiH2YSMd0A6k57wW/hyCPTwhYA8JhIN/xRL0/V018jTRwZhNyjA9QsrD5a/5GoabXc hgMWlMlzP2l7mYuKHO9ohBAM2CjXeuRmxcl+X+0qN3xYdunKQXQio+PjBStwq0+/sTaR vFWQ== X-Forwarded-Encrypted: i=1; AJvYcCWh0iArtlEao9Q4hBxG85YA653BNtRFZNYZ4NbpCKazVvZYmYWTm9+YXNMBzvqzaK/jMWjBbOeHQg==@kvack.org X-Gm-Message-State: AOJu0YxJgL73ctcM3nHhA371T6C8NoEHYX/9hDPFR5nP8JdeWnFVTb32 btkrHS1yQpkeIzJoONBjZdIrGGrHnRIseIHKPX0er1hScOUGEqthOCBoLGJUjVCOG936Cbk1p3T 7nArus5BtVUFcKSJPNlzc/avIyR6KBS8pZwiEwnzTN8l4U49k X-Gm-Gg: ASbGncsTjYQfphkpLaFkCFgizrFLV2mFp6qvOQM8Ez95P83jc/93h3LKOfOXaBwaOQ5 edvJ2Hu7+l62l/eMMElFZdEvVBo/R15hx56nN1I22/2frll5hYzBIoPGbzQdxja0We6ygPV99TF MLZPfRdGmtSsS3tmRjJZrmCiUo+B5L9rMR6x5/RJaDiSnpD6vNCwLH00xvuxLKNBX5NzTNNEanR lU9xuiHMD7I16mHlEcnLgbZE9KTnE/RdRHjZdUTIj8ZaCMAXhlML7NFLsKAs92KnDn/ucnC8uJz /3NxSvEQ83bD+aCIvT6wMsim X-Received: by 2002:a05:600c:4ece:b0:434:f609:1afa with SMTP id 5b1f17b1804b1-438913c6787mr133720925e9.4.1737404052805; Mon, 20 Jan 2025 12:14:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IFgL/lkKt4raraaoHGCSDAa+xHwDvPJvrvMeASXLZQn8ovxrmV9nEbCW/itGbaSAzv8WXsZsA== X-Received: by 2002:a05:600c:4ece:b0:434:f609:1afa with SMTP id 5b1f17b1804b1-438913c6787mr133720775e9.4.1737404052327; Mon, 20 Jan 2025 12:14:12 -0800 (PST) Received: from [192.168.3.141] (p4ff23481.dip0.t-ipconnect.de. [79.242.52.129]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3214fbdsm11636959f8f.19.2025.01.20.12.14.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 12:14:11 -0800 (PST) Message-ID: <4326b3f1-f99d-4be8-97fd-286c75358635@redhat.com> Date: Mon, 20 Jan 2025 21:14:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: gup: fix infinite loop within __get_longterm_locked To: "zhaoyang.huang" , Andrew Morton , Alistair Popple , John Hubbard , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com References: <20250120092604.3590285-1-zhaoyang.huang@unisoc.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250120092604.3590285-1-zhaoyang.huang@unisoc.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5UUC-aUsPn-zBmQvvJtseAh2fEO2Qa-fPC0QocVe6sE_1737404053 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0EC5B100002 X-Stat-Signature: f6683s3s4irmpp6gs54tbax5zhyy7wpz X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1737404055-639070 X-HE-Meta: U2FsdGVkX1+PH+CvhZkdibk9Ml+zEanEqpEd9zOoHJY59CZD/a0jYAxqcKa5+NH+MJJY+N8wnXrW5z2lQVcqfcyK1764KCWo76N/vvgIITss2CZwcEbPXsDtMYILn68LQIC+fZLyJi6+ST4Kgn+ptkrVZ5qMPJMDGKF8YdXavtcuKBpSwIN2zmWQLdsZhf/OHqGkXlsTJVjHRzHAeBqDt8u2sCrNWF3mjtoWtkXG88lBGWfM6MCiA0DDudG1VEc6a6z7ujCSQKGzRGpR+3qAlVfsWw70+e8X8sZeQl0/XRh7xAIJG2Ge1mKLm/L1IDEs2aJOd3F9V77xRs1zNOmuY6ybKcP9z3o62zG1/DhUBwOo2RQ9FND0Iy8Qopc5KYzf1S9Xg9ZAX2F6aXe4myIXqtWXpFyxGB0diGHByvlAMm9RhsqA7jzE9tApZ0anEz1k3sCtpLRQCZl7HalYGiqzT994MThsCwnVxDiPlINAFH8bbI/XJI0tqG0BHlkFX6gzYrhQ+mO1jJUFowzt8fw0LCjZAhBHFd3NV1YIC07rhiDicalF+mzqiGO9FdABYNmW7gJfdDzi7DuOq6wdSUQj0bkq3wJKxza4LbuRe5p0Bgwx7pGxnym7x27Pt3jiPtd7jDlM+y20NaQCL+Jurhf88JQiudz46qkwhClLCLuNSLechhujf+evK2H0sQk9sauoWHEXUA46cIUmCTUrkNSllu+aFnYnZ/SwkOdKAz0F22/an4X46ZALVxoVluUm523aR2IWuNOfet5339mJhoSoLm3D+UTCWKpNT9JuOCWhTC/0BWFWPYLiu9zR93b03dTEYCLKuAMdc+qELJHnzmtfv85knFp1KASfgwkICKMrVuwrSfHKh2Z5k6TwNxG0UIZrkC6CtA1gyucDgjBX/uo5mAJnZ+FkA86/6L4+E2PgXWDW5ObHhUIPQdOHRjlpGXkYO3B5US9aUrFRhCKgtWA ldpvS1s7 T2Qb+UD+tUqYCsY2Wuzg8hNwSEA2dxcROT8+HgascxS+ir3O41ocXNYyqHpstGn+lMUaJJLoARGyDLqlpIs0l4Ps+0cZc8SlFt2WkPF2hJmXEmHaZtflu17i1FC/XnubAUHpafLQMlj9fDueOx/ydzpKOrZujkKX5vVoacQ1dHse5Tje+yNgtiPrh81oSWVquEEq/HZsSC5uaL3ZDli6U0/PuNobmo013aBnGTaYxlR9gWnYRElVzmaNHeSDOWzREw1U2UGHHNa/5qo7coOZz+ORM91AcYE+sfe2RglykB6ByUnwV7GTA68RjnEU1/UDHHZxQ9iecubPzR1DjNSA19fOq6ayFtEIGkqbcIQM/U1ejoQV19vmB16RLpynNVp22EtahVQKv/H8amf16fMn0oINg/3XjFr8APWlVWTzvsZrWLG6ph/qWSYxzTmzi5Vs4VWjcGvkUEp4yok5Jo0nJjPQTIOTZmnTWrUKUqxeO6N5Mpj5CJXorCFdi3eR/1bUXSDJAT27evuwbT7JLxUf8vuKfzqb4UTaTa570NRhv76VK4rNCkhwV7ZnNXl9XBBBuz0pT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.01.25 10:26, zhaoyang.huang wrote: > From: Zhaoyang Huang > > Infinite loop within __get_longterm_locked detected in an unique usage > of pin_user_pages where the VA's pages are all unpinnable(vm_ops->fault > function allocate pages via cma_alloc for hardware purpose and leave them > out of LRU) Fixing this by have 'collected' reflect the actual number> of pages in movable_folio_list. Maybe something like: " We can run into an infinite loop in __get_longterm_locked() when collect_longterm_unpinnable_folios() finds only folios that are isolated from the LRU or were never added to the LRU. This can happen when all folios to be pinned are never added to the LRU, for example when vm_ops->fault allocated pages using cma_alloc() and never added them to the LRU. We incorrectly update the "collected" variable even if nothing was collected. Fix it by incrementing "collected" only when we isolated a folio and added it to the list of folios to migrate. " I assume, long-term these things will not actually be folios, but pages, and we'll have to skip them in different code -- or assume they can be longterm pinned even on CMA because they are allocated by the CMA-owning driver. > > Signed-off-by: Zhaoyang Huang > --- > mm/gup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 3b75e631f369..2231ce7221f9 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2341,8 +2341,6 @@ static unsigned long collect_longterm_unpinnable_folios( > if (folio_is_longterm_pinnable(folio)) > continue; > > - collected++; > - > if (folio_is_device_coherent(folio)) > continue; > > @@ -2359,6 +2357,8 @@ static unsigned long collect_longterm_unpinnable_folios( > if (!folio_isolate_lru(folio)) > continue; > > + collected++; > + > list_add_tail(&folio->lru, movable_folio_list); > node_stat_mod_folio(folio, > NR_ISOLATED_ANON + folio_is_file_lru(folio), What if folio_isolate_hugetlb() succeeded? The return value can tell us if it actually succeeded. -- Cheers, David / dhildenb