From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <43253661.3040909@yahoo.com.au> Date: Mon, 12 Sep 2005 18:03:45 +1000 From: Nick Piggin MIME-Version: 1.0 Subject: Re: mm-set-per-cpu-pages-lower-threshold-to-zero.patch added to -mm tree References: <200509120723.j8C7NhYe011583@shell0.pdx.osdl.net> In-Reply-To: <200509120723.j8C7NhYe011583@shell0.pdx.osdl.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: akpm@osdl.org Cc: rohit.seth@intel.com, linux-mm@kvack.org List-ID: akpm@osdl.org wrote: >The patch titled > > mm: set per-cpu-pages lower threshold to zero > >has been added to the -mm tree. Its filename is > > mm-set-per-cpu-pages-lower-threshold-to-zero.patch > > >From: "Seth, Rohit" > >Set the low water mark for hot pages in pcp to zero. > >(akpm: for the life of me I cannot remember why we created pcp->low. Neither >can Martin and the changelog is silent. Maybe it was just a brainfart, but I >have this feeling that there was a reason. If not, we should remove the >fields completely. We'll see.) > > > I think it is bogus. Andrea did too IIRC. >Signed-off-by: Rohit Seth >Cc: >Signed-off-by: Andrew Morton >--- > > mm/page_alloc.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff -puN mm/page_alloc.c~mm-set-per-cpu-pages-lower-threshold-to-zero mm/page_alloc.c >--- devel/mm/page_alloc.c~mm-set-per-cpu-pages-lower-threshold-to-zero 2005-09-12 00:21:31.000000000 -0700 >+++ devel-akpm/mm/page_alloc.c 2005-09-12 00:21:31.000000000 -0700 >@@ -1772,7 +1772,7 @@ inline void setup_pageset(struct per_cpu > > pcp = &p->pcp[0]; /* hot */ > pcp->count = 0; >- pcp->low = 2 * batch; >+ pcp->low = 0; > pcp->high = 6 * batch; > pcp->batch = max(1UL, 1 * batch); > INIT_LIST_HEAD(&pcp->list); > > Can you change pcp->high to 4*batch, to match behaviour? Send instant messages to your online friends http://au.messenger.yahoo.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org