From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8735C77B7C for ; Mon, 29 May 2023 01:12:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C5B9900003; Sun, 28 May 2023 21:12:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 774A3900002; Sun, 28 May 2023 21:12:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63CBE900003; Sun, 28 May 2023 21:12:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 511E5900002 for ; Sun, 28 May 2023 21:12:12 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1F9D9140384 for ; Mon, 29 May 2023 01:12:12 +0000 (UTC) X-FDA: 80841516504.09.531CA97 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf23.hostedemail.com (Postfix) with ESMTP id 863E414000A for ; Mon, 29 May 2023 01:12:08 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685322730; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ioZaaeqXcAPP8H61R6XDGypvvJtx55+n2C5TMm7oGxs=; b=xt+fEhJSc/iThmcK0qUlHNGTCqiR4/SWgENnMEPJYu8epbvA/iC2g+WnltK+wObH3UKVeV /TYBS80LOheZQrZhrtoR/9i0oTyr55IhaNOvIQGm805TaxqiYtGEmOU43JPxmpJ/q/EHqa tAeJxv9Gar0EofX4okS98F6o96zUYqQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685322730; a=rsa-sha256; cv=none; b=NUlxv7WWMib7YmPPYN4EfpeA86gNzfL6rsSd7BxCk6Sav5bK2Tw6udZGYglnde2HowinFi txH//sL9YzWDu4UMgD0HinBiJeR/UTPtMwPdeZBSIIliKVjBZWq6UampQ6W1KrYd9u460i WQoADzB/EnJ4GRzNPKNdbSbqu8tl6ek= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QTyDD45LpzTkkk; Mon, 29 May 2023 09:11:56 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 29 May 2023 09:12:02 +0800 Message-ID: <43226e0e-94c4-d74f-d1c6-82fe954fa4a0@huawei.com> Date: Mon, 29 May 2023 09:12:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH -next v2] memblock: unify memblock dump and debugfs show Content-Language: en-US To: Mike Rapoport CC: Andrew Morton , , , , , References: <20230526120505.123693-1-wangkefeng.wang@huawei.com> <20230527103222.GF4967@kernel.org> From: Kefeng Wang In-Reply-To: <20230527103222.GF4967@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 863E414000A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 5ymgmsmkxn3o4szz1ffucoh64obgzt3r X-HE-Tag: 1685322728-57750 X-HE-Meta: U2FsdGVkX1/QlQRrn1EeVdSK0/Dtc3O/WiNsE4285XCOxGksC9SwRnSL8YGatLTeaY/CDDvtyEIue6iivaGTrFyG69x+yljIWoGT9wLtjonr/FPUR5nuFLanoTGDMhjDXF7tWormtxblidWod/MB0PcFwpX+5l+S+YyRduKSPEQ8Tds1GvezS8Gq6uX7Fdbi6WX3h1NV0T8k2oZCRgWbYy5Eo2NVUx/MDO8uACm9UupokJp3M8iTsAnehFvv28/M38ux3VQxtbU6scvLuYlC0LTwLllvGBdpdCfkisURsJ9IJ8IHSa6Vqbae+72hm/pyyXVxeZW+f2vHSpljxzwaDxwKF9qAvII9vEcFyQ61yq2jQkQprLBzGaahjOdtf2O+F4K9x1fHIAcsHMFhoSxzcktBP9I+3afzc4vPQtgFht+VdLyYZ+mMd4cCwACen2TWxUvbWcy41gqax6eyLAj6yzpAdrsFvgfFhNfzhQXD1U+Nf2hLKncT2+emqY4qhJ5+SC2e0M4y3jyv3togvm43ake090C+chMYGsM+GVVP+KebIFTme1Fv54SuSG5+hIOqifHNhQTd0pSRDi9hiYV5MNMb+44EWMXWMI4Ep+q1WZohWr2VsWyUWK4Y65sTeMqXGdjJsm+7OzgrI/QmYGQut1CrHQ+GpyFKim9PuTWk+y2YXLu4ASO0+JX6FxNSGUvSl/Anp7pwXRblKhHgtnKnTRTCLvxEtZfMbfWDkobUjZPjYz4FTm/JauJUiM3msuXce+/PplF/AyY2AK+dnfhe1+58OnTA49bbnqaWl0Vk+7wFWGUcd9keQpNjpxUUWqQsT+RHw9L4XW78Y6qsWm4FwQIRZMAaHWcc3p8GSMl6tyheqCZo76fWNcTNuHBfMXhatkUCtoDdEcYHqV2JXUQx6iHvnG8e2GSwQTpdTnKz1znez/zaeGhAgjxXGGQRmzEQHe6kyGr76skgTnDw9wH 6hXEoajM nslDnVt0L8hPuT32Cje83FtzlFIuSlmIFe+z4izobUz0V26dANGMX74w2RRTALGjLX35argMedxTDfIfhVFWK4scOV/llQ1jBzulxDsUyYPxJv46iHfDpinMk5mzJM3H8Z7zCKXXduHWRgpsH8Ni9ar4zKZKQPrN4gadj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/5/27 18:32, Mike Rapoport wrote: > Hi Kefeng, > > On Fri, May 26, 2023 at 08:05:05PM +0800, Kefeng Wang wrote: >> There are two interfaces to show the memblock information, memblock_dump_all() >> and /sys/kernel/debug/memblock/, but the content is displayed separately, >> let's unify them in case of more different changes over time. > > I don't see much value in this unifications, especially as it must change > the format of one of the dumps. Although these are not ABIs, keeping the > existing formats seems more important to me that having a single dump > function. As the debugfs show is similar to memblock_dump, but not exactly the same, eg,the node info and flag(with/without name), we may want to support flagname in memblock_dump, also avoid more different changes in the future. but keep single dump function is fine since they are not complicated:)