From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 770FAC02198 for ; Mon, 10 Feb 2025 07:42:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 944476B007B; Mon, 10 Feb 2025 02:42:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CBBE6B0083; Mon, 10 Feb 2025 02:42:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 745BB6B0085; Mon, 10 Feb 2025 02:42:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 533156B007B for ; Mon, 10 Feb 2025 02:42:44 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8E16CB0223 for ; Mon, 10 Feb 2025 07:42:43 +0000 (UTC) X-FDA: 83103243006.10.AEDEBA5 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf26.hostedemail.com (Postfix) with ESMTP id 75B11140013 for ; Mon, 10 Feb 2025 07:42:41 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=uRPA5CD0; spf=pass (imf26.hostedemail.com: domain of cleger@rivosinc.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=cleger@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739173361; a=rsa-sha256; cv=none; b=qCSAZETynpMh1IJX56batTgqb6b6e4whhB8uTq9cVdedyEFVRK8JvDl4akU/5HssCJOTxO ouDSUZ0aSu9U5nTZJ9Es8P3uCgDHfYAg7HxCbPLcmC6caONuVeCBDTzawrPdeFoVD80ORO wCztNC5eHM1suHMRruA2qaeyiGcAUcM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=uRPA5CD0; spf=pass (imf26.hostedemail.com: domain of cleger@rivosinc.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=cleger@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739173361; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Jki0b2am8yzlz3QyhCDEFnMh6r+K6Xff5FC3zmcGxIQ=; b=aDU00BDLdLuBjfXEXRMtmRgby3KVio6Ckbl+I0KbT9BpfgNZ+ivw9irmaUneafsTFvmgoH 9+p4QxUCJKuwPryBT9jACUIAFRV1HjqN9LWmeysVmidoR0IIHOpLRkLQHyPjZIjq8LWdCw SOwxM6hrJ5b1AetsDGmAQUKauQDFMoI= Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-43937cf2131so7483345e9.2 for ; Sun, 09 Feb 2025 23:42:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1739173360; x=1739778160; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Jki0b2am8yzlz3QyhCDEFnMh6r+K6Xff5FC3zmcGxIQ=; b=uRPA5CD0NXSCYSuqZGtDR1tnurwaeKADZGrsytbkgHwJip3vn4ePA8FbmUA28TMAy7 7GLABoQY18mvDSEWOg3Qy2i9teZB1qR//TvncGvVsGm6H7/laXo6J3mpLJ+wx+dJ3vsT 6EN9BtT6TNeL0SF/9XQn9E7E8eEdSdu479mKQ/tfPQxr5hOi5dZSOzs20Lrni/TZlOCQ 4NgPNggdHlGMn7uHk9wAxZE/ys/Z+dw0wgVPwrIHlFr1sIYJbyTs9oSOoldjuPjjNmk8 ACSaXNsmyxC8QtR0YEYtcXv2qcP6OvAWxbIe0c6PrBNhAG7AyuyDvgvS+MOzavVm1hTZ Jk6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739173360; x=1739778160; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Jki0b2am8yzlz3QyhCDEFnMh6r+K6Xff5FC3zmcGxIQ=; b=KeRV7uKICAaTmckUfyJV7dLj4y1sy3x5o+iWhEYvvM1N4DoTb2Edb6PAA7dkiF7YKc scfEb8EyNZww1npcPw8S/nMxwb9MmCNlLrZmbr/ChgiyvBmdK1E3wfr312HHDuL1wjqn Plj35ud4jDx83s2xsHZ/EcPlazgdZkTM+uI9QquXCwvQg9oxkr8EcVnbW+qKbD6oU597 1oedFHgDZmzPsL7vI3xZjcACGQckuAJmpClPwThSROA6j7caamEhS/Pj1pAeSGAY0Z6a khdYOIv+UWFX0bjRBs+fZYU44f7vasvvD2UQ1ZO6C7wX06gdsFbPsV5tjaFnGbUDfarr nr0A== X-Forwarded-Encrypted: i=1; AJvYcCU3CbKODGj8UTCU7xuRSQxUZU/MJYpyXsEt08HyLUxMoGgheTJ/edfl9J7w41TSTDa1JKB9MmtCGA==@kvack.org X-Gm-Message-State: AOJu0YzNM8jdDdAasztw3pAAhgJR4oCFyEk9jTWNkhMgMeKxd+XGsZU/ rqB2Bdy7589T2aqUDU24uRSqlPmXF6xMtFRzz5oLuleQoPsd8IgauA1Nw3UvmvE= X-Gm-Gg: ASbGncuEK9PiqS4viZtSQ4/IRBusXiQ6GLwcSHrY6AI6GdpwPGlYEU0cK+vEPyTB/NV YjT2ppC0ZC6n6t0NbDcaQkfKYMuKVcditcRDR4dXt1sbSwv9P8C1fsGCSGD8jD8jN+y4/unJAwj dfCZFd25sO+9qtoivbZPbSEKGWgLshGnjXXqXYYsIjv9oHuvHXu0Ls0hI4jRcYDPtEkAL8LiyFF 7k80QZOcPLTV+uXHgz7E8yDAvxBj2OUsMCZrxfvKg2yzyvNNHe92D8h1lzu4nqPfucjELRaO5rc DVuayM1wkOCf7PIMryeYmdPpeJ29RDJElcuWGQFZBfKw6Rnm/h4EXikIbhdN X-Google-Smtp-Source: AGHT+IF39BdEkA9ZgcBIHbLRArZRwyqYfhbYwkkcPtQvR89C0KQhk8Xnq25iZkfcHIflDsp+ppJQFw== X-Received: by 2002:a5d:47ad:0:b0:38b:d7c3:3768 with SMTP id ffacd0b85a97d-38dc90fdb89mr7501603f8f.12.1739173359748; Sun, 09 Feb 2025 23:42:39 -0800 (PST) Received: from ?IPV6:2a01:e0a:e17:9700:16d2:7456:6634:9626? ([2a01:e0a:e17:9700:16d2:7456:6634:9626]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4390d896d70sm171375435e9.0.2025.02.09.23.42.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Feb 2025 23:42:38 -0800 (PST) Message-ID: <4320b0be-acce-43b2-b148-1577c6a56dff@rivosinc.com> Date: Mon, 10 Feb 2025 08:42:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 14/26] riscv/traps: Introduce software check exception To: Deepak Gupta Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Christian Brauner , Peter Zijlstra , Oleg Nesterov , Eric Biederman , Kees Cook , Jonathan Corbet , Shuah Khan , Jann Horn , Conor Dooley , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, alistair.francis@wdc.com, richard.henderson@linaro.org, jim.shu@sifive.com, andybnac@gmail.com, kito.cheng@sifive.com, charlie@rivosinc.com, atishp@rivosinc.com, evan@rivosinc.com, alexghiti@rivosinc.com, samitolvanen@google.com, broonie@kernel.org, rick.p.edgecombe@intel.com References: <20250204-v5_user_cfi_series-v9-0-b37a49c5205c@rivosinc.com> <20250204-v5_user_cfi_series-v9-14-b37a49c5205c@rivosinc.com> Content-Language: en-US From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: u7z9iab4iyr8dyitr6k7cndmfzg6qg99 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 75B11140013 X-Rspam-User: X-HE-Tag: 1739173361-239190 X-HE-Meta: U2FsdGVkX1+rmI5f4vVUETrSSmlNh3lYyP3Iowfg303KSBs5obrNDm5RZg9E/xo8xvThks9ficBK3FdnQhlVeB1Tn69AxOaBUIXMnZeV7Fg64lVFoT4vt8TwwqQxft5PzJr1vO/UXP69BJwiVM/n0FuM9ehcnZMDDuVvamt7CWJZKrwI6AtnM0FojDQGnMqV7VlU4RYWk88TWUJ1gTASMe7Z7ohcXxufRN2Q7Iz6vEQW6S0CJRFX52jHEwdPdNfXnWhFBygBM0+wEgte658aXGNFyP4ZYIqhAb3CKX55sz2kI5p83LFmlgwGPq15iyhJKfTekHhZ3ltLVnTgW12MteuQfBm5I7M+9CMy5CwoT2S/m0gbhCwvB0RrRO9+L0X2YeVqO5G3Yj3kpX6s/jvp8rXbGivu+JZ/21z20OKKdVAa5KXR85eSL1Ls8YAdYa/P7P/WLuel1yWlbAeHbNHEjm/tQLP4aMEGlJjih4Hxek5Samoj7GUq8/OFdlDdH7H0Gv4YlpBTiXLRDPM+Ud+TXgHmO8oYGsHle8xXTXACFDbVnZEG70iy+Uisgk1VHEZrcV3An7zN8veQci5+FIerSllBKiBXg4yUc0T/pzvAPswXNjjgxAckpuuWOH332E6ZbNBGhSqL4wGYkOd1eFIvr8T6OKgpyHFGVKgo+3zw/TYSyxZgH6RlQanM1yG6zIJnf2N5Bi/9ts+omkqxXSzxRpdqZzTn81Q4TL+sYvV/2++CR3OtclM31/JHkYHyOTgkndneqDvr9tqE4zjaq0kS1etaY5imZEigGu/5G+3P0yG+s2hOKzfz0hIO1XXMirL4zJRqHvMXpQn2iHl9OXWNByq29R35CryDuOJG+zuJupJ2Yh3UOGC9zmgR5BuzhQqB9z6oqCxyVMXIvROByjbpeKGdmM1+5wkqvxZmHySKIT7YkkJaSocuffRMAz1iyjoFrM/CVVxfJJBl/mxMHr3 xpfTSAF1 Ns9A3k/BgQQcG6LjjfSgkn24EbzrtY2t2xOudQ8W8ZqQJy58yZmZCUP+B7WcM2yP8tPNqA0QgNqaniCSP1rnBPqVs2fyg3Ub8ZLUdPJssMDZNV/VfL2YkLIkc20trjInMio9qu5arL+r2UquKy6qrPkSLxzxw21afQP5/CTbuRUVRlCvhdhtIrUnh+eg8bp2E58z4sxA1E10nSkd9KJKS+T5Ss4C77sEGp/Rd55lvkGsKXws9cFRVn5WrbrIECQw3wGY59enKqjducv9c4iPzwtk9XNx4KrwUbJCzlogOZid0jfFttXznbfsHOYU0+1Q0F99fsatPmK+q1ubTKNIjJZXbq4hHeJ10B464oEOxvAihjdWxh4RasVfshZU2+khJ+QnmOsDnZAkoATDatIcdQCYaXveNyZe7t/SkCJLrPOrnpySECqrSNegPnBNPx+BkYSHotrS93iFdKcj+70z90m0nW/u8mght12wFdP9gQZlDTyQo6njS9GSmsqXzWZ6/TDwqIApttvL0JcHJ6vRD7Sn7DguIs4ngHO2lUky5dL/Q+rifcDebqs0lD6IOkAtL6+bUAAv8+s+tulvzT9+gYTubi66esr2BQwz6qC7QNjl/A9cd5cHiNH5x8NxpIlxsmywA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07/02/2025 22:26, Deepak Gupta wrote: > Hi Clement, > > Thanks for looking at it. Inline > On Thu, Feb 06, 2025 at 02:49:09PM +0100, Clément Léger wrote: >> >> >> On 05/02/2025 02:22, Deepak Gupta wrote: >>> zicfiss / zicfilp introduces a new exception to priv isa `software check >>> exception` with cause code = 18. This patch implements software check >>> exception. >> >> Hey Deepak, >> >> While not directly related to this patch, is the exception 18 delegation >> documented in the SBI doc ? I mean, should we specify that it is always >> delegated when implementing FWFT LANDING_PAD/SHADOW_STACK ? > > I don't think it's document in SBI spec anywhere. Should it be ? That's a good question ! I don't know the process to document that part of the SBI but that would probably be nice to document it anyway I guess. Atish may know what to do with that. Clément > > > In code, opensbi delegates the exception (SW_CHECK) > https://github.com/riscv-software-src/opensbi/ > commit/110524441a827e026db3547ed03c5723b9c9e211 > >> >> Thanks, >> >> Clément >> >>>