From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6FFCD42B85 for ; Tue, 12 Nov 2024 14:22:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5592A6B00F1; Tue, 12 Nov 2024 09:22:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E1C06B00F2; Tue, 12 Nov 2024 09:22:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E6CC6B00F9; Tue, 12 Nov 2024 09:22:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0E8506B00F1 for ; Tue, 12 Nov 2024 09:22:57 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A943DA01EC for ; Tue, 12 Nov 2024 14:22:56 +0000 (UTC) X-FDA: 82777659132.28.1FD9E08 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 240FF20027 for ; Tue, 12 Nov 2024 14:22:10 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fDuEfDkM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731421287; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ih3h7sj3/PrQh5CHmukyEc1uZxk8P4jeW0tJ5ye/2l4=; b=PjQpj11L0rIyG4NaRuQ2sQ6Wjsqvf6WgU7n11od/gR/xqj7Q02tZweIJO5hDvI+JaKAT4w rv5vtPy6j2cqio715yVl1BSloo4ME/vC+ELVzwN0ayssUPYf/nnfhthhiZSqRMTmPTqqXX WYB+8XZGrzQ+dfBSy9MU09W9qLp94xc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fDuEfDkM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731421287; a=rsa-sha256; cv=none; b=Ri9LDOSoLdXCYd0cIWZIleDRvDm1k/Lq08v495i/fg8GDt5aM6nC4584nHYbrEnHVVJID0 Z75AwDBujATMwh2U82MpbMC1hDRi9gBS0t4rm1HkucDplMtUA9wF1f9RebOu7GPslNHna6 DXP5BbsKj/FIGtFRlTjl1vcklVfV5Fk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731421373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ih3h7sj3/PrQh5CHmukyEc1uZxk8P4jeW0tJ5ye/2l4=; b=fDuEfDkM+LYW8Gw4tUKSVWgraXcWKW+PJNhvt94BJXoOG39tBpDKJrfj/ZpNeZ/EjRBYRz ne+y2U1oUaHZBG8MJ08hvagNWJffJUGFtctUBEL6X8TH61QvuVGmI4hzMkDQl6enWmkPVO qGnJFgNFPUthSyeF9srr+AYsq4TA/tI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-283-q89kOPRpN0qDcrGsHR2Usg-1; Tue, 12 Nov 2024 09:22:50 -0500 X-MC-Unique: q89kOPRpN0qDcrGsHR2Usg-1 X-Mimecast-MFC-AGG-ID: q89kOPRpN0qDcrGsHR2Usg Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4315f48bd70so40612825e9.2 for ; Tue, 12 Nov 2024 06:22:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731421369; x=1732026169; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ih3h7sj3/PrQh5CHmukyEc1uZxk8P4jeW0tJ5ye/2l4=; b=SAjWFWj7R650t96fJZFimGFEwxn8l5tiYlqtEOFAZTpEkEL52NijthJLdxThim8xC9 UkTZh1yzKIenPZFPKFkeC5RXZEIBFKIPrjBhYXXveulT6UybF+Svtjdz4ZEsHp28q9BU 4JYhExD1faeGNdnavIAUg/u0tZNqCiDXydoPX4hEWQeiXZv22rk6xUwYxUlWsY5/e1Qi q8s2yZtsN8eRBn/WwkYfxkeoSo7mY6iVP41iexstmEN9VBL0qEFgUBx2F3UpzladwETH 4MQoC4QToGj3N/8PzfJgEAoxn2u2CV6edTKNnKxukzz0kB5Ceromz7qjK9KO7nz8RwJD uheg== X-Forwarded-Encrypted: i=1; AJvYcCXEuelDfD92wNz0qSugf8L95jA0nLr8lVXMv+URFt6IgKVsDVW+fI61ayAoUBbImHyUBFXQpsCOdw==@kvack.org X-Gm-Message-State: AOJu0Yyp6cHUm8VlCSNpgbmN1nf+02gNYE6CIZc0L764pjzepiBEVCFp S1w6hklJQg86JlIegfNsPg9fbymktGK9lnwuW1Q6T5kBKZa2Bdm39bkKpMtOKKQ6doS5wOosy+z xGT3lCathbGRZNAsJa39FATLUa6c85ObUhR1QSuc8u8A9cNBqaEYGc9sw X-Received: by 2002:a05:600c:3ca0:b0:42c:b037:5f9d with SMTP id 5b1f17b1804b1-432b74fd71emr143890015e9.3.1731421369192; Tue, 12 Nov 2024 06:22:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IH59gtj5JuaEfqGVlrZNoO+nuZRVjGPGhZoZcwaXvNihYJ1LG3ikeJRXAg5sAwoquW2Wr0J6g== X-Received: by 2002:a05:600c:3ca0:b0:42c:b037:5f9d with SMTP id 5b1f17b1804b1-432b74fd71emr143889835e9.3.1731421368855; Tue, 12 Nov 2024 06:22:48 -0800 (PST) Received: from ?IPV6:2003:cb:c739:8e00:7a46:1b8c:8b13:d3d? (p200300cbc7398e007a461b8c8b130d3d.dip0.t-ipconnect.de. [2003:cb:c739:8e00:7a46:1b8c:8b13:d3d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432b054a3ebsm209649235e9.12.2024.11.12.06.22.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Nov 2024 06:22:48 -0800 (PST) Message-ID: <430b6a38-facf-4127-b1ef-5cfe7c495d63@redhat.com> Date: Tue, 12 Nov 2024 15:22:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 00/10] mm: Introduce and use folio_owner_ops To: Jason Gunthorpe Cc: Matthew Wilcox , Fuad Tabba , linux-mm@kvack.org, kvm@vger.kernel.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, rppt@kernel.org, jglisse@redhat.com, akpm@linux-foundation.org, muchun.song@linux.dev, simona@ffwll.ch, airlied@gmail.com, pbonzini@redhat.com, seanjc@google.com, jhubbard@nvidia.com, ackerleytng@google.com, vannapurve@google.com, mail@maciej.szmigiero.name, kirill.shutemov@linux.intel.com, quic_eberman@quicinc.com, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk References: <20241108162040.159038-1-tabba@google.com> <20241108170501.GI539304@nvidia.com> <9dc212ac-c4c3-40f2-9feb-a8bcf71a1246@redhat.com> <20241112135348.GA28228@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241112135348.GA28228@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: eqdIucmI60mB_FRb1CgAJUiatRtV48yUPCiLaYN0XCQ_1731421369 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 240FF20027 X-Stat-Signature: bwadaf9kh3eeep9cyoya4pz9ey6geydb X-HE-Tag: 1731421330-973027 X-HE-Meta: U2FsdGVkX19PFsJOvRPHm2gbaMWbO6dY8er1vwvln1MngjKcgtT91G9brrnYyO6FzwxTFw7QQHSWKxfvTJNR8s1XYVJDiq+7Mp0t4yqYEW7lUfFY/blzRoFzigEu9Y5X2RrHJfK8mK0J0y2Xo6vjeE7tB50McfOskaQy+c5iTP6Ou8qSUGrJmGOFXRhozMl+YHDx2w1ERzukxHbIbRG5AUMJGe0VZV/ISsBPRM2XjSNRhEqc8l7H2kqboMAEVk0FBsk4HqgoIF9PnWqKVOrJXaSmkokHwaHDoMbAWr35iphKobjD+Om8pZhneMil3GlDvL4Q9WTwEpNMEghGo/moDn3CEFmnpEB67KI0tDOiJ7KhSxdxLBrIBb/Xp6JRkyM82VSsMAXSyn+urR4GZBp8yRLXnPFvSfS0su35m24XbG/TCfi7jJaIQttwqxdwfF4WBJYf+W2GzA1Yat7Npjl8Jl+qWgsbYj1Oh66yz7tzpKlFiNRt82nOgc9NrdvSSW7Y9Nh+IsHNbniNg3MTYdtAq3g9l3ukPlY90a0tLGISU7NNADp8f+UNUwIz/XEqHQ8fspSFFQYdVmUMwM+zunkRLCBU89Vy4H57jHxfTKPXAodTfXmhukBK3JmFoaYS7IvWjj13Oirhws6Ze72PfgXgDzI2O3nlCoulh18iDasBfvnLCPk5ls5TpZn+9DRfLIX4hhlCV/aA/0e4+S86/9CtQQWOCfW2nCDvDbvfw7RAQly/S1sAfxBZuJAbc3ZYGyeSC5351+xwUgCrG8KAswFEaScNeW2Sjb9MmMeNWoiLPLKUhxLv0K8FukqBhi/hY/hpmAjBMFeZPYOWx+E9u4fTegRnOAxFRrorqSpeBlurTnKiR/fv6mo5BONk76pnQPl/8ezCi8xEyAIHCUuEj3rO6CCYwavXKLzvvth/NErZ4sWXvUKKfTgK+RqHiTdJkgnj/hLOlq/2nP3Jq8PABwn x3l02GcA MBgGUUtoTVp0O5y7UHMFueUgsG+V3AuxhSijHyHpXD0Tl5A0E77tMzsc3yrK1LtlsMyQ4BLzaCfrxWHv9QkODua4BjhVegNasX7uCz1yHLdD7qEz8ZIKvmvshyhKjXJ0VVRVLU6up7KTL4hMddiESUQSsTuARCWtjR9ZHc1cNY4BotwGA9NpCMoitSLhBfGnmQzIqxJ+qkzqFZ+h3bUg/S/BI0o+166vlaxfuUyweZgwGFkXXNspeT1e0Sw+eUFDmR65nO1v/rJYYAJQvqHY6Mb8WgWPBFuI6h4RyWwad3dOofwZfNmrrvDqJ81y9IOtCDZXJSorWY3PQAiuWT4lS01+yK8YoSMy9XJy7KI1V5B0NwiLAHD4PzhEbj3SvtmqiaB7ihJTt7dm86nUR8B0zRFoMUDIrTHk3JmY9BWpQSkI8B0EjPhghFgB58ABCfIKqInn1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.11.24 14:53, Jason Gunthorpe wrote: > On Tue, Nov 12, 2024 at 10:10:06AM +0100, David Hildenbrand wrote: >> On 12.11.24 06:26, Matthew Wilcox wrote: >>> On Mon, Nov 11, 2024 at 08:26:54AM +0000, Fuad Tabba wrote: >>>> Thanks for your comments Jason, and for clarifying my cover letter >>>> David. I think David has covered everything, and I'll make sure to >>>> clarify this in the cover letter when I respin. >>> >>> I don't want you to respin. I think this is a bad idea. >> >> I'm hoping you'll find some more time to explain what exactly you don't >> like, because this series only refactors what we already have. >> >> I enjoy seeing the special casing (especially hugetlb) gone from mm/swap.c. >> >> I don't particularly enjoy overlaying folio->lru, primarily because we have >> to temporarily "evacuate" it when someone wants to make use of folio->lru >> (e.g., hugetlb isolation). So it's not completely "sticky", at least for >> hugetlb. > > This is really the worst part of it though Yes. > > And, IMHO, seems like overkill. We have only a handful of cases - > maybe we shouldn't be trying to get to full generality but just handle > a couple of cases directly? I don't really think it is such a bad > thing to have an if ladder on the free path if we have only a couple > things. Certainly it looks good instead of doing overlaying tricks. I'd really like to abstract hugetlb handling if possible. The way it stands it's just very odd. We'll need some reliable way to identify these folios that need care. guest_memfd will be using folio->mapcount for now, so for now we couldn't set a page type like hugetlb does. > Also how does this translate to Matthew's memdesc world? guest_memfd and hugetlb would be operating on folios (at least for now), which contain the refcount,lru,private, ... so nothing special there. Once we actually decoupled "struct folio" from "struct page", we *might* have to play less tricks, because we could just have a callback pointer there. But well, maybe we also want to save some space in there. Do we want dedicated memdescs for hugetlb/guest_memfd that extend folios in the future? I don't know, maybe. I'm currently wondering if we can use folio->private for the time being. Either (a) If folio->private is still set once the refcount drops to 0, it indicates that there is a freeing callback/owner_ops. We'll have to make hugetlb not use folio->private and convert others to clear folio->private before freeing. (b) Use bitX of folio->private to indicate that this has "owner_ops" meaning. We'll have to make hugetlb not use folio->private and make others not use bitX. Might be harder and overkill, because right now we only really need the callback when refcount==0. (c) Use some other indication that folio->private contains folio_ops. -- Cheers, David / dhildenb