From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 738ADC71159 for ; Mon, 16 Jun 2025 21:20:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14D066B008A; Mon, 16 Jun 2025 17:20:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1246B6B0095; Mon, 16 Jun 2025 17:20:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03A656B0096; Mon, 16 Jun 2025 17:20:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EA2A66B008A for ; Mon, 16 Jun 2025 17:20:02 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 85FB8C0F46 for ; Mon, 16 Jun 2025 21:20:02 +0000 (UTC) X-FDA: 83562531444.02.FA9E78B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id EFDCB40002 for ; Mon, 16 Jun 2025 21:19:59 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HDczuUwh; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750108800; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pG2ILtb+J9lYqJx2KBiTWqoasR4qPHwzEfVGOfGLAN8=; b=aTcfevklqBSQxudeTcj0IIxrDT8iKTN6vb9sZOLImhDm6LY7c4YQ9jKHdKnRLx4grNC3wH mAC4gHD0SsQ0DEDEiY2pKRagez+EOgz20eCq+l2edgMYFl54PMFcZAnZ1rmlj7YR2k287I /q2SbNqhJqBQf7jhcfn8Z2mSW39zlz8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750108800; a=rsa-sha256; cv=none; b=i40CVFD9gGApFLOP6UOGYqa6CsEBkONsBrItEc7t1QIKicnWy/7IgVuhyy0U7HWBg3zmex cykPdK6evD4qz1AEYooJGfZ2tGRsYMgHUBCEyHxR6IL1lla+fQBWqyy6zXjZw8TSixY3xO Vk9lUopcdjc+1FqRh1F3skC62x/WcfA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HDczuUwh; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750108799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pG2ILtb+J9lYqJx2KBiTWqoasR4qPHwzEfVGOfGLAN8=; b=HDczuUwh0Sjgpw3I6LIdJGB3WK7JZvkn9TNo8Fqw8Ron17fUMExRjCa9K2TxRnSkcXrBAi Aqd5IH8SX416pj2ifkfXtxzW4gmnk9GLxrkjwAGZr4h62FiFf940e6fxp56eEv39eJxU4r TRMggvuLBYnKwnKrYE4VdiR0GzXjAvI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-PAVej6ACPtaAlrSBZ_LN1g-1; Mon, 16 Jun 2025 17:19:57 -0400 X-MC-Unique: PAVej6ACPtaAlrSBZ_LN1g-1 X-Mimecast-MFC-AGG-ID: PAVej6ACPtaAlrSBZ_LN1g_1750108797 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43e9b0fd00cso584995e9.0 for ; Mon, 16 Jun 2025 14:19:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750108796; x=1750713596; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=pG2ILtb+J9lYqJx2KBiTWqoasR4qPHwzEfVGOfGLAN8=; b=b80x6wGrGe8cKtpp7g/Ed6u7l9ifWbZk01iEuNPrCeNi7p9iMEX3GXeRhwgIvgjhTp k+M7oj3xC2RFZE4LLJUv5Cly8BKngSjag8tjhl3eRSVYZG8/n0GzJ3WKWA6laLjGs9zg 0onTOr8J7p07ETlvfjTQmhhf12VD4DA1sFo36tsPz331uJSnd/6IoK/l7ShUwK74m6Lw vLXS01W09tS7vq4IEHEycbimUN6OF3DrJKJrVrXIDawxa6QbyC7Ny73uc8h6CkwHG8zP 4g0Qtp3uAB/9tRthoF1AR9GGnvw5imd/odC/rp6QDgN8Lj6/J/1aV8ggA3xhzOQOGYAt Z6Aw== X-Gm-Message-State: AOJu0YzGYmavC9d/QPvIx/GUHkuCvgBnZbHKYykoLpx/cHNwA936t5E8 6rfyqsIqgkMlsM3qIHFj9QwPjjP6MydNsC5VNDaqh/Js2yrdfwt2mii9nMevxEnPevb9OUI0+t/ BHFMM8sB25tCOIMdJusSmXV0+oBu5JecqUkKYJO6rLl9OyvAAp59ZRO/N2/l8V4c= X-Gm-Gg: ASbGncuxbPsEtf6Bsa2TBjx8FCblMwOwaq8UfKHYS9Z3u4bPuW3hZQ159UvT/ljRvSW ZiE9bi10KkyHizcaR5sqAwV/Ke5c2byv5DSxEZRJkO1U4/5V4714OzmCGgGUIjlXSTEinngt95w GfsazJeantlx2xCbQrljBqitQRFqTDDqcZsBr14hUuHWD3cJMKlrmKEAq7sfO/8Ozdn+Z5J0x4X +HOdtxZmJJrXibm/K3+gDFTF4Vwo1HtydIb6ih3G1tzH1KiTwxCpA/e/ayEHXk54LWEW8FOs3Nv pv2HHsyQRJLeNKGMQ1/QjEbnw52RoVxlfFnpX88cDMSdrhWl5w3QBdsETQLb7Qg0ZkQYwD0Hz3e t17DzSn6YQDGwxiuKpwXTyeY+QIMp4rPouYZV5V2+1OO+ClRV0Q== X-Received: by 2002:a05:600c:64c8:b0:442:d9fb:d9a5 with SMTP id 5b1f17b1804b1-4533c92e02dmr101047945e9.9.1750108796564; Mon, 16 Jun 2025 14:19:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFGMbsWUkLIImya69M6r0LDQIWFSkxmEh8r9Nidg4NJ9+vhoaH++D88UEYplTuVKgag+IEV6w== X-Received: by 2002:a05:600c:64c8:b0:442:d9fb:d9a5 with SMTP id 5b1f17b1804b1-4533c92e02dmr101047825e9.9.1750108796172; Mon, 16 Jun 2025 14:19:56 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3a:e300:c660:4ff5:5bfb:f5c5? (p200300d82f3ae300c6604ff55bfbf5c5.dip0.t-ipconnect.de. [2003:d8:2f3a:e300:c660:4ff5:5bfb:f5c5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532de8f2e0sm153421085e9.8.2025.06.16.14.19.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jun 2025 14:19:55 -0700 (PDT) Message-ID: <430a76d9-5885-488c-9ab9-c0e40fce95c2@redhat.com> Date: Mon, 16 Jun 2025 23:19:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] secretmem: Remove uses of struct page To: "Matthew Wilcox (Oracle)" , Andrew Morton , Mike Rapoport Cc: linux-mm@kvack.org References: <20250613194744.3175157-1-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250613194744.3175157-1-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tLXlRrNmJfV48jtvLMNIXS41uwo6bQHKMomGBwogzD0_1750108797 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: EFDCB40002 X-Stat-Signature: jg89z4ybcx3cmca1dhz1cpcd3uojdj7m X-HE-Tag: 1750108799-873412 X-HE-Meta: U2FsdGVkX1/3bT3kxphtfbZrDiwvpDpzsp8GZnb+aUit2uin4fll4/CUx3mt+5h64FsxEskSwaHMrSP4CmmSDiT4v8kO4+lHI9mCbtttoKw7nKELE1r+LPe6UM684HUxvlM5cjmVp7RMAsowtgtnUtvW4sbHvHpz04cRLBXgElCDfZA/oGZCh6a9UkQ1f2n+duyU7gZdBjNTSt9PWtIkw7eMWPNdiv4LjeCaUZMiiwdP3/w73xuKJy6emlrr0Lz6OYKV+rdlOBuv+R1WCDGHWV8CfR9e9yAXkEqkucpmnh8HaZPawg5m8DiV7lwyPTSprWwOACnV2qfqkH9N82wNE2FziZnW6hHD2YX5XGqBJhnpMOsBEEkkcKmAngveoyK64EOnSZ+GtAAWTaK13mPPz+XXuaBLg98TzmmsyE7l2E5mU3VzL1USxPUy02YLwxw2y+1fFh1MzsiasSDHZTQMfqwsEsAw2askfbGUs0qhaYRu3Xq5Pvhnqf/M5H6wnkYpmXIUQXofVXVr8r6TBWbQk8GdPQF0BwnovzKXsT5mArxyZcLIXrnCkEvraTgBySG4jZm3g00MaoOFkvIZWtP6VCuBG4nt+viGED9cpa50Yo5pYMsGtHayVKMN1FU6jmjqRugNVmELpHCTZT9z3H2z3fLjieUBWUabQhswVSKiZtTAiVF1Z+ME8L0YYI6gP6192/lRnl7/oHEMrG2Yh3ena6cacGQtDmMykbwfMH3uEypanxV9evd9MbhebJiDKSh8jpRPy3bJPcdkmQ13j2N0Ltvj03hgMQ0Ii75rgCtVWvt8uMF6F4LgF1OhUUCDCnE4V79oDbLMUPsAuS5LXalf4NgzOCD92s65vVkvOiv19Xfat8mhCII9mNcb6BpEjjCVwJGXlZgZqSfTk9OcXekiZJwVnm64vOVpjL1NZYcJjUSqEezRf/Id4XrfLXXSGDJrwWGIMJrX/43BDJ799n3 tc1mJtK1 VbaTcZMj/h5xF6Qr4xDUg/b5ySTk7vyn0AXX7+ZZJFMC1Fggl7q1d4Sd84gVwfgycwZXNQ4o6GVXD8ZXE7FuTZGOTPTUef6VpIdtCUjO3KDpT4fcLV4MkFDdQXq7bTC/5tGPppjvb2WKkmCpAgcHSrUSMhHxvXKE6DDEH0Rk3iqUy9zNSovxhKAr62qZNZugsxpR5KVJhEsRfntmWScsGl9NLEsEYNg1cYG+grq0355gj62B1yskJBzGSbjGut9FWN/UbdpsyX/RLIN2g+AAkPO++ZNRESW7CRXVdegKG24JY92SP5AowsEK7k8LUzglGK0jJ6ATbr3IWOzx9y9MrKn0+4jX6cJQlWBJ86D9oTDv65uJM3VBIJ4oTKPzq2KUjP4tZvixX5/4M3OKWdcslTexNCgJUO1dJqs2l67qCeMs2eyBARTOqrVicolWVGvaTZEGCG668rdR4PsJw1ykBjm8ywHi67Aobip2uGM/O62lf0kOzvWdI/dvXKDLaUVUDzC1puTz/xrWK1HVy9z5UexkJwgZBq+mUZMGkh5CGVZRF4Gzc1joLU/s/Qy5ca/MYvgyTNgceYDlBaCU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.06.25 21:47, Matthew Wilcox (Oracle) wrote: > Use filemap_lock_folio() instead of find_lock_page() to retrieve > a folio from the page cache. > > Signed-off-by: Matthew Wilcox (Oracle) > --- [...] > > - addr = (unsigned long)page_address(page); > + addr = (unsigned long)folio_address(folio); > flush_tlb_kernel_range(addr, addr + PAGE_SIZE); > } > > - vmf->page = page; > + vmf->page = folio_file_page(folio, vmf->pgoff); We only support small folios -- see the folio_alloc(gfp | __GFP_ZERO, 0) -- so you can just use folio here. With the fixup from Lorenzo Acked-by: David Hildenbrand -- Cheers, David / dhildenb