From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89E72E7716D for ; Wed, 4 Dec 2024 10:37:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1857F6B008A; Wed, 4 Dec 2024 05:37:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 10DBE6B008C; Wed, 4 Dec 2024 05:37:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA2096B0092; Wed, 4 Dec 2024 05:37:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C54C96B008A for ; Wed, 4 Dec 2024 05:37:34 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 57CA81C7827 for ; Wed, 4 Dec 2024 10:37:34 +0000 (UTC) X-FDA: 82856925102.29.D9B25CE Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf10.hostedemail.com (Postfix) with ESMTP id DCFF0C0002 for ; Wed, 4 Dec 2024 10:37:25 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=PuN98DUy; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=g89b5sOW; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=PuN98DUy; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=g89b5sOW; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733308645; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K73vwuTPXhdyfDtN2FMm4N+WsimSUFdkNoCVg0ZPQG4=; b=gL9VwhLYBlcqHL2n6CPrmQbDCOU99j8rcMYNLJin+RO+siDNwvAVuoTCUBm9UGepGAVsKb gB0fTRrXli96EYw93mfU6UUe3dHushtUnfTOEwBmVIDybzWOjlMidNXpzpKXyLJSf9pb+h X+2Ssu5Wm8xgBhfwr1o4JfEAxDo2NO8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733308645; a=rsa-sha256; cv=none; b=nTrDvB7sWQScMHxZJvMnPfkUrHVI/IulQCcWRaCwObEmRcePw1Jty7mR0iZrIIMbCI3ucw rL80XAba4shi9HAiQukez7SwC1bvJatVjf4rV1Tt0DNIXCsxpIkiwWdAtDncJRp2BTb1In eVBvARPE5sBSR5S4c6d00qZqt0aduME= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=PuN98DUy; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=g89b5sOW; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=PuN98DUy; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=g89b5sOW; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9165B21111; Wed, 4 Dec 2024 10:37:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733308650; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K73vwuTPXhdyfDtN2FMm4N+WsimSUFdkNoCVg0ZPQG4=; b=PuN98DUy/p+Qh2k8Cb9d3mL9J1I07e37QGntqZbYAITDtW8N+Bh+tqUuXnW0UKR1un5hjg eI9egrlzPV1J4Kq9pOt15K2CzvH5uAtnsvvcHkT7TnBDeXKUyvS4U4Ky2IYm1hvE7dwavQ IX62tLqOd0J0kPgDyv5HISiH7CbvQOI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733308650; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K73vwuTPXhdyfDtN2FMm4N+WsimSUFdkNoCVg0ZPQG4=; b=g89b5sOWV4Gl89lnOHlYmoHdhAuGIAzPHTtLfCgpHq+0MpABBKPEsUqOEFoGG4QPHNWqk6 wPX92+RpSFM05CBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733308650; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K73vwuTPXhdyfDtN2FMm4N+WsimSUFdkNoCVg0ZPQG4=; b=PuN98DUy/p+Qh2k8Cb9d3mL9J1I07e37QGntqZbYAITDtW8N+Bh+tqUuXnW0UKR1un5hjg eI9egrlzPV1J4Kq9pOt15K2CzvH5uAtnsvvcHkT7TnBDeXKUyvS4U4Ky2IYm1hvE7dwavQ IX62tLqOd0J0kPgDyv5HISiH7CbvQOI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733308650; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K73vwuTPXhdyfDtN2FMm4N+WsimSUFdkNoCVg0ZPQG4=; b=g89b5sOWV4Gl89lnOHlYmoHdhAuGIAzPHTtLfCgpHq+0MpABBKPEsUqOEFoGG4QPHNWqk6 wPX92+RpSFM05CBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 834381396E; Wed, 4 Dec 2024 10:37:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id uzUxH+owUGdDAwAAD6G6ig (envelope-from ); Wed, 04 Dec 2024 10:37:30 +0000 Message-ID: <4303a539-4817-4645-9c76-735ae639757f@suse.cz> Date: Wed, 4 Dec 2024 11:37:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 08/15] mm/page_alloc: Move set_page_refcounted() to callers of __alloc_pages_may_oom() Content-Language: en-US To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, David Hildenbrand References: <20241125210149.2976098-1-willy@infradead.org> <20241125210149.2976098-9-willy@infradead.org> From: Vlastimil Babka In-Reply-To: <20241125210149.2976098-9-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: DCFF0C0002 X-Stat-Signature: jrijeoefuhe9w8jz65mtnnjjp49e98hh X-Rspam-User: X-HE-Tag: 1733308645-199836 X-HE-Meta: U2FsdGVkX18ZMr9A6bXyduuKBgdMFMEh7R7jlLCoDTe5g92nZa6KrATQAeO3H65DthF49f+/rOfA1XjN1DsdYYUV3Ub4inP3XHTOADceMIlq9VtxYhlvC7iuTcDB5vVrF7HQRhQv5s2bDpuw/F+qCZIcCSIeBUn+PNsTjoNF7jXcAWjqwvNlJoRjhFAf7liwozsAtp10FwzFl2jM04ZBk8AwZegjDmsKrnsj2jl1s6XKTrTToLYrd22e+IzKEybG16VQ97aYalabU5twtG4QbccAkor3yPf97i/lQBKd2KbxSJoVkPCjeQ1yEu7yg4bb937yeUO2tp3t8rom9Gzypir1WdoFSsy+MUOM35eqkvZE0K3RvenT0qdLoI42rJGcfPMqSUuqg8Iw0fV3luUSywLC4cU7nlKtVm0xcePg/Cv4OLGEdmmxOEoZW7lIq1KRGkuWyDOeOlD5wEr8/M+6xHG86YjULOGYyPjYcGMW7hV9mIE+e1BYywDvqL8OQR8ITdS8nUqD1xjQ87Tuywl64Wwoa5RhgScbs45n3DJIeXfmRzFMtRGnG5v9HupT0Dpv2pctEjJBRlakx+psWbWV6Z/ppDbzzsbFYgHNeocxsgiKZmKX2vsngrtKoChXyklxorVJhCxxxojeiApfzMgxo0DSJIMkTobeM191S60GWjiybEM8zgx0onB/6d1sj8wiJozQy2bkIjDT5ShLLGS8s4z/pW2aX2kMRp0ebXraIU6/ht5gyt1rzVkImrXZEsA1yM73FflDnzje0W5YWqAYuMkbiyI0mEoA6dyR/Uk5g4TgBXzPYrPxfwstuIEWBw0f/SIchp38GAtq4w8iYV2X+e11U5hnj2u8+Qg7s7SiZHhzfLEluwd4JTa/z4hV4gUtcv0LkLKAsWX90MlYGZchYQDc/oCI594ipKqcJPkaAkXtOV9STX2B9p5/XyXPuTsef8J0wsIFawExFUJTvWE W+CXnF2h GZE6vTyeNnluVKRZaKx5Q7mKC6z9gjUQYGJBp/1hYOhF9l4XDO4RFWzV5907GlwjO+5zMZab153T1Dzn+lqHLXUQ4g/sYMiIi2Q8Q+ehUD2gWm715lyMcyStZAMNUA+hjnN704do8P7vG7xM7SDB4wpCAoz9WqHiA8Q0TxPHEFxoaXxGvm1wIVz/jjn1dov9af99Rwbs0ozciAm2GWrKaf4zkxXo45/iF5qlj9tTpKm2U3HVrylQOt2s79G8fvyBly9JTOM+9nWJtowQaNhiAqtWYYwm6V6gAjKEmQbGtZy43Psdh6dUc17v0xJyFcDyOjyxmq0SK+ch0l1SJZGmhLAaqQm9KU+ZqVx6E3RPT26fgIqzISqTyQI85pyZYN2FZ0aAQInVdMgQDev0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/25/24 22:01, Matthew Wilcox (Oracle) wrote: > In preparation for allocating frozen pages, stop initialising the page > refcount in __alloc_pages_may_oom(). > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Vlastimil Babka > --- > mm/page_alloc.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index c9e5c69f0cb9..514994cd67b8 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3638,10 +3638,8 @@ __alloc_pages_may_oom(gfp_t gfp_mask, unsigned int order, > page = get_page_from_freelist((gfp_mask | __GFP_HARDWALL) & > ~__GFP_DIRECT_RECLAIM, order, > ALLOC_WMARK_HIGH|ALLOC_CPUSET, ac); > - if (page) { > - set_page_refcounted(page); > + if (page) > goto out; > - } > > /* Coredumps can quickly deplete all memory reserves */ > if (current->flags & PF_DUMPCORE) > @@ -3686,8 +3684,6 @@ __alloc_pages_may_oom(gfp_t gfp_mask, unsigned int order, > if (gfp_mask & __GFP_NOFAIL) > page = __alloc_pages_cpuset_fallback(gfp_mask, order, > ALLOC_NO_WATERMARKS, ac); > - if (page) > - set_page_refcounted(page); > } > out: > mutex_unlock(&oom_lock); > @@ -4471,8 +4467,10 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > > /* Reclaim has failed us, start killing things */ > page = __alloc_pages_may_oom(gfp_mask, order, ac, &did_some_progress); > - if (page) > + if (page) { > + set_page_refcounted(page); > goto got_pg; > + } > > /* Avoid allocations with no watermarks from looping endlessly */ > if (tsk_is_oom_victim(current) &&