From: "David Hildenbrand (Red Hat)" <david@kernel.org>
To: Kairui Song <ryncsn@gmail.com>, linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
John Hubbard <jhubbard@nvidia.com>, Peter Xu <peterx@redhat.com>,
Alistair Popple <apopple@nvidia.com>,
linux-kernel@vger.kernel.org, Kairui Song <kasong@tencent.com>
Subject: Re: [PATCH] mm/gup: remove no longer used gup_fast_undo_dev_pagemap
Date: Fri, 19 Dec 2025 15:27:38 +0100 [thread overview]
Message-ID: <42ef695f-030d-4e18-befd-bc774815c552@kernel.org> (raw)
In-Reply-To: <20251219-gup-cleanup-v1-1-348a70d9eecb@tencent.com>
On 12/19/25 12:46, Kairui Song wrote:
> From: Kairui Song <kasong@tencent.com>
>
> This helper is no longer used after commit fd2825b0760a ("mm/gup: remove
> pXX_devmap usage from get_user_pages()").
>
> Signed-off-by: Kairui Song <kasong@tencent.com>
> ---
> mm/gup.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/mm/gup.c b/mm/gup.c
> index 95d948c8e86c..8e7dc2c6ee73 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -2806,17 +2806,6 @@ static bool gup_fast_folio_allowed(struct folio *folio, unsigned int flags)
> return !reject_file_backed || shmem_mapping(mapping);
> }
>
> -static void __maybe_unused gup_fast_undo_dev_pagemap(int *nr, int nr_start,
> - unsigned int flags, struct page **pages)
> -{
> - while ((*nr) - nr_start) {
> - struct folio *folio = page_folio(pages[--(*nr)]);
> -
> - folio_clear_referenced(folio);
> - gup_put_folio(folio, 1, flags);
> - }
> -}
> -
Thanks!
Acked-by: David Hildenbrand (Red Hat) <david@kernel.org>
--
Cheers
David
next prev parent reply other threads:[~2025-12-19 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 11:46 Kairui Song
2025-12-19 14:27 ` David Hildenbrand (Red Hat) [this message]
2025-12-23 2:58 ` Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42ef695f-030d-4e18-befd-bc774815c552@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=ryncsn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox