linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Yisheng Xie <xieyisheng1@huawei.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	Hanjun Guo <guohanjun@huawei.com>
Subject: Re: [RFC] 3.10 kernel- oom with about 24G free memory
Date: Fri, 10 Feb 2017 17:15:59 +0800	[thread overview]
Message-ID: <42e61739-ddfb-e13e-69e0-d1c1ac948a6d@huawei.com> (raw)
In-Reply-To: <20170210085232.GD10893@dhcp22.suse.cz>

Hi Michal,

Thanks for comment!
On 2017/2/10 16:52, Michal Hocko wrote:
> On Fri 10-02-17 16:48:58, Yisheng Xie wrote:
>> Hi Michal,
>>
>> Thanks for comment!
>> On 2017/2/10 15:09, Michal Hocko wrote:
>>> On Fri 10-02-17 09:13:58, Yisheng Xie wrote:
>>>> hi Michal,
>>>> Thanks for your comment.
>>>>
>>>> On 2017/2/9 21:41, Michal Hocko wrote:
> [...]
>>>>>> OK, so this is a memcg OOM killer which panics because the configuration
>>>>>> says so. The OOM report doesn't say so and that is the bug. dump_header
>>>>>> is memcg aware and mem_cgroup_out_of_memory initializes oom_control
>>>>>> properly. Is this Vanilla kernel?
>>>>
>>>> That means we should raise the limit of that memcg to avoid memcg OOM killer, right?
>>>
>>> Why do you configure the system to panic on memcg OOM in the first
>>> place. This is a wrong thing to do in 99% of cases.
>>
>> For our production think it should use reboot to recovery the system when OOM,
>> instead of killing user's key process. Maybe not the right thing.
> 
> I can understand that for the global oom killer but not for memcg. You
> can recover the oom even without killing any process. You can simply
> increase the limit from the userspace when the oom event is triggered.
So you mean set oom_kill_disable and increase the limit from userspace
when memcg under_oom, right?

Thanks
Yisheng Xie.
> 
> Trigerring the panic on memcg oom killer is both dangerous and most
> probably something you do not want.
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-02-10  9:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-09 12:54 Yisheng Xie
2017-02-09 13:26 ` Michal Hocko
2017-02-09 13:41   ` Tetsuo Handa
2017-02-09 13:41   ` Michal Hocko
2017-02-10  1:13     ` Yisheng Xie
2017-02-10  7:09       ` Michal Hocko
2017-02-10  8:48         ` Yisheng Xie
2017-02-10  8:52           ` Michal Hocko
2017-02-10  9:15             ` Yisheng Xie [this message]
2017-02-10  9:24               ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42e61739-ddfb-e13e-69e0-d1c1ac948a6d@huawei.com \
    --to=xieyisheng1@huawei.com \
    --cc=guohanjun@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox