From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E072C83F22 for ; Thu, 17 Jul 2025 14:49:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 416328D000C; Thu, 17 Jul 2025 10:49:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EDE08D0001; Thu, 17 Jul 2025 10:49:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DCE58D000C; Thu, 17 Jul 2025 10:49:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1E8478D0001 for ; Thu, 17 Jul 2025 10:49:29 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E7AE5160778 for ; Thu, 17 Jul 2025 14:49:28 +0000 (UTC) X-FDA: 83674040016.28.1CD53EB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 7FDB74000C for ; Thu, 17 Jul 2025 14:49:26 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qp8yUsY2; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752763766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yQMb1+wS2eSkfpD8lt6I9j+fSyOXG57LWL56PdFfPuE=; b=HX/YWIDVGuWfMGxpkdLRoVlPP4pXYEP0o2PFa7n7e60JvoVD9Xv8ok2q2QvORDUKKtqbGa AFwJQknWv+ELguFdN/D17V4PpZiq39OX7ZRsFT7yWkKvlKtU7uZwqTZZGebA//7oMEHl0q 3m/JiUkkWuU593HjI8APkvh1py77Auw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752763766; a=rsa-sha256; cv=none; b=Pp3umGFCkOTuB4Vtc3+SrVlAnlmeHNbRrJ+/ZXv4pHFA08dJcx6DQUHLeOtOtwby/gVmS7 likivxgAFUUePfOVIb67wwWUXALu63R/QY0VGKy/SZ0LYQzHkt2ONgkmfvjcqiXRPIeW4D 9XxkVxYsx07WT999lQwjkI9pHTODzxQ= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qp8yUsY2; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752763765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yQMb1+wS2eSkfpD8lt6I9j+fSyOXG57LWL56PdFfPuE=; b=Qp8yUsY2rExIKFlLtAD6ee1lVg+3QMb9em7fACHAjUtXsf2tSjr/1FMA7AtbDV/A9Vp7ap RzcgdMWGkBzk1Rl8F4ovu9DwuZgabnKpgBEgmho67oIUE2ysIDcGIlbQdFm/m+6B1Hvz97 3ajNY9C8oxppJExxBzbdUlGn2URVfcE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-213-Ki6E_Ij-Np6VIxx0aHEdRg-1; Thu, 17 Jul 2025 10:49:23 -0400 X-MC-Unique: Ki6E_Ij-Np6VIxx0aHEdRg-1 X-Mimecast-MFC-AGG-ID: Ki6E_Ij-Np6VIxx0aHEdRg_1752763762 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a58939191eso570471f8f.0 for ; Thu, 17 Jul 2025 07:49:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752763762; x=1753368562; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=yQMb1+wS2eSkfpD8lt6I9j+fSyOXG57LWL56PdFfPuE=; b=IzVCtn6AZQww5st8mOKl4cYB9Yd+/Emnky6oYnPFMch6JstnyYlwAlyV5PXlDsEp67 /JGzi0ONGFteciM2IdbjsBe6GaceAWp3twEIFNBKNhV5bj4Dw3M9ajhgImrUrBsRe9wO /A+mq8+fVQ0RP9uFvRhUVhPT8d10bP0/uOoacbnyxuHwLvia7HcOgRh//31fBor3ceSF m4fHHK2KqYkcFeFupo8mjQ6PfgP4wOsUAGg6bjMHpsfa/WJQRHM+aaS9UN5gbJJh6LfM CDKHMZwdTLKN48nRAfUj4eoQfzl1S6EIA+oZjtDKGH7rLRA+bZQxjvK2Us8DOYu1D8U9 W6Hw== X-Forwarded-Encrypted: i=1; AJvYcCUrKQVsy1j3s4CMErEckmZn55sklHop2B1yTG9Kc/mgIISCP7rKo6OiLfPzryjnEpBolhR+9hmx2A==@kvack.org X-Gm-Message-State: AOJu0Yzw2k3ia38Ug9BbCPRypX2jw56tkHEzn1Gk7YqA+VqUioULhruf 703F+oXVS+ueueKjMSZsQBJJXYWPccV19ozxzU4rdYjK/yRoXbBBdld2A5BguNEVSBxbxHp41mf 8EVHGOOPnO0fp6T6NThXe9tFVkHSII0nCUVoUvHHqSklIotSWGwCK X-Gm-Gg: ASbGncthAl8zlqvEiwXJ8ZLGnKuIwgWV57UEjIa2TA+w+Q6lh1irrzwG4g+0LPLiAD8 4uP9L3ATroCPDOKzkWJynXTGCsazgaq/RgrrZP6qamiSsm8QcGzokuuy/pqqiazAQCVVBGA7eXp Li6i8Hx2FG6NfuCr5W/QRisHdOGPhApGWaNxzI8h5gJijntZPnMiNs5E8d2KEWdB7r0IbVwi3N0 zY3vBcXMdBcM37HM45yRq5BrVHU4RQ0HHWndGlJUBTfXXJBm+0Fli5ZFFhhuRDRK1aXIiv3yBTT aMAfqkSk9PF6kPJ2old7Uu2Z2+7Oz/IqnlUwBW+11Memoxoni67oQuuVOtYn1VWwESGX0iSHjUG BELs1rTTzftyUlS4t5mzPSpTOJfvdcvCCHvStc6JRwcB52NIshV85wNzCN9u1ZSB+ X-Received: by 2002:a5d:5f46:0:b0:3a5:2d42:aa17 with SMTP id ffacd0b85a97d-3b60e5127efmr6440758f8f.31.1752763761944; Thu, 17 Jul 2025 07:49:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEB4BzQwt1uA6jNvYg9KXjg5Sb8H9BF6TM/n/+bMIra3u3HYiMpTsglgidO4NGId3V6f70EZg== X-Received: by 2002:a5d:5f46:0:b0:3a5:2d42:aa17 with SMTP id ffacd0b85a97d-3b60e5127efmr6440707f8f.31.1752763761405; Thu, 17 Jul 2025 07:49:21 -0700 (PDT) Received: from ?IPV6:2003:d8:2f35:2b00:b1a5:704a:6a0c:9ae? (p200300d82f352b00b1a5704a6a0c09ae.dip0.t-ipconnect.de. [2003:d8:2f35:2b00:b1a5:704a:6a0c:9ae]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc3a62sm20800473f8f.40.2025.07.17.07.49.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jul 2025 07:49:20 -0700 (PDT) Message-ID: <42db9f05-11cc-453b-8259-39cee70f137d@redhat.com> Date: Thu, 17 Jul 2025 16:49:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] selftests/mm: reuse FORCE_READ to replace "asm volatile("" : "+r" (XXX));" To: wang lian , akpm@linux-foundation.org, broonie@kernel.org, lorenzo.stoakes@oracle.com, sj@kernel.org, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: brauner@kernel.org, gkwang@linx-info.com, jannh@google.com, Liam.Howlett@oracle.com, ludovico.zy.wu@gmail.com, p1ucky0923@gmail.com, richard.weiyang@gmail.com, ryncsn@gmail.com, shuah@kernel.org, vbabka@suse.cz, zijing.zhang@proton.me References: <20250717131857.59909-1-lianux.mm@gmail.com> <20250717131857.59909-2-lianux.mm@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <20250717131857.59909-2-lianux.mm@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AsJARi_8AW4Vd9K7aVAZxuXjXHIgU9f-iXpQA4kGMVg_1752763762 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7FDB74000C X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: nh31kmhin564mf6wxe3hob8q8mt1tu7d X-HE-Tag: 1752763766-41060 X-HE-Meta: U2FsdGVkX18b1eXeip0RvQYeNUikKNIIgexpVkj/oCcZ4DklxeoBt7vDmbhl598FcC89KrtpTbzVRpJHw6twqCNXOb9x8GSZTY1oiI4aTCZG01RLkA4GHkZbTeEJc2PHSn83kI+AwL/u6VIYGELGQ/ANZO+r6p/vSFzg4NZTVHaZvKRQdsvyFp7zyNa7iL7ZUr8piDNgDeiA5+neZZPaB1twSvoUKxgK+JcprlxAKRiWp7U9OpCVvnQhFafN/Ea07Ug1eIQZcRzNlNEkY8haAWuhd34CTUyqSjT1P4DT+G5g4WONKd5Jd87/h7Up6rarMuaDj9d1x9IcsX/1bdx00BfJH/crbYYUWcstCeNLQuDVyEzdeoE+yisX1nVl+bgM2K+8SD293O2nv/RVq+Y9KgOmZN0Ego8mh4+Mt5706oOb+L5aosd8kL/JfY/LoYIunUXTee4Wiz2rbW8kbDtMy3WUhsy6KJrHu3qYI6Mq5F3yOUnCPskYxMleX4Rzi4A8Sh14FAT8lg5nmePKrfHigmERGy0Rs3Fs6f03bjxpJwIJA8Yngsw3mfhHeCT1yX276L+5N0pOpweL+xSDCP0ljsQGPJHPnUblp5L0U7GOJfwp0nHcCCyj0l2OoKVUUM+K8ByNiSI8OslEz/m82hBVDxwUA2NZps6E+ywFwFWWTz5Zm/bYjvyw5hhM3XPmhq4Rw1siPhzedmDidac17Gtx7ouKT5dkEcs4u5c0b9l+MdNb94ZpUkIolkVHxT7VmmtSt9+0tEgWzCEygWqH1n4IxePpYebZ3peIqXlICcry7HfFIJzY/Ijm+YRIoxCXRyUM6QxHlxOSUqgJ9ROpS8TtDsw+vYJq2R5KivqeV4OJBn0JlXRBo42xGaQWxs54cvDKWWdb+tVOtJUm2dhusoUB03WVSkz/Hfz3o4cYTCZSFsqz3k8SsEEadBx9qt+356TfOL+OYIz+vP7BOy6Fq2q eo1rq1ra kc8fmINXXGoZ7xdExMW9yVd68m4QEzZmspdqXdgz4/jNAyEi2Ibd5lj3ANRD52y3NcFrVtRMSnYudsMqZ7k9PgNd9dJoDqqrHYGveRiEQn4iKFtjYGx/NvESE/oN8VSwsDH5Gnf+AnEBkbCd60HMOqVuSPBI0zVBfI6M4MmBc06U3IBJPR3Ad+1wDjj6QLK/VZsAiRatS3+k7DwHYeHfg2F2yCpIuHeQDl2mDf7gxCtcLenRwIrGgiXi7RhugM5lkOT8CtI2BSlinQKu6Ofn3c+rSKLO1voEpHeDXm0K0mJjKwlwP+XC9ZaH6gBNFGiv90f4B3BpUSgGDjU97GbMXUiARmyWPchE5tONsvv+PcVx2j6dC09+LD/jEcaiaDrsN/7o3CoQNXE/ok9RnnvBUkAoLjAmjvw2RzkqveH7M2tDs21Uz91Xk7BUsyj3wZRRcxS+Vcz+a3QkNOrj4+9M8l0+6EsF4gClJrXWmNTWZ9OdF3eBsBcE7xYlGmAWjKBwVr3GS6vcV1fGRkTJi+WXzitf0WrH4I1dFidXx02g8LqgbhQwjIg0qHMKRs20W1tSZimR2y0jzVdAyibB9W+4r1WFLX8SOqQXF2YUuZSjq/Bkd7nerh7eiO64MUhJYUDRnerUcPyvgW2ZpXtXxZ23mnQg2MGGmMCXT3iCJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.07.25 15:18, wang lian wrote: > Several mm selftests use the `asm volatile("" : "+r" (variable));` > construct to force a read of a variable, preventing the compiler from > optimizing away the memory access. This idiom is cryptic and duplicated > across multiple test files. > > Following a suggestion from David[1], this patch refactors this > common pattern into a FORCE_READ() macro > > [1] https://lore.kernel.org/lkml/4a3e0759-caa1-4cfa-bc3f-402593f1eee3@redhat.com/ > > Signed-off-by: wang lian > Reviewed-by: Lorenzo Stoakes > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb