From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EA89C46CD2 for ; Thu, 21 Dec 2023 05:08:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBE6F6B007B; Thu, 21 Dec 2023 00:08:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C6CC06B007D; Thu, 21 Dec 2023 00:08:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B351E6B007E; Thu, 21 Dec 2023 00:08:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A45196B007B for ; Thu, 21 Dec 2023 00:08:21 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 65588140AEC for ; Thu, 21 Dec 2023 05:08:21 +0000 (UTC) X-FDA: 81589644402.25.2C985DA Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf25.hostedemail.com (Postfix) with ESMTP id 7432AA0018 for ; Thu, 21 Dec 2023 05:08:17 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=eapX0si9; dmarc=pass (policy=none) header.from=ibm.com; spf=none (imf25.hostedemail.com: domain of donettom@linux.vnet.ibm.com has no SPF policy when checking 148.163.158.5) smtp.mailfrom=donettom@linux.vnet.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703135298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HmXdbVMseVEPw6PTGO2K7KJby6Cw53nb/+bBsFHy2NU=; b=1x1q+8qtqC+p+C7kUQFcK9yAxRLyRm2tfZosBbUjtJD8FXtFTUcqRbw1Qo12gZZrNlNO3Y 55ZP2zfqW1T2Ep8Gq862gAitQFlPHCgPqP8dwRKHeTS0w43TUhSJ3wNxpH3bt7MFWPEpB1 g4MFv7wkOGlcFyXNDmM7CuoW85YwDss= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=eapX0si9; dmarc=pass (policy=none) header.from=ibm.com; spf=none (imf25.hostedemail.com: domain of donettom@linux.vnet.ibm.com has no SPF policy when checking 148.163.158.5) smtp.mailfrom=donettom@linux.vnet.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703135298; a=rsa-sha256; cv=none; b=8ENE5x4i4VKe5cxhbU3VI30wYqEeRpc5fIyujWzTVm4Lluu4BXpQSbECM8j/z10FE9+sqt TtpR25XldvHmIzSiyceCIMYSlRnUvVoEiG/mskbGj0hgV5BINIr2BkqP0/QTweGkgDD5+s ByGsfhxJ6sCkQGg2xmVwW932jzy8gHQ= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3BL4kAqC018818; Thu, 21 Dec 2023 05:08:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=HmXdbVMseVEPw6PTGO2K7KJby6Cw53nb/+bBsFHy2NU=; b=eapX0si9Edly3I42ALx+V+pjKRoioPRUWtiolNRZoCRLRZKPe/+mVjm6+GWw3LyK/1yt xG8xfZKpcOqqE0cx/VMkocGd6m+Xh5PcE0Nen5mqE+iapn2v2HRlhWGbAgTiDttnqrtz c5XiCt5qDVfkNJ8TWf4PnCx72LrOzFBGr9YG8ehfXePyw8YkzaBv5CGSO50uMOoVVp1I nIBSDeXdToJEUdnQssB1ZzI1fzIV2+3TuzVMp6hyUrelW6ZsEO07ChYl4GteeasVmyy8 t6Nlj+xv0LMKN6Zdl/DiJSEzWX0GOGSGG4msag8MZj/fsUPxwbiIrRMp7+fT8CR8keNr aw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3v4ba6xvs0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Dec 2023 05:08:15 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3BL4tbC3024092; Thu, 21 Dec 2023 05:08:15 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3v4ba6xvrh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Dec 2023 05:08:15 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3BL43T96012351; Thu, 21 Dec 2023 05:08:14 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3v1rx22fqv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Dec 2023 05:08:14 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3BL58EMl42926656 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Dec 2023 05:08:14 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6AEE95805D; Thu, 21 Dec 2023 05:08:14 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6CB1758052; Thu, 21 Dec 2023 05:08:12 +0000 (GMT) Received: from [9.109.245.191] (unknown [9.109.245.191]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 21 Dec 2023 05:08:12 +0000 (GMT) Message-ID: <42cf3f2e-99eb-409e-8719-cff4afe0906a@linux.vnet.ibm.com> Date: Thu, 21 Dec 2023 10:38:09 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-unstable v3 0/4] mm/mglru: Kconfig cleanup Content-Language: en-US To: Yu Zhao Cc: Kinsey Ho , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20231220040037.883811-1-kinseyho@google.com> <7baea98a-90ff-4c2d-9d00-d3ddc715c235@linux.vnet.ibm.com> From: Donet Tom In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed X-TM-AS-GCONF: 00 X-Proofpoint-GUID: h9Asn6OPEE5WhPWKpQWMBE2GIR7a7t5a X-Proofpoint-ORIG-GUID: lUiWRqORQ1lj4hGH8It-eRWfwJjb8cWM Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-21_01,2023-12-20_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 priorityscore=1501 lowpriorityscore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312210035 X-Rspamd-Queue-Id: 7432AA0018 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 7o1ut7z7yey7nbc74ahwegbxr1hh1mcn X-HE-Tag: 1703135297-137634 X-HE-Meta: U2FsdGVkX1/8+0sxuknIPBncCDgF3sVJ7qS512VH4BexUoABwLwJvemZLFf6H08oSjd7qT/63PosS7Uczk8uP6HiYxt9rNOWY0dj/GL22eIuQMJfco37Qr00OwnIIBc/tFD8D39p4T+ver/7q/Tb1FO8A8LX9cwAxCTWDj8Zx1g4JBhEQvGEkHwIe1b5V9xwu17L/zx5runUHaEOCYGw9FTsHWJGgnv1snZf85RYxZsovldwh+lwRT+DV4ik9Od4KwXWsWi92SUH4ot9ymK3gPHZswPuVHU8u2E4VfeDib1Ozy4cILk9JL21lc/GidEAPcm7pJqKOx+a1DtUpMH9AcI526fIjf3PYrIakTFCthreJxhQw/wB6E51O+9hngGBYN11nlAU26Nk4vjsj/Sbrnt1LVN4NOLedqX3+t/nCeckfO4jxJjKJihAMR0EiKXjaSRFhbnV+1/V/iF1Z7aI9edV3kYvNdsRTvvNCDI3ADXYDPLmZvxnSQn9xQLvytTkieMQTXPiiv4u5qQ7pbTOYl32xi/ONbUzg/e3dkktFlYZ9Lgrmwbg/1Rk+NLyEue2f+l/YHEzWY+0mo+otSyX/g4w0nRkLe7nxEtq8/woJrNjIwtstNEONJU15lM3ixmVNPJOTJMHjFZvu8fTf2Js/gTAn235E2ZckkFuzZy4+htbjr4Zwv52VdBO+4g0ul0q/Y3wfWKbjv8dXqnTXk896a1t93p1gXx0wxduw4A4PasiEUiRmOHcX7Wa6/4BYaq/u6TGaj0NSTM6FkZJxoYd1YwZeSOtNVxJROTDEElIEzJgD4YjlIdidb/C759X1tAwfxEKUOvN2iZUoiw6Shb17rw4fPkTBB0vV8z+yFF+rWft9+tfm9IJd9jNFFmyjqE4kG/YVqcOF+7dPn/y75SZCg7IWNHpQ1ArF2m/oM4W2EGIPJ446PuxkF54kmyq+uXRL9OccQXy0Q25ZAqhaLp rPfo6MUz TodxFguAa8VXi9EobYR8+pej502enZ8tAjjMkHJV319SOIZ2l2PcEbdrTStHa/O37HXBxkPD7UMihGBp5XyK6IERzsOnqw1x9FmhTdLvrZFYK5vTiQdEXMstaNJHZl9kyCEIydVI3pJNnN2LJuLuzcLKrowO0NwTazynThzKU80G9wB2CHJU/ZnXPS7rOFSgYivkfzMrfTyZ5OSpSMGmPV0B8irFy78L5mWDu6UNUmLwkJTEX5b+UXSBvmMD+ucsU3L9qbBRUVJLB/U4hNrphtC7hRKlkhbWSm9r3rBboW3fEdJhC+I55bSNJNnmqCKa/6Z6S2kRKraenz+Sw7iDITU1248FSa5SokATF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/20/23 20:46, Yu Zhao wrote: > On Wed, Dec 20, 2023 at 6:45 AM Donet Tom wrote: >> >> On 12/20/23 09:46, Yu Zhao wrote: >>> On Tue, Dec 19, 2023 at 9:01 PM Kinsey Ho wrote: >>>> This series is the result of the following discussion: >>>> https://lore.kernel.org/47066176-bd93-55dd-c2fa-002299d9e034@linux.ibm.com/ >>>> >>>> It mainly avoids building the code that walks page tables on CPUs that >>>> use it, i.e., those don't support hardware accessed bit. Specifically, >>>> it introduces a new Kconfig to guard some of functions added by >>>> commit bd74fdaea146 ("mm: multi-gen LRU: support page table walks") >>>> on CPUs like POWER9, on which the series was tested. >>>> >>>> >>>> Kinsey Ho (4): >>>> mm/mglru: add CONFIG_ARCH_HAS_HW_PTE_YOUNG >>>> mm/mglru: add CONFIG_LRU_GEN_WALKS_MMU >>>> mm/mglru: remove CONFIG_MEMCG >>>> mm/mglru: remove CONFIG_TRANSPARENT_HUGEPAGE >>>> >>>> arch/Kconfig | 8 + >>>> arch/arm64/Kconfig | 1 + >>>> arch/x86/Kconfig | 1 + >>>> arch/x86/include/asm/pgtable.h | 6 - >>>> include/linux/memcontrol.h | 2 +- >>>> include/linux/mm_types.h | 16 +- >>>> include/linux/mmzone.h | 28 +--- >>>> include/linux/pgtable.h | 2 +- >>>> kernel/fork.c | 2 +- >>>> mm/Kconfig | 4 + >>>> mm/vmscan.c | 271 ++++++++++++++++++--------------- >>>> 11 files changed, 174 insertions(+), 167 deletions(-) >>> +Donet Tom >>> who is also working on this. >>> >>> Donet, could try this latest version instead? If it works well as the >>> old one you've been using, can you please provide your Tested-by tag? >>> Thanks. >> Hi Yu Zhao, >> >> This patch set looks promising. >> >> I have conducted tests on PowerPC and x86. >> >> In old patch set there is a cleanup patch which removes >> struct scan_control *sc argument from try_to_inc_max_seq() and >> run_aging(), Do we need to include that patch? > Sorry not for including that patch in this series. > > It's the first patch in the next cleanup series, which we haven't > fully tested yet. It'll be the first order of business after the > holiday season (mid Jan), does the schedule work for you? > Yes. No Problem. Thank you very much. Donet Tom >> =>Here are some test results from PowerPC. >> >> # ls -l vmscan.o >> -rw-r--r--. 1 root root 3600080 Dec 19 22:35 vmscan.o >> >> # size vmscan.o >> text data bss dec hex filename >> 95086 27412 0 122498 1de82 vmscan.o >> >> # ./scripts/bloat-o-meter vmscan.o.old vmscan.o >> add/remove: 4/8 grow/shrink: 7/9 up/down: 860/-2524 (-1664) >> Function old new delta >> should_abort_scan - 472 +472 >> inc_max_seq.isra 1472 1612 +140 >> shrink_one 680 760 +80 >> lru_gen_release_memcg 508 556 +48 >> lru_gen_init_pgdat 92 132 +40 >> shrink_node 4040 4064 +24 >> lru_gen_online_memcg 680 696 +16 >> lru_gen_change_state 3968 3984 +16 >> ------ >> shrink_lruvec 2168 2152 -16 >> lru_gen_seq_write 1980 1964 -16 >> isolate_folios 6904 6888 -16 >> lru_gen_init_memcg 32 12 -20 >> mm_list 24 - -24 >> lru_gen_exit_memcg 388 344 -44 >> try_to_shrink_lruvec 904 816 -88 >> lru_gen_rotate_memcg 832 700 -132 >> lru_gen_migrate_mm 132 - -132 >> lru_gen_seq_show 1484 1308 -176 >> iterate_mm_list_nowalk 288 - -288 >> lru_gen_look_around 2284 1984 -300 >> lru_gen_add_mm 528 - -528 >> lru_gen_del_mm 720 - -720 >> Total: Before=116213, After=114549, chg -1.43% >> >> =>Here are some test results from x86. >> >> $ ls -l vmscan.o >> -rw-r--r--. 1 donettom donettom 2545792 Dec 20 15:16 vmscan.o >> >> $ size vmscan.o >> text data bss dec hex filename >> 109751 32189 0 141940 22a74 vmscan.o >> $ >> >> $ ./scripts/bloat-o-meter vmscan.o.old vmscan.o >> add/remove: 7/3 grow/shrink: 14/4 up/down: 2307/-1534 (773) >> Function old new delta >> inc_max_seq - 1470 +1470 >> should_abort_scan - 229 +229 >> isolate_folios 4469 4562 +93 >> lru_gen_rotate_memcg 641 731 +90 >> lru_gen_init_memcg 41 99 +58 >> lru_gen_release_memcg 282 336 +54 >> lru_gen_exit_memcg 306 350 +44 >> walk_pud_range 2502 2543 +41 >> shrink_node 2912 2951 +39 >> lru_gen_online_memcg 402 434 +32 >> lru_gen_seq_show 1112 1140 +28 >> lru_gen_add_folio 740 757 +17 >> lru_gen_look_around 1217 1233 +16 >> __pfx_should_abort_scan - 16 +16 >> __pfx_inc_max_seq - 16 +16 >> iterate_mm_list_nowalk 277 292 +15 >> shrink_one 413 426 +13 >> lru_gen_init_lruvec 190 202 +12 >> ----- >> try_to_shrink_lruvec 717 643 -74 >> lru_gen_init_pgdat 196 82 -114 >> try_to_inc_max_seq.isra 2897 1578 -1319 >> Total: Before=101095, After=101868, chg +0.76% >> $ >> >> >> Tested-by: Donet Tom > Thanks! > > Acked-by: Yu Zhao