From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A14AC54ED1 for ; Tue, 27 May 2025 11:06:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 971786B0083; Tue, 27 May 2025 07:06:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 949E36B0085; Tue, 27 May 2025 07:06:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85ED36B008C; Tue, 27 May 2025 07:06:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 674366B0083 for ; Tue, 27 May 2025 07:06:50 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0CB0C1605A4 for ; Tue, 27 May 2025 11:06:50 +0000 (UTC) X-FDA: 83488410180.30.9FD519D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 8006C140006 for ; Tue, 27 May 2025 11:06:47 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hvwvipbp; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748344007; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sulfAOh0bnTIvH614+QkjzD08FiYe9TfUeautv0hWDU=; b=OtM7rbm53erIBTvV30LfQTS35J3F0VLYzG/S16s/w26oH+/GKIxVCk3o2KDuVTwq8COIAq PBZVe46EcBN3BK1El0TnxnC80RlPbB4QyPV78825/NulxpKXrD+vJkXTVct8vtXbF/lXZ1 ysDuTEeSVWnCoBMeXEy6mlKtoArrzEU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hvwvipbp; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748344007; a=rsa-sha256; cv=none; b=0OslaFHy0thAeZBoZPkWG5TI+RnoqO1YKMr755uIUkD4+i+NJNHs/fbHJp52h7WvrzrP/6 B03ey9fOfgoXDAIUwf4QrDWBiRYd9vpm79isZN+KszFy+j1jRlQ21D9c8jCoJkGsLaEyrN sVTPzYmSP2JuvG490ASmJWvAY61pdiw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748344006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sulfAOh0bnTIvH614+QkjzD08FiYe9TfUeautv0hWDU=; b=Hvwvipbp/Vd2DO73DoC6q0fXkcJzw5hcJ/FhRDaMCtiWUP3MHXFCmkoBGi27WaDx0rvXvD Gun76kO77RWN49YTFaoXwv+JcGla14KHG9E5/qwqCv7XkHw1f9G/rrssPB/RYCl9xCU+AW MaL34292RUY0pbqroihubsvoW/piodg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-121-A3UFs5W-Nz2diJd6LIDCYA-1; Tue, 27 May 2025 07:06:45 -0400 X-MC-Unique: A3UFs5W-Nz2diJd6LIDCYA-1 X-Mimecast-MFC-AGG-ID: A3UFs5W-Nz2diJd6LIDCYA_1748344004 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43cf5196c25so18467275e9.0 for ; Tue, 27 May 2025 04:06:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748344004; x=1748948804; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=sulfAOh0bnTIvH614+QkjzD08FiYe9TfUeautv0hWDU=; b=GA4zk3EYc8iXU4c1QBhXlKR9ze6ZUr+YPwkJAq2Ea8kP2EiyfY9IGGiBNqwaQK82RJ bXQ2b1tgmP5PJuqHkXVIeDqMnLALwyo4ifUY6N1PXdDaMYTvlVX0/D8Olg51JgywIqBC +9Qhat5kHmkz4aFopn4xsOzaYJ3hRV8z+Qswierhok2dLFJffKIz/ELdq/AJxobfzBwX 6DiozuWAtippxnQzcfhFyvgReHZboIlDhsmY92dxZZEPiJFXhrKcxOjlIW5dfcGJYFrB OBHUqVRyG7jJbioqVB2Vn5oJT1gBjOJ7HY5LbBNv9fwDRXvU1Pejg/RZcV4PliUUU4Qp 6+1w== X-Forwarded-Encrypted: i=1; AJvYcCUfgyMT6g/dWbrv+lvh5Dh/sKRk7q2tM7ucxx60x6cyb7zGqHOwPQ2h8MozTzqdE61gfx0nJqsHXg==@kvack.org X-Gm-Message-State: AOJu0YwFm0FfnWkj6gxBXQZk/213isBngqpQMkf+kgfurfdsqJMdsqz3 mJZCXpC7KLJeXFye7A/tdgQnbRVYbKGKPbBonzOYiaDAWnACiGN8wOV+QKDcqjiO4EQWoTDwC6e /Wjm3hTsTS4h9nUt4b6Xm6+ucNgnYO+d8+bw0Zej9zAiO3nFZ/AbA X-Gm-Gg: ASbGncsx8RqJAN0Xoq5hPJIp4M82AziyFHEBlr4j9idzqISAItIDMTgjmN4uMVXtkWZ PEiKdPh4954bnvZlgblaH7vLmLjBysQzgalmsPCM3XesGd82HfPemx/ES701pbYnNV9vO17A2OS NPFGpNQ+Dgw9deDs/r5ocidplj1XSA9RI7xRFpRbsFknrMNDW9BFErvUK29i6B6U1aW5DqDECr6 1rkcR8AS22myVoY7DcDmrcB7s6sTnSP5LBCTZChS2gN5s1IxO4Z0cxUDEdsm7HmWjLhotFgm8ec 0QdwLTDtR4LMKw+AmknPwBxKVkZORRV+00wp8T8vbJqx X-Received: by 2002:a05:600c:6550:b0:43c:f597:d589 with SMTP id 5b1f17b1804b1-44cf6d81765mr79014375e9.27.1748344004444; Tue, 27 May 2025 04:06:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGbm0J5ZLvf0PzR50HxzLWAsQEs102P3Yg2tmficxvKf+HeXmgF2N8HWUYfJRuOhVoRm+M3UQ== X-Received: by 2002:a05:600c:6550:b0:43c:f597:d589 with SMTP id 5b1f17b1804b1-44cf6d81765mr79014185e9.27.1748344004054; Tue, 27 May 2025 04:06:44 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-44fcced3cb5sm20457195e9.1.2025.05.27.04.06.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 May 2025 04:06:43 -0700 (PDT) Message-ID: <42ce8dcc-0139-4dd7-9bef-bf3efa93849a@redhat.com> Date: Tue, 27 May 2025 13:06:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [BUG]userfaultfd_move fails to move a folio when swap-in occurs concurrently with swap-out To: Barry Song <21cnbao@gmail.com> Cc: aarcange@redhat.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lokeshgidra@google.com, peterx@redhat.com, ryncsn@gmail.com, surenb@google.com References: <20250527083722.27309-1-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pfHobxTZgPeIPX1OJOWmbmqgydGKvaVM9ga0X6U6N_g_1748344004 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8006C140006 X-Stat-Signature: 8inbbznsadfi5w1sppnycofzyokg313y X-Rspam-User: X-HE-Tag: 1748344007-211924 X-HE-Meta: U2FsdGVkX1+U1+M6KRAD3FLyyFhPjtRp4zc1+QkztyFvyn02tKEwCQPSd6VjnkuaHkRlaTZThf2HOe1KxQLUdg6EcjII6ajtbTss0uKeoNONrojgpRmoKvkQUTamdQXkZFZqPZVW0LzGz3Y4wpB6KQiU6PrhgQ053ZVEN3EoMzYE1LMlBe/5Y/Nak26kF83aZXKYh6ZT2V/1Jt9Z695yeHizlts+lDOKYfKLU2+oiHxZOYv9/Ex/cJs5ooRuxa9hj2u8DA8nZwyEz+RAl03WRVcbbG6MdTbCDMLcOluRiOLan0A/rQv931XjjoGDbazGu9PNu529s1JtoiUoG2RwO2azNLrSziNb3o5mplVBFwhcLJ6Ns0ek1k5Rntfa39IcI+haTCWqckpG6qx5YeWjDwE3cAqb/2/9bgXxjidPIvzFPtAfAoSOr7klnSoxILqNr7ql+PQpux0t8QhMQSNMfluMhvuBonUjMMmP3KwU5CaCJaYg5EHdyPyj5Irt+tAXSIAuDOI6oihP9e4btsAmlOM5TlS8DJi+3ovFpLljDYWBxT7qC0OLevi6vnhtHGtMsKh58ZZTVwR0OvnfCDT0xuQiFmV4SR/8chhkIea5ApuX758pNCAgeqnPdUJcC5ug2Ad58A1tS3bOg80ZEQUC3wucFIOgt7MiMK4L+SYJaVnC0keI5xm6Di4A7fgs64dZWQqOyPjfD2qSdaYbmNkLSvyEqWMUgSpLa1s9NXOns93vc68ceKHEyz08RTgG7M1rjPLg/OSmAMiO3/k61f/IH8153+N0obkVxokltaQXFahNt7qwuqiP70Rc0aio2X50awPYFFnrK7skPEeRUb3FOE9RMHclWT/eDwEHKJcYCzm9iyR73TJ/zxbpmjoviZbQIfEAzvjSOmGMkZGwu+ui6+jqZ/+Qv2Xw2Qe4KsAKXNpsCRdkoj62JU+qyp8W8KNWDKLa1NMncIDggY0kv5M d+xyHBm6 QnFgsRZ+SUOgn6aj8dODGLqUol15qnmr1KA7ynQWFdwcYjHy5UNJxYFR9lRkb5KNYRB2O/AXfv1dW/o6ZILKe2oH4CXGFhs1io6535OIPvNAFLUtcexGm/8zlW85fvhzNIpU+43cv4bNVX6kKRrhQGtJI8GHAvxvi1fO4gLOhcSGYqo2yxi7Nw09CcBhn14ObVBwDofubE+I2Dz6YX4ukVzOYC6FaKXiyBpElmK/Z1JabJcXFwBQy1019CpiyTZSOjKX9pwZssDE0SlVWlqQx1BsCEPSXDltKaDl9I6DsskcmOaDmxkIy/F09NQtM6AF41Nc6N8mlfFDJps3+I97Ujm0iOFehx5KNTj6CZViygo0v8KMKYAKlPHLXo8YlFC3Q38zSNi5NZs3vm3fkwFSK57n7Pw4wKOJCqsW/ZKOIQvRpmWthENAa0FQcsAC1VaWu4gCYnaXCaMLWjS6mbCvm1SCjbu/NP2qXfnP/J4rtLuFB6EhSC34ijOrX0w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> >> EBUSY >> The pages in the source virtual memory range are either >> pinned or not exclusive to the process. The kernel might >> only perform lightweight checks for detecting whether the >> pages are exclusive. To make the operation more likely to >> succeed, KSM should be disabled, fork() should be avoided >> or MADV_DONTFORK should be configured for the source >> virtual memory area before fork(). >> >> Note the "lightweight" and "more likely to succeed". >> > > Initially, my point was that an exclusive folio (single-process case) > should be movable. Yeah, I would wish that we wouldn't need that PAE hack in the swapin code. I was asking myself if we could just ... wait for writeback to end in that case? I mean, if we would have to swap in the folio we would also have to wait for disk I/O ... so here we would also have to wait for disk I/O. We could either wait for writeback before mapping the folio, or set the PAE bit and map the page R/O, to then wait for writeback during write faults. The latter has the downside that we have to handle it with more complexity during write faults (check if page is under writeback, then check if we require this sync I/O during write faults even though PAE is set ...). > Now I understand this isn’t a bug, but rather a compromise made due > to implementation constraints. That is a good summary! > Perhaps the remaining value of this report is that it helped better > understand scenarios beyond fork where a move might also fail. > > I truly appreciate your time and your clear analysis. YW :) -- Cheers, David / dhildenb