From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74263C77B61 for ; Mon, 24 Apr 2023 08:26:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 102076B0071; Mon, 24 Apr 2023 04:26:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B1FF6B0074; Mon, 24 Apr 2023 04:26:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBC2A6B0075; Mon, 24 Apr 2023 04:26:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DAAE26B0071 for ; Mon, 24 Apr 2023 04:26:35 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A766E140296 for ; Mon, 24 Apr 2023 08:26:35 +0000 (UTC) X-FDA: 80715603150.03.B5E0053 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by imf28.hostedemail.com (Postfix) with ESMTP id 7B92AC0015 for ; Mon, 24 Apr 2023 08:26:33 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linbit-com.20221208.gappssmtp.com header.s=20221208 header.b=BCLvweSQ; spf=pass (imf28.hostedemail.com: domain of christoph.boehmwalder@linbit.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=christoph.boehmwalder@linbit.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682324793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3pxlWKD7dnb+hgIonOTuPgqaiGVvQd+hXe0K6IdPi2M=; b=oZ6G8n4WU87sEX1N74JKTNOMnC/GteOgxo2jCw9J27hWxt345bTOgcu7W2XfGQ/jE3cy3K Oeja9f7/LI2Pn24p6BDpFIj1ZBOWuIAIOBfV8Q7lvigjhXbQ5CDIOVrJi/zKGnQkg6jqvP USY4y5YzjhJqW+mnFR2RTpqZZm5ItNo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linbit-com.20221208.gappssmtp.com header.s=20221208 header.b=BCLvweSQ; spf=pass (imf28.hostedemail.com: domain of christoph.boehmwalder@linbit.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=christoph.boehmwalder@linbit.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682324793; a=rsa-sha256; cv=none; b=y3yOJy6Yiukc/r4KCSFOJ1qty7AT5sOW8TEgfElHQsKzVPnMYgHeE/BmOC4r/cy9S4ISZf x+VsbjFyniE3/OKZ/ZOQbqCdorQ1OyvfeyaF1fqpWdelavv/LUU2m/zSInbV3VTF7UHmPM KxSDmjOPqiOgYreN5/28tq44M5wdWM4= Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-3f195b164c4so15950975e9.1 for ; Mon, 24 Apr 2023 01:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linbit-com.20221208.gappssmtp.com; s=20221208; t=1682324792; x=1684916792; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3pxlWKD7dnb+hgIonOTuPgqaiGVvQd+hXe0K6IdPi2M=; b=BCLvweSQah01sJW9SBAyC5wgM9gcCgmoD6eVt1pixm6TIMPKSMsfDJ/G6pQ7WifY+a jCWSatlOFJoGBGRyqNjpnC83+YZxWwidqcfJV7qrZVFpoOQQ5qGdcpNUfD/1uI304Bsr n5t0aKbFfDOlYu2sfU/KiJsKG+tbC5Q3pej1LUOiQjmwv12srCYdM4fwvJqfC1vIGgHG i7xM2mHs1udxBgFRdzJGUIySnuCvM4rCCc4KxRtFlArnjXACALMboZpw/c8XanndS9Ts WTUnWIGWHkbm7Rk6Wg/mlO7SJDa+qk0PwimjElI9r8oOeFo6sLYUJveYcdOozE2aiQA6 piSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682324792; x=1684916792; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3pxlWKD7dnb+hgIonOTuPgqaiGVvQd+hXe0K6IdPi2M=; b=eusI503znAvPc4ZboSXy5MPdPKY0IzqME1YGMbXkujHts/2klULRbjjWoTN4H4KFxw 8fhVmtE4askAR7M3qNY7jVhVUD/WaTG6F2jTU24cC+NkA3sgUc7aIm5HLoFGy3IfuSxj PdX4qlGt1tm7SJF8NoYb12YU0nRn4YNWhr5WMY0Ya3V6qZSnIIrXkC1obDypwpf8uMZp E8WDVbwNWUQLPw3mSsmywXsAKbZ4hJoRL7yYD9Z/GI7woJDUKmS7AK9pF2BDpTwmJytF FgdHBCzt0Zn/vfWDPKZVI71n/7H3KvpG9byw/PSJvr0mIi1ihVkpeQ2zPXnuW0cScnLu IOiA== X-Gm-Message-State: AAQBX9fgB1p3E/pkgEX2hqCJ69dFBXpBWKdSh4PcM4hmYVg3zUwNvttd I/NzSFs1IdU73HoizW+IpuUpDg== X-Google-Smtp-Source: AKy350byXoD5GzDBK8BfQEyK98TvcOHuQxalfYGEuCyUBUv+0C+wGb7Sf32jhfdSzffUY8tfHfxXdw== X-Received: by 2002:a05:600c:259:b0:3f1:662a:93d0 with SMTP id 25-20020a05600c025900b003f1662a93d0mr7829493wmj.15.1682324791970; Mon, 24 Apr 2023 01:26:31 -0700 (PDT) Received: from [192.168.178.55] (h082218028181.host.wavenet.at. [82.218.28.181]) by smtp.gmail.com with ESMTPSA id l20-20020a05600c16d400b003f19bca8f03sm4904838wmn.43.2023.04.24.01.26.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Apr 2023 01:26:31 -0700 (PDT) Message-ID: <42c89d18-b68f-a7d0-921a-6f45b54da356@linbit.com> Date: Mon, 24 Apr 2023 10:26:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 2/5] drbd: use PAGE_SECTORS_SHIFT and PAGE_SECTORS To: Luis Chamberlain , axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, hch@infradead.org, djwong@kernel.org, minchan@kernel.org, senozhatsky@chromium.org Cc: patches@lists.linux.dev, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, willy@infradead.org, hare@suse.de, p.raghav@samsung.com, da.gomez@samsung.com, kbusch@kernel.org References: <20230421195807.2804512-1-mcgrof@kernel.org> <20230421195807.2804512-3-mcgrof@kernel.org> Content-Language: en-US From: =?UTF-8?Q?Christoph_B=c3=b6hmwalder?= In-Reply-To: <20230421195807.2804512-3-mcgrof@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7B92AC0015 X-Stat-Signature: 61jnwzak4yz7fgwrpjhzem7wenhhhimw X-HE-Tag: 1682324793-492262 X-HE-Meta: U2FsdGVkX1+JDyBlxavdI+3lYlnO35vxDXS1gvSJnrJOK2XR4vFKV+eqrOPqqqfG+o4ejlGuJMLYlkS+3YF6Jli6vWUbb5F+z1buCbpDFSZLdhZyzQWqj+h7SkFUIVDF4jGRSGB1uTqHK954xNPlUy3O0B976Gw+X/dBQdpXnlYMRIgzHpymzBeiO+tFX6oFSGN1g1BdaPzaCx9vhqFZ8gTinKx71Ag/SGL8rie+x5szbmgT6h0vNIT1I56L2yMMukYssmfJ3aPd+NeiqOKoUNC/MiBS6V4X3CrwUZ2fMx72VWx0PXSU6yPOysskz+66bp7uaTz1w0yywO/NL3Rao7vQ4nX7f85/A2fyEUJxHvh7OZXsySSj7bWdLeDuNHhffCyP+Z42LW1VeriyEMG0uYUZAU7gmRR+gqMlpmjIsLYUhkSHTGMjS9zlPo6c8wMv3bpR7GjtjtyzASnt5KpWgn3KDmyPcma5ZMlh6EYKoTH9VLrbauojzHEQxbcyFt8XclZmsGviuc02WExJJfliODHX468HNSHUaiIaav2rFXWEsMKZn1WVAKEuuQvt7CORn8gf3vmNmEORwbL9cNuDRxphA9pqUgcWP3HOFiyuDjbYgCVY1d/QRFPypS4IdRIrCyZA0uGJnLC3nM5xPCv0AWigRBhyz41NTbT5Tu1v/Qrzr+ChfyCA57i8p61IcaOnaAy81vErrGG2Y+mxmCHP4szqQPECKsYPoANysRtz/C+6hS2vkp1KORZBp8TI/57nppHTlIsnIs3a0jn6xqLgYEkmK4mHxe6+EBOVQWUbVKzv10Il+eQLehrdNdfTnHylUEyrpdHApZyIEEIaG7S4Cd3ZQksOyzFEI1kWEQYp3GelZgBczlhul5JIepmKO4n11hEFvEIO02btDsc+YPcBXMDJHVofd424l4XAYEQo1vKnKXgd7NgcVO/L4TYOEChHz+gOmgyaZlJbg2cIpmU 3ubOm0d4 jCuLcRdZMtLGqBe8RaQl9LcBWHmoSH7AQPcU8e3omE6cI6FtdefAfoAO801WsuIuoH+Y3cuVI0KP46bDOG7cPKk5MdgVKtak9fmmmhs16ps5+O+j2akTanV6Y5GesElK1m3BC7nOoZ2bP8iAS5OBiFfpan5c4FajlSF4A92oGOXMGLoGGzK6w+Q3JNIt0AgPiAAeYSWJaPWJNDzu6ybuNFBscZz1CPTSosVwSa4L03RmnNiGLx1rJGln5DYz8YslQkOvpv5ReSbUxmYHl0wEK/XRhvfwV4bFXm01TmTUahpJdeTh4rMF4cDiy9+lXoSvVj0xBch17E4lqFcobInuxe7XOXKtmjX+b6us/q5LcPFb42xKOUIeNcG/JCGmOJxaIE12HnYdPqltZ0ryFWgGTFfAGw8ddrsJM7Nu+kzZHc15+A9cmjIM2De47iPrHE9ngqL8QnnCo1JOMHiVfa9o8w7CjyZgZ3018jcVP5yooVw4CXTNhd5rphumvjODJd2wB4/uE8kwTSwz5i5fzGKC7BSgo/fFXu2Y8k1FI08xleh08oitLDP88VsPJU7wyz6KaKIgfUB/vE74QrhU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Am 21.04.23 um 21:58 schrieb Luis Chamberlain: > Replace common constants with generic versions. > This produces no functional changes. > > Signed-off-by: Luis Chamberlain > --- > drivers/block/drbd/drbd_bitmap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/drbd/drbd_bitmap.c b/drivers/block/drbd/drbd_bitmap.c > index 6ac8c54b44c7..b556e6634f13 100644 > --- a/drivers/block/drbd/drbd_bitmap.c > +++ b/drivers/block/drbd/drbd_bitmap.c > @@ -1000,7 +1000,7 @@ static void bm_page_io_async(struct drbd_bm_aio_ctx *ctx, int page_nr) __must_ho > unsigned int len; > > first_bm_sect = device->ldev->md.md_offset + device->ldev->md.bm_offset; > - on_disk_sector = first_bm_sect + (((sector_t)page_nr) << (PAGE_SHIFT-SECTOR_SHIFT)); > + on_disk_sector = first_bm_sect + (((sector_t)page_nr) << PAGE_SECTORS_SHIFT); > > /* this might happen with very small > * flexible external meta data device, > @@ -1008,7 +1008,7 @@ static void bm_page_io_async(struct drbd_bm_aio_ctx *ctx, int page_nr) __must_ho > last_bm_sect = drbd_md_last_bitmap_sector(device->ldev); > if (first_bm_sect <= on_disk_sector && last_bm_sect >= on_disk_sector) { > sector_t len_sect = last_bm_sect - on_disk_sector + 1; > - if (len_sect < PAGE_SIZE/SECTOR_SIZE) > + if (len_sect < PAGE_SECTORS) > len = (unsigned int)len_sect*SECTOR_SIZE; > else > len = PAGE_SIZE; Acked-by: Christoph Böhmwalder -- Christoph Böhmwalder LINBIT | Keeping the Digital World Running DRBD HA — Disaster Recovery — Software defined Storage