From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E262C4332F for ; Mon, 21 Nov 2022 23:57:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D04126B0071; Mon, 21 Nov 2022 18:57:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CB4716B0073; Mon, 21 Nov 2022 18:57:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7C4B6B0074; Mon, 21 Nov 2022 18:57:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A999F6B0071 for ; Mon, 21 Nov 2022 18:57:51 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 75CFEC074F for ; Mon, 21 Nov 2022 23:57:51 +0000 (UTC) X-FDA: 80159114742.02.F726133 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf21.hostedemail.com (Postfix) with ESMTP id A39781C0005 for ; Mon, 21 Nov 2022 23:57:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669075070; x=1700611070; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ttMStxsbDlpMEs1D2wUgm8OuQh/Ime21MOFXRosoXV4=; b=kcf8WtMGlzmZo/wjs8Djvnx3wJW4Gir6qYVubL2ewdlxC7sm6p3MUS6r 0J90yUnGDVlo7Gn3Uf5Y00MLUPYBTIO4vhoegq94gPmh205qc9bE94qro Xe9tEaF+/jw5pX4V8Y405JXOh5B6bYzgnGYH9W4rrbRRM1ki9svMXP3zW 2LMW2tMhuFB3eWod9keHjYtaIPx8VAVeSBD2ZO0DSe07B0aZC4xUw/iNj NoBytp/9ftQDf9K26WImFOTG9UQGuFWHgTPRExWW7dl1X+psQkfISkl8F 3crJ4Hw0Ox965GpXqVqu+//LnoF015JW4Dj311o4AzIRWhX/sk7oXQsm5 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="399979694" X-IronPort-AV: E=Sophos;i="5.96,182,1665471600"; d="scan'208";a="399979694" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 15:57:49 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="730201151" X-IronPort-AV: E=Sophos;i="5.96,182,1665471600"; d="scan'208";a="730201151" Received: from dylanhol-mobl.amr.corp.intel.com (HELO [10.212.242.103]) ([10.212.242.103]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 15:57:47 -0800 Message-ID: <42bb1385-0c7f-6a87-43bb-ea4b12c48427@linux.intel.com> Date: Mon, 21 Nov 2022 15:57:45 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.4.2 Subject: Re: [PATCH v7 02/20] x86/virt/tdx: Detect TDX during kernel boot Content-Language: en-US To: "Huang, Kai" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "Hansen, Dave" , "Luck, Tony" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "kirill.shutemov@linux.intel.com" , "Christopherson,, Sean" , "Chatre, Reinette" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "Huang, Ying" , "Williams, Dan J" References: <3e4644e4-d939-7f15-02e1-a6be1ed7f932@linux.intel.com> <827adb3d1610f43ce71b1491db8c680dbe095035.camel@intel.com> From: Sathyanarayanan Kuppuswamy In-Reply-To: <827adb3d1610f43ce71b1491db8c680dbe095035.camel@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669075071; a=rsa-sha256; cv=none; b=TGVi0q7xTemn/AZqmqxghQA7YenCMQ+wKPjCvuB6srSXlQLfKqj8HJG7b/3QIWPOJVWz5e xi27bVeYnIva6QY+BEcUMuzCFyQgMnWiUrnXnHUC64twP3YEiiM54ZnZGFZSrdXgOU7cz3 XTq2C7Mq7jKcT/BGtcSPOKDy7UrAffg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=kcf8WtMG; spf=none (imf21.hostedemail.com: domain of sathyanarayanan.kuppuswamy@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=sathyanarayanan.kuppuswamy@linux.intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669075071; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z3PzjZRK8/hUDTMGP07rZigv6N9vP+DNRCqgtWRCYY0=; b=t+J8dsgnYoJANtWv7hinX30QdMSEu9eI7sshOvph+lkGHkhgIc9VKeTlrxVAfwR+5L3k1I uTC0QAq5qNY5xw2pS92mHg+qvwaVpzy5yqOco4EdHZ6eZrjr0zwqMdU14R+ygllvnVzB+j nPqIAEg+7AQRgt4E9A7Qd6e+iRg8Yx4= X-Rspam-User: X-Rspamd-Queue-Id: A39781C0005 Authentication-Results: imf21.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=kcf8WtMG; spf=none (imf21.hostedemail.com: domain of sathyanarayanan.kuppuswamy@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=sathyanarayanan.kuppuswamy@linux.intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) X-Stat-Signature: 55fyauccbzco5z419sc7he6xx13m7ocj X-Rspamd-Server: rspam10 X-HE-Tag: 1669075070-128761 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/21/22 1:37 AM, Huang, Kai wrote: >> Also why is this global variable? At least in this patch, there seems to >> be no use case. > Platform_tdx_enabled() uses tdx_keyid_num to determine whether TDX is enabled by > BIOS. > > Also, in the changlog I can add "both initializing the TDX module and creating > TDX guest will need to use TDX private KeyID". > > But I also have a comment saying something similar around ... > I am asking about the tdx_keyid_start. It mainly used in detect_tdx(). Maybe you declared it as global as a preparation for next patches. But it is not explained in change log. -- Sathyanarayanan Kuppuswamy Linux Kernel Developer