From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: David Hildenbrand <david@redhat.com>
Cc: Dev Jain <dev.jain@arm.com>,
akpm@linux-foundation.org, ziy@nvidia.com,
baolin.wang@linux.alibaba.com, Liam.Howlett@oracle.com,
npache@redhat.com, ryan.roberts@arm.com, baohua@kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] khugepaged: Optimize __collapse_huge_page_copy_succeeded() for large folios by PTE batching
Date: Wed, 18 Jun 2025 18:10:28 +0100 [thread overview]
Message-ID: <42aa7d12-3f84-4ee6-a067-5aee30ec677d@lucifer.local> (raw)
In-Reply-To: <738669ec-a9e5-4ba1-85a7-605cb4132d05@redhat.com>
On Wed, Jun 18, 2025 at 06:14:22PM +0200, David Hildenbrand wrote:
> On 18.06.25 12:26, Dev Jain wrote:
> > +
> > /*
> > * ptl mostly unnecessary, but preempt has to
> > * be disabled to update the per-cpu stats
> > * inside folio_remove_rmap_pte().
> > */
> > spin_lock(ptl);
>
> Existing code: The PTL locking should just be moved outside of the loop.
Do we really want to hold the PTL for the duration of the loop? Are we sure
it's safe to do so? Are there any locks taken in other functions that might
sleep that'd mean holding a spinlock would be a problem?
next prev parent reply other threads:[~2025-06-18 17:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 10:26 Dev Jain
2025-06-18 16:14 ` David Hildenbrand
2025-06-18 17:10 ` Lorenzo Stoakes [this message]
2025-06-18 17:23 ` David Hildenbrand
2025-06-18 17:26 ` David Hildenbrand
2025-06-19 3:54 ` Dev Jain
2025-06-18 17:26 ` Lorenzo Stoakes
2025-06-18 17:29 ` David Hildenbrand
2025-06-19 12:52 ` Lorenzo Stoakes
2025-06-19 3:22 ` Dev Jain
2025-06-19 12:53 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42aa7d12-3f84-4ee6-a067-5aee30ec677d@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox