From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <42F2266F.30008@yahoo.com.au> Date: Fri, 05 Aug 2005 00:30:07 +1000 From: Nick Piggin MIME-Version: 1.0 Subject: Re: [patch 2.6.13-rc4] fix get_user_pages bug References: <42F09B41.3050409@yahoo.com.au> <20050804141457.GA1178@localhost.localdomain> In-Reply-To: <20050804141457.GA1178@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Alexander Nyberg Cc: Linus Torvalds , Hugh Dickins , Martin Schwidefsky , Andrew Morton , Robin Holt , linux-kernel , linux-mm@kvack.org, Ingo Molnar , Roland McGrath , Andi Kleen List-ID: Alexander Nyberg wrote: > On Wed, Aug 03, 2005 at 09:12:37AM -0700 Linus Torvalds wrote: > > >> >>Ok, I applied this because it was reasonably pretty and I liked the >>approach. It seems buggy, though, since it was using "switch ()" to test >>the bits (wrongly, afaik), and I'm going to apply the appended on top of >>it. Holler quickly if you disagreee.. >> > > > x86_64 had hardcoded the VM_ numbers so it broke down when the numbers > were changed. > Ugh, sorry I should have audited this but I really wasn't expecting it (famous last words). Hasn't been a good week for me. parisc, cris, m68k, frv, sh64, arm26 are also broken. Would you mind resending a patch that fixes them all? Thanks, Nick -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org