From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <42F14D5F.7040603@yahoo.com.au> Date: Thu, 04 Aug 2005 09:03:59 +1000 From: Nick Piggin MIME-Version: 1.0 Subject: Re: [patch 2.6.13-rc4] fix get_user_pages bug References: <42F09B41.3050409@yahoo.com.au> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Linus Torvalds Cc: Hugh Dickins , Martin Schwidefsky , Andrew Morton , Robin Holt , linux-kernel , linux-mm@kvack.org, Ingo Molnar , Roland McGrath List-ID: Linus Torvalds wrote: > > On Wed, 3 Aug 2005, Nick Piggin wrote: > >>Oh, it gets rid of the -1 for VM_FAULT_OOM. Doesn't seem like there >>is a good reason for it, but might that break out of tree drivers? > > > Ok, I applied this because it was reasonably pretty and I liked the > approach. It seems buggy, though, since it was using "switch ()" to test > the bits (wrongly, afaik), Oops, thanks. > and I'm going to apply the appended on top of > it. Holler quickly if you disagreee.. > No that looks fine. Should really be credited to Hugh... well I guess everyone had some input into it though (Andrew, Hugh, you, me). It probably doesn't matter too much. Thanks everyone. -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org