From: <zijun_hu@htc.com>
To: akpm@linux-foundation.org, kuleshovmail@gmail.com,
ard.biesheuvel@linaro.org, tangchen@cn.fujitsu.com,
weiyang@linux.vnet.ibm.comtangchen@cn.fujitsu.com,
dev@g0hl1n.net, david@gibson.dropbear.id.au, tj@kernel.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH] mm/memblock.c: fix index adjustment error in __next_mem_range_rev()
Date: Mon, 25 Jul 2016 07:34:12 +0000 [thread overview]
Message-ID: <42A378E55677204FAE257FE7EED241CB7E8EF004@CN-MBX01.HTC.COM.TW> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 1266 bytes --]
Hi All,
There is a bug in mm/memblock.c
Could you review and phase-in this patch?
Thanks a lot
From 3abf1822d30f77f126bd7a3c09bb243d9c17a029 Mon Sep 17 00:00:00 2001
From: zijun_hu <zijun_hu@htc.com>
Date: Mon, 25 Jul 2016 15:06:57 +0800
Subject: [PATCH] mm/memblock.c: fix index adjustment error in
__next_mem_range_rev()
fix region index adjustment error when parameter type_b of
__next_mem_range_rev() == NULL
Signed-off-by: zijun_hu <zijun_hu@htc.com>
---
mm/memblock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memblock.c b/mm/memblock.c
index ac12489..b14973e 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -1024,7 +1024,7 @@ void __init_memblock __next_mem_range_rev(u64 *idx, int nid, ulong flags,
*out_end = m_end;
if (out_nid)
*out_nid = m_nid;
- idx_a++;
+ idx_a--;
*idx = (u32)idx_a | (u64)idx_b << 32;
return;
}
--
1.9.1
Zijun Hu
Tel: +86 021 3813 0008 Ext: 8556
F1 Building, 299 Kang Wei Road, Pudong New Area,
Shanghai 201315, China
htc.com
[-- Attachment #1.2: Type: text/html, Size: 9586 bytes --]
[-- Attachment #2: 0001-mm-memblock.c-fix-index-adjustment-error-in.patch --]
[-- Type: application/octet-stream, Size: 806 bytes --]
From 3abf1822d30f77f126bd7a3c09bb243d9c17a029 Mon Sep 17 00:00:00 2001
From: zijun_hu <zijun_hu@htc.com>
Date: Mon, 25 Jul 2016 15:06:57 +0800
Subject: [PATCH] mm/memblock.c: fix index adjustment error in
__next_mem_range_rev()
fix region index adjustment error when parameter type_b of
__next_mem_range_rev() == NULL
Signed-off-by: zijun_hu <zijun_hu@htc.com>
---
mm/memblock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memblock.c b/mm/memblock.c
index ac12489..b14973e 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -1024,7 +1024,7 @@ void __init_memblock __next_mem_range_rev(u64 *idx, int nid, ulong flags,
*out_end = m_end;
if (out_nid)
*out_nid = m_nid;
- idx_a++;
+ idx_a--;
*idx = (u32)idx_a | (u64)idx_b << 32;
return;
}
--
1.9.1
next reply other threads:[~2016-07-25 7:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 7:34 zijun_hu [this message]
2016-07-25 18:52 ` Tejun Heo
2016-07-26 15:03 ` zijun_hu
2016-07-26 16:50 ` Tejun Heo
2016-07-26 15:09 ` 答复: " zijun_hu
2016-07-27 6:49 zijun_hu
2016-07-27 17:36 ` Tejun Heo
2016-07-27 7:12 zijun_hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42A378E55677204FAE257FE7EED241CB7E8EF004@CN-MBX01.HTC.COM.TW \
--to=zijun_hu@htc.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tangchen@cn.fujitsu.com \
--cc=weiyang@linux.vnet.ibm.comtangchen \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox