From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA837C00A8F for ; Tue, 24 Oct 2023 07:55:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF8BC6B018D; Tue, 24 Oct 2023 03:55:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA7816B018E; Tue, 24 Oct 2023 03:55:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96FE16B018F; Tue, 24 Oct 2023 03:55:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 846CF6B018D for ; Tue, 24 Oct 2023 03:55:36 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 51DB71CBA4F for ; Tue, 24 Oct 2023 07:55:36 +0000 (UTC) X-FDA: 81379595472.08.8871B54 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf16.hostedemail.com (Postfix) with ESMTP id 7AE4218001C for ; Tue, 24 Oct 2023 07:55:34 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="m3OJ/Phi"; spf=pass (imf16.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698134134; a=rsa-sha256; cv=none; b=Xn89i5GIFXndTPlwvUFi1zlqkAxSEDePN3C3/7oHNe0c+TZ7Nww6ysk+tUCDrSs70BebpQ 51PcajrC6PaDM6+tmy2p9Uv7KqnWoos+5gyD+AEnqhJGSh0TA6zaEovArbBjiUpr9KTGvX 4cljf9ejv4E8wECZxoG/GCC0cpKJs5k= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="m3OJ/Phi"; spf=pass (imf16.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698134134; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=rryMd0X9WV6QFu55eyAQUdUJEIXyug/kgmEK9WWRvfQ=; b=bDM/YQlbzB2dr8C5qPpqU3plfF07gAUzp7Q1PZb0rQVqPJ1EiX8brzOeITMXNpBubEI5cu RnggacQuCry0vrT30EqukTkEcOlkf1e1EUIrjRBZq4cXL3fquSh/6idQXp7baRCX4ANvSB kFQ83JlYZ6kEZ4+iJ+LAMIgLkUFDcDQ= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1caa7597af9so25628345ad.1 for ; Tue, 24 Oct 2023 00:55:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698134133; x=1698738933; darn=kvack.org; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=rryMd0X9WV6QFu55eyAQUdUJEIXyug/kgmEK9WWRvfQ=; b=m3OJ/PhirZei+gpK8N3gqrBYqRLqZZ4Xw9fDGSFV5RBlUpgZWsvPyQd9KiYaWLmmlm cDP61Wa33Fw8oIOga8o9rTTHe85GeT8ilt+FvRCvr4j1NyVSHEKI/CneIU+TXJrWVexo ynrp8gR3U6BRdZPl4V5MF4q1vrx3ReyJeWSqBVhKuaVOhvCbmYr/QmCxIW+ZYkRTb3qb KBG4f9M8FVeIFm9Or9UBr1sMuNqweeK8TnysAkzkVUDOFT27NE57u4PScagS9RGFDfLp 1PlcdSZllIW3lRr7S3/Ye01IGZ73kxxjSzBNVM+q5K49fggcqpQ7hGSJ+7AXohswtg6X 9dKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698134133; x=1698738933; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rryMd0X9WV6QFu55eyAQUdUJEIXyug/kgmEK9WWRvfQ=; b=onLFM4mUJATPcl6+1fJKAgFeilsTTg157/PFMbIFC3B0aU0L42HolIT+ee7n9wd6tE 3j7iUA8A/IpmXDK6QJ2R2YvGFBIxzUg9kKw8QN/ala74BybpyrFci75/dUv0Kri3ylPT oVbUuNKqzKiD4AjltkqY2QIfzBOQB6GLAV4Tw1/s/t8NEC/LSa/KK+gDCTQuA7o4qA4K ES9cpX+q9ARiSkXYUYQPobYdf1zpcaXVOHt44xOUwDM6LWS9O55h0poIX6IlVnPoeZNO V2Drk+77n29v6lyRWQEXQG73W8HwTCxb75PqcGRySVBq39x54TFc5D9ScX0sawCNHK6y hn6w== X-Gm-Message-State: AOJu0Yx2mnBG873cCAKUdlSDuJ3dfyhZqeI8Y/XkTxUMzURFDcNbNZFd OYw62+FHfHOySLg1CyDumi8= X-Google-Smtp-Source: AGHT+IFzIRaOleX12I4ui38DgrzuR5MDHSegKCH+0WDtTjaT5p3P/qRLJ2gPYCdahRV3qCjph6dhEw== X-Received: by 2002:a17:902:ca0b:b0:1c4:72c9:64ef with SMTP id w11-20020a170902ca0b00b001c472c964efmr7090388pld.40.1698134133184; Tue, 24 Oct 2023 00:55:33 -0700 (PDT) Received: from [192.168.0.106] ([103.131.18.64]) by smtp.gmail.com with ESMTPSA id iy17-20020a170903131100b001ca86a9caccsm7051112plb.228.2023.10.24.00.55.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Oct 2023 00:55:32 -0700 (PDT) Message-ID: <429b452c-2211-436a-9af7-21332f68db7d@gmail.com> Date: Tue, 24 Oct 2023 14:55:27 +0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Linux Kernel Mailing List , Linux Memory Management List , Linux Filesystem Development , Linux Regressions Cc: Chuck Lever , Christian Brauner , Alexander Viro , Andrew Morton , vladbu@nvidia.com From: Bagas Sanjaya Subject: Fwd: Memleaks in offset_ctx->xa (shmem) Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7AE4218001C X-Stat-Signature: cybhijypmgnqt9boskfq8j5shau3ocf5 X-Rspam-User: X-HE-Tag: 1698134134-753121 X-HE-Meta: U2FsdGVkX195nlXr4PKznHZnqkCIcJeWuoHbEr6a5cFlPB5uJwgmofY291x3CpPqC//HPFw1M4UUuQeoFFjwvXkkcywjQWsFNGn/zN3wmBDKJIh24zVjkQ6ZQbkodmbyADe4+KfVmgvTWoCDgzb+QgpVFwFNwVpUgn24yzHE1he3YVYllFviS7n5bhNmjfPhlf6Zukle9S1aILNTcm6/S+dt4koJ9kNhSFg2Zo8Wo3cTOVCRLGtBIiL+i8xzNgptQ4F+ZXM2SRSUWXACzxqsmv452L4tAkHu9gtfyf8xPwZg+Efh75+b43+LoUam3E+Z0e2J0lOH2Q1q+aIYzYFGCC3BZZitIbHFBSwYlNiXRAjq+jXqq5f9iLgTlBp6qWU+rghx5u2AUYux5Bo5xyW+KG5u9GAbEfv/y0AQVwG5QmqfBPpIG+065p12xCWi3HSpaTRlJgdwQ1kdF6jX1HLJG/pgni9Yw/AvQUMY9o+CB5eddBlwu1HCvBHccthGUe1RKy2sMEt+IWvBHB/Ai5i/lE5/W9E7XnmL3lz0topm3u1xJ+ryWV5WVxXnAJFnRmm9HLxYtTjweR27R6vknoFsPQOZ3h5aIlqjDL9qqAezovGpNN/qYXZ0LyoiJpFwR1k2fnGpSpNp21ZgpVn0B+RI3QBZJW1Jq+PUv0soOzHuQ16MElUuILKSFy2EXALHr0LJ9AkqkRM3N/g7iiM3/0bNnj6n/uUduLGTMSg+Iv33xuzspPUdB7NUjOwUBZEOGFfM6eBh6XdmBAJaisEythTHnxhdT3LSRSznO31Q161/oTBuEODgopQIF0zQWr2geNFCUnnSHAbK9RFmyhPYNhlCMWth6PkHTjWNMZRWTrPJ90kA/c01XmgWW/8FzHXr6Bl16mgbBwCIlUnOMZBIN4EZ09aD0frU3XYSVi27XZJSOiWVMaWlBgqabyV8EU5rp0VfzCSL61nmnwvIomQUbul Fofzqg5d osqfAXFudzP4eB4Ou19ndFcn4YpVVZ/5UnHXE6cRTJh/XkwmX3Sljh1wIgn7ke5G6kgxnjtpLORIFgDgJeNCroKCzbBAjmIyxocBn0QedRS7puPD0aKDB0VbxSClLPs7m1q6vf4iG7+ZAV8UnMjZ9UOrIMMBHmx12C3gO83BRYHjQzxvC7XtVtmy5/j9lY10PWG/GDqZ8rqe+hpdpP4RXJKVDVk/8PBYGCwDZIS5YP8k6Jph4VraoS1bL5JFOkzyp0f5R4YKIc/QlvRnS7mYerK3Y+1erOdvo9HMWuGWWC3koVELXCpW/QGx3TEU1vPfTTFhdNMpOzxF5FngPuH6iyiktajgrI0cI9li0R8jluLhyivOjCuj7OnsYE2RGXJqrJMgK0PRB3QFDPOQC/2rcUB1wb06GYHLxSpi7REs8TKQttB9PvcrhCO1PMJgtCw4fuE67mJx1+MBRXguMA7H6DbtTzW+pgSpmjSvOKCT4C1OHX8eZTIbDttJIHy3ebNiYvPiDI8Fuw7jVJGg4W1eMttqYaEM7cPq8MxJy66u/ENGlVhReRn8JO3UkVtZcgmem+qHg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, I notice a regression report on Bugzilla [1]. Quoting from it: > We have been getting memleaks in offset_ctx->xa in our networking tests: > > unreferenced object 0xffff8881004cd080 (size 576): > comm "systemd", pid 1, jiffies 4294893373 (age 1992.864s) > hex dump (first 32 bytes): > 00 00 06 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > 38 5c 7c 02 81 88 ff ff 98 d0 4c 00 81 88 ff ff 8\|.......L..... > backtrace: > [<000000000f554608>] xas_alloc+0x306/0x430 > [<0000000075537d52>] xas_create+0x4b4/0xc80 > [<00000000a927aab2>] xas_store+0x73/0x1680 > [<0000000020a61203>] __xa_alloc+0x1d8/0x2d0 > [<00000000ae300af2>] __xa_alloc_cyclic+0xf1/0x310 > [<000000001032332c>] simple_offset_add+0xd8/0x170 > [<0000000073229fad>] shmem_mknod+0xbf/0x180 > [<00000000242520ce>] vfs_mknod+0x3b0/0x5c0 > [<000000001ef218dd>] unix_bind+0x2c2/0xdb0 > [<0000000009b9a8dd>] __sys_bind+0x127/0x1e0 > [<000000003c949fbb>] __x64_sys_bind+0x6e/0xb0 > [<00000000b8a767c7>] do_syscall_64+0x3d/0x90 > [<000000006132ae0d>] entry_SYSCALL_64_after_hwframe+0x46/0xb0 > > Memleak trace points to some syscall performed by systemd and none of our tests do anything more advanced with it than 'systemctl restart ovs-vswitchd'. Basically it is a setup with Fedora and an upstream kernel that executes bunch of network offload tests with Open vSwitch, iproute2 tc, Linux bridge, etc. > > It looks like those may be caused by recent commit 6faddda69f62 ("libfs: Add directory operations for stable offsets") but we don't have a proper reproduction, just sometimes arbitrary getting the memleak complains during/after the regression run. See Bugzilla for the full thread. Anyway, I'm adding it to regzbot: #regzbot introduced: 6faddda69f623d https://bugzilla.kernel.org/show_bug.cgi?id=218039 #regzbot title: stable offsets directory operation support triggers offset_ctx->xa memory leak Thanks. [1]: https://bugzilla.kernel.org/show_bug.cgi?id=218039 -- An old man doll... just what I always wanted! - Clara