From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06E96C7115A for ; Wed, 18 Jun 2025 17:42:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9AB166B0095; Wed, 18 Jun 2025 13:42:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 934516B00D1; Wed, 18 Jun 2025 13:42:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FC526B00AB; Wed, 18 Jun 2025 13:42:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6CFAA6B0095 for ; Wed, 18 Jun 2025 13:42:22 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 46F5B1A08DB for ; Wed, 18 Jun 2025 17:42:22 +0000 (UTC) X-FDA: 83569240524.15.0E822DE Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by imf05.hostedemail.com (Postfix) with ESMTP id 530A910000D for ; Wed, 18 Jun 2025 17:42:20 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=MHd9zs8s; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf05.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.210.48 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750268540; a=rsa-sha256; cv=none; b=MtsjRpG4cgXUSch+O54Oeuv5JHtcEgJWMCaPHdhstqow4TBnsWYOABa/m0FHiuWLJrtH7d 7n2ZvOziAl6jzy/nsBPhCUlKOcQ5vi93tP33uzRCAQQaG6VCen93XpNcySdMuD0rQhtx8M 3+zhJZP8ywp0MtlJEEuFUakkC1zlEFQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=MHd9zs8s; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf05.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.210.48 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750268540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=ALQlJ1RqfpncfV715L7OdUSgYhmYfcG/SeD8Mhl1jzk=; b=QT+QQheSVBPptMk5L++e+jvuShxp+TraX+bhyJIhgP9oDQvp1aqIrn8HrNZrozNOa3ZKwG 1llaTUyaauM+BdoIx0J2kGD1UZSzQ1AfuC0p68vWxMd2BZWZche74uvToz3VZ9u2JSYmUD /N0JjByvQlBSDqDcP8s+CtJMalUJh6M= Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-72c3b863b8eso4997194a34.2 for ; Wed, 18 Jun 2025 10:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750268539; x=1750873339; darn=kvack.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=ALQlJ1RqfpncfV715L7OdUSgYhmYfcG/SeD8Mhl1jzk=; b=MHd9zs8sr0yKU8625GDCWOpl0kRX4UfP41fq3ZR/6fao+529p7yt9YnSEfV0lbCojk wXuzi4iQIzf0tld3P8kPvPuAjpbrVn2yyFMdXsrHjvEhKJNN2w9FpUrQbTbqjOMOnA1a NmxKqL7jlbITVr59pSjZRs57f2/HZtOdgPvxaJ/qTWgudUBceM1LqUKv4v2/bDllw7tT VDvN4veNXbFBPyvaSBcUWl6CqZVatt2LwWlzAh2Dy7Rx4232VGq+Kq/Yaa3RiYNpH4J+ fStxn2iQJmec+r+jmzAb0/WtTLfQdYm/167JP7imX0KB3Niejo1ziQ4LS8qvKC2pc/2S HH+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750268539; x=1750873339; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ALQlJ1RqfpncfV715L7OdUSgYhmYfcG/SeD8Mhl1jzk=; b=I6Iq86GdzIS8YP2CbHOVRW1qGoLJSQCodke2NeY6oCQ2BFZa4k+zhw1YmKBqIh/7NR hdb53bmlL2faaROqgv3IOxj8APcP/XolF/HM3m1WPcHNy3MFJgM+69J5q6s/sLlt5UcX T/ERMe3xNmdBGeatqWAJ08fXQMqDxIHh/CYPArKSbItbNu8UJeIR3ITeod8/BOz7GMaJ fGVFMfhPqfRCkeyxejcaEeg8RKD2dLl2m1qFP3yH66beyol/YW4xAYB7I56BUU7jauok 80GUQmlyjBZaMDC8Qo5DI1kYTDV/mQcGYuWZUJz+e+FINY8zlH2fLLypgohQUNi0Muku 23pQ== X-Forwarded-Encrypted: i=1; AJvYcCU93yBNYZNP4+TDJeFCaB0gDhEOvY1Ckk2yjwCgYKwLA2JRG34Dc8ucHwXTM3Teb1ChjAsR/rFe1A==@kvack.org X-Gm-Message-State: AOJu0YxhTf+ic4E7gCfxz9Z0IQf47R7K5a4FD92pM4362KIldAw84AmC YFRIF2YCaPG03kjZhFBj2J5vKoRo18hFW8eCJ+mee/fO2hPcz31lDe+KmUE9piEqBwQ= X-Gm-Gg: ASbGncsd2GFKHjS2BUj52IDAa34wfWa0r1iJBYu4VRNvNju14feA6cmuRPWd7PFTnU/ dB1opYBzZozwMmrLWH9WAOLycczJIBE7bEnEwzW0B4/SZYTSLlrWfjuFglG3YpmslO+Myd9SNUU +TLMO0cVvRSrtjGj97mhB9fuUB2WtBx17xvCh5Jn6cObajX2AM8pfRNZkvCvMykgCjrCTcfOKwv WWFd7KxWOE4hk7rvTfWJB2+cKAu3uB7zO1HaEx97ONHICMaAypUZcLmPyTI0R3EvFO7ZXxbX8JM iKuV2RK3/PD+nu7Bdfx2wseGLJ1YGVbz/0sdTZiTSZ5wDunbLPNNaYAvZPKDydJmJxD9MQ== X-Google-Smtp-Source: AGHT+IFFFmB4u98R4eAo2rUrAWhzhlCaoI+JO8SWCcz50Wh9AA3SCYViXrulit3sJ5S4KHyxDHKWTw== X-Received: by 2002:a05:6830:8218:b0:72c:10d5:783e with SMTP id 46e09a7af769-73a3627941cmr9790083a34.10.1750268539221; Wed, 18 Jun 2025 10:42:19 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:1b3b:c162:aefa:da1b]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-73a284febb6sm2055391a34.37.2025.06.18.10.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jun 2025 10:42:18 -0700 (PDT) Date: Wed, 18 Jun 2025 20:42:17 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Zi Yan Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List , Baolin Wang Subject: mm/shmem.c:2223 shmem_split_large_entry() error: uninitialized symbol 'entry_order'. Message-ID: <428fa0fe-8960-4566-9054-5bfd967c18c8@suswa.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Queue-Id: 530A910000D X-Rspamd-Server: rspam10 X-Stat-Signature: rnrew97j6merki3u7gttr8fbw78pfk7b X-HE-Tag: 1750268540-874955 X-HE-Meta: U2FsdGVkX1+/XCKCZnOTFkARRKyaUAHlQz32yofA1m78nzjlM8BORFdJEdKL0fpahIHavzO8xFzezcaHfGjxJZiamE4BdzM/yCedwt4nnDtlcCbuFP411EqeDPVdPV5yluEpoqgV2MraX5HXMUOsvqlED+byRaGVH91Tf5wgp1kaHzEp1XrghLKuAAwn4p7OmkCov21bQf9kDIULtOldjnCF3fd48dQlxTOmiOTnJD5Dqsrqqz408nf082ozvgK0i6+atYY2+jNtVcBWWAspEMHtcC2vuF2xhnF0O8iNv8Q1YKDmBDv10I3WMz9DeyKIaS9cN9lUdPR+1qvttqcvLkUjmCD8IfHlwvt6srN1WC159ktQAWisC1JseoRj7aMDt+Eu4KI9Z5vX/1X1wA9qJlA3UemAEGRLdSRKsHnJu5xogFKVptgi5TuZkg4UuogfLmBVp+UypqgIOlSi8BND7bZzKZRHZmju2YqT7U3XIpMfbpp7SjGNDvoDV3C8SWoE0kLi3Z4PntN4urSSLnNfuhnQtAM2Zjkwe/hdi2qTQxIZ+JhPA4UOMa0y6ql2LnOBx5SNcRDtGi1DUc4IIkHPslHeyXsF89DD94HrWn5NM3v/xg4Ahy0CREcH7r5INr2lkXquYLPwhQs8gkp7cjmaawimxFdSJImDZEF3dBCoHcHNUHQ/LIurpAXc8EB3msRR+wJL6xIDqPwD7mbdjuVoXgVmePO6TYXeXVrp9QDNYn6sIuSctO0E1cn/mZRyOF4BGWFV6V3YnVuvbMZr8W4seklSr4K9MpWZYsu6IAJcTNPeBpU7XwRsvbDmS+wuLPOpGwVTJMAYAIqlYm4u80CEp/I9hq44Ss7lkuLWbSmredURi1nEjNF/ri+WKFu5XL1oka1pnKbrZt/gjDzCi5TfrQDQ1S9qfKYwA5Z5QvwGY98W2XNQoFMzfzqijsFRfdG3valS2fMiGIk1XJkGhZm ibUOAFtG loX9N+MSYV8ILVByDPvHjaz5rirZgpZD3xhqhhKYkPq6BgqjnNO46+n+mCm0rO906om55UPZvTwC+AzOp6VLR+4TnLA3gMbNEr+OBQwiiWMPBOotq6qC2RhRtFi6UfDiA+iOugeLRq7Vo/XZQc++DRYn8JaX2iF3tpPQINC6aJoi0urBTfHoibzWt4vj9lK77pEes5BriXcwDwmcNy6jAgqK1WrOg/31U2xAKkuG0PfGuuQV/1f4Hf8NpP8GS5nuyHB24yjnIpY0tMI1ex3L4pBEo9FuSyVbMHyWqg2VKN7nn5m+E3vNS07ZIbl3uKPeqGPOonbJjipINbRYnLItLiUJm3RfV3VLqDBv2X9SWSze87quF887zo0nO0sTccOG7TrjTfgFROG+9ziP5HfLs8FTHfGkfMuyyswVWwR4As78epaGZzcu5liluoILtgtVS8F55J0tMEf5bT4xrbrBk3bZsFillnC4p0a4HyzjPUK9EH3PrDlT9QGTvI0Sh3WNQkEvRMs+KQrkf6z4nHUFzVjnAUKZtrxVJhZBvjC8mWvoaaG4A4GHA66CqBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4774cfe3543abb8ee98089f535e28ebfd45b975a commit: d53c78fffe7ad364397c693522ceb4d152c2aacd mm/shmem: use xas_try_split() in shmem_split_large_entry() config: x86_64-randconfig-161-20250614 (https://download.01.org/0day-ci/archive/20250614/202506141535.tjdnCMqW-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202506141535.tjdnCMqW-lkp@intel.com/ smatch warnings: mm/shmem.c:2223 shmem_split_large_entry() error: uninitialized symbol 'entry_order'. vim +/entry_order +2223 mm/shmem.c 12885cbe88ddf6 Baolin Wang 2024-08-12 2151 static int shmem_split_large_entry(struct inode *inode, pgoff_t index, 12885cbe88ddf6 Baolin Wang 2024-08-12 2152 swp_entry_t swap, gfp_t gfp) 12885cbe88ddf6 Baolin Wang 2024-08-12 2153 { 12885cbe88ddf6 Baolin Wang 2024-08-12 2154 struct address_space *mapping = inode->i_mapping; 12885cbe88ddf6 Baolin Wang 2024-08-12 2155 XA_STATE_ORDER(xas, &mapping->i_pages, index, 0); d53c78fffe7ad3 Zi Yan 2025-03-14 2156 int split_order = 0, entry_order; d53c78fffe7ad3 Zi Yan 2025-03-14 2157 int i; 12885cbe88ddf6 Baolin Wang 2024-08-12 2158 12885cbe88ddf6 Baolin Wang 2024-08-12 2159 /* Convert user data gfp flags to xarray node gfp flags */ 12885cbe88ddf6 Baolin Wang 2024-08-12 2160 gfp &= GFP_RECLAIM_MASK; 12885cbe88ddf6 Baolin Wang 2024-08-12 2161 12885cbe88ddf6 Baolin Wang 2024-08-12 2162 for (;;) { 12885cbe88ddf6 Baolin Wang 2024-08-12 2163 void *old = NULL; d53c78fffe7ad3 Zi Yan 2025-03-14 2164 int cur_order; d53c78fffe7ad3 Zi Yan 2025-03-14 2165 pgoff_t swap_index; 12885cbe88ddf6 Baolin Wang 2024-08-12 2166 12885cbe88ddf6 Baolin Wang 2024-08-12 2167 xas_lock_irq(&xas); 12885cbe88ddf6 Baolin Wang 2024-08-12 2168 old = xas_load(&xas); 12885cbe88ddf6 Baolin Wang 2024-08-12 2169 if (!xa_is_value(old) || swp_to_radix_entry(swap) != old) { 12885cbe88ddf6 Baolin Wang 2024-08-12 2170 xas_set_err(&xas, -EEXIST); 12885cbe88ddf6 Baolin Wang 2024-08-12 2171 goto unlock; Imagine we hit this goto on the first iteration 12885cbe88ddf6 Baolin Wang 2024-08-12 2172 } 12885cbe88ddf6 Baolin Wang 2024-08-12 2173 d53c78fffe7ad3 Zi Yan 2025-03-14 2174 entry_order = xas_get_order(&xas); 12885cbe88ddf6 Baolin Wang 2024-08-12 2175 d53c78fffe7ad3 Zi Yan 2025-03-14 2176 if (!entry_order) d53c78fffe7ad3 Zi Yan 2025-03-14 2177 goto unlock; 12885cbe88ddf6 Baolin Wang 2024-08-12 2178 12885cbe88ddf6 Baolin Wang 2024-08-12 2179 /* Try to split large swap entry in pagecache */ d53c78fffe7ad3 Zi Yan 2025-03-14 2180 cur_order = entry_order; d53c78fffe7ad3 Zi Yan 2025-03-14 2181 swap_index = round_down(index, 1 << entry_order); d53c78fffe7ad3 Zi Yan 2025-03-14 2182 d53c78fffe7ad3 Zi Yan 2025-03-14 2183 split_order = xas_try_split_min_order(cur_order); d53c78fffe7ad3 Zi Yan 2025-03-14 2184 d53c78fffe7ad3 Zi Yan 2025-03-14 2185 while (cur_order > 0) { d53c78fffe7ad3 Zi Yan 2025-03-14 2186 pgoff_t aligned_index = d53c78fffe7ad3 Zi Yan 2025-03-14 2187 round_down(index, 1 << cur_order); d53c78fffe7ad3 Zi Yan 2025-03-14 2188 pgoff_t swap_offset = aligned_index - swap_index; d53c78fffe7ad3 Zi Yan 2025-03-14 2189 d53c78fffe7ad3 Zi Yan 2025-03-14 2190 xas_set_order(&xas, index, split_order); d53c78fffe7ad3 Zi Yan 2025-03-14 2191 xas_try_split(&xas, old, cur_order); d53c78fffe7ad3 Zi Yan 2025-03-14 2192 if (xas_error(&xas)) 12885cbe88ddf6 Baolin Wang 2024-08-12 2193 goto unlock; 12885cbe88ddf6 Baolin Wang 2024-08-12 2194 12885cbe88ddf6 Baolin Wang 2024-08-12 2195 /* 12885cbe88ddf6 Baolin Wang 2024-08-12 2196 * Re-set the swap entry after splitting, and the swap 12885cbe88ddf6 Baolin Wang 2024-08-12 2197 * offset of the original large entry must be continuous. 12885cbe88ddf6 Baolin Wang 2024-08-12 2198 */ d53c78fffe7ad3 Zi Yan 2025-03-14 2199 for (i = 0; i < 1 << cur_order; d53c78fffe7ad3 Zi Yan 2025-03-14 2200 i += (1 << split_order)) { 12885cbe88ddf6 Baolin Wang 2024-08-12 2201 swp_entry_t tmp; 12885cbe88ddf6 Baolin Wang 2024-08-12 2202 d53c78fffe7ad3 Zi Yan 2025-03-14 2203 tmp = swp_entry(swp_type(swap), d53c78fffe7ad3 Zi Yan 2025-03-14 2204 swp_offset(swap) + swap_offset + d53c78fffe7ad3 Zi Yan 2025-03-14 2205 i); 12885cbe88ddf6 Baolin Wang 2024-08-12 2206 __xa_store(&mapping->i_pages, aligned_index + i, 12885cbe88ddf6 Baolin Wang 2024-08-12 2207 swp_to_radix_entry(tmp), 0); 12885cbe88ddf6 Baolin Wang 2024-08-12 2208 } d53c78fffe7ad3 Zi Yan 2025-03-14 2209 cur_order = split_order; d53c78fffe7ad3 Zi Yan 2025-03-14 2210 split_order = xas_try_split_min_order(split_order); 12885cbe88ddf6 Baolin Wang 2024-08-12 2211 } 12885cbe88ddf6 Baolin Wang 2024-08-12 2212 12885cbe88ddf6 Baolin Wang 2024-08-12 2213 unlock: 12885cbe88ddf6 Baolin Wang 2024-08-12 2214 xas_unlock_irq(&xas); 12885cbe88ddf6 Baolin Wang 2024-08-12 2215 12885cbe88ddf6 Baolin Wang 2024-08-12 2216 if (!xas_nomem(&xas, gfp)) 12885cbe88ddf6 Baolin Wang 2024-08-12 2217 break; And we hit this break. 12885cbe88ddf6 Baolin Wang 2024-08-12 2218 } 12885cbe88ddf6 Baolin Wang 2024-08-12 2219 12885cbe88ddf6 Baolin Wang 2024-08-12 2220 if (xas_error(&xas)) 12885cbe88ddf6 Baolin Wang 2024-08-12 2221 return xas_error(&xas); 12885cbe88ddf6 Baolin Wang 2024-08-12 2222 d53c78fffe7ad3 Zi Yan 2025-03-14 @2223 return entry_order; 6cec2b95dadf77 Miaohe Lin 2022-05-19 2224 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki