From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A464BE7849A for ; Mon, 2 Oct 2023 10:59:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2337B8D0018; Mon, 2 Oct 2023 06:59:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E31F8D0001; Mon, 2 Oct 2023 06:59:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AAE48D0018; Mon, 2 Oct 2023 06:59:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EC9B08D0001 for ; Mon, 2 Oct 2023 06:59:46 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 93E20120225 for ; Mon, 2 Oct 2023 10:59:46 +0000 (UTC) X-FDA: 81300225972.22.A76FDD7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 402A01A0014 for ; Mon, 2 Oct 2023 10:59:44 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AHkfmQS+; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696244384; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eNg3nEOpUwhfLtl4Gfv+d61zrXncWfZX/sb9x36c/O4=; b=LiTRr1YLtCez7nc82NWPmiZC0ujNQEFBXYXBfg0tpzqvhrJWdIml4P9zmbsk0/uPsNU+ne 99OiHKUzkMzrwtfnXSPkSPbiH5AgE1+pLkJ+b2XL+J2Bha+4XMH37wymc+F3FaxdFoy/e3 ZXOVTYyun6QMOxoL5nutXsXDrn4GWco= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696244384; a=rsa-sha256; cv=none; b=uiSeIBFyAWtI0n/iMYLP8Rj8Y7O3oMtCN/DEZ1TII52WXzaB6eGV5EEJGvFe2JRmAzH/WC 7eSyZAwTlcKXJgG62Ov6EXlVodndfWFuoGpQOXDbmQ9D0U6RV6DUAubJAPMLoVmN+L05IY ug6I8/pRhLlgO5EQepOQwl5N0Rgefok= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AHkfmQS+; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696244383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eNg3nEOpUwhfLtl4Gfv+d61zrXncWfZX/sb9x36c/O4=; b=AHkfmQS+EVNqXjuyWh5QQ+ubfx1ru3x/oJv4c2x90i3eSelEuuMQzDqw1rRrLr6ebRFVo/ 4W6buqWI/nRdADZAAtdX0diPp4i2Y+lb8WiJHVjgxUz5KIQ9pRZirSG7PL+bRjN4oJwBge ZQFbDZ9ja2VgsoigR3+PzvuVf19Af88= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-271-5U9h6dikM5KmjN1ephht9g-1; Mon, 02 Oct 2023 06:59:27 -0400 X-MC-Unique: 5U9h6dikM5KmjN1ephht9g-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-327cd5c7406so566538f8f.3 for ; Mon, 02 Oct 2023 03:59:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696244366; x=1696849166; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eNg3nEOpUwhfLtl4Gfv+d61zrXncWfZX/sb9x36c/O4=; b=TYAgkCmcAGS5qLfvIrwk8GbRcoRK3UXBqKV3cn7iDx8XMEn0+AI2ygSBV/06R6Q/nr 7YWA5qS7Vh27QZfgqSHc0kfspunYObqMTZpGTNwqjLioz09AjVruZJTAErObMfMp1J/2 FlZwmC2+90RaTA5eibXwSyOdX61W4O1SyVCa/oqUy1REuqgUKLI+c0mC/cJYyMn6UaFy EfYqM/Fii7ePVARJnJrrw6tUtmfoQ0QaU07/uK3QwI/cE+lTfiMbEYjIuYdBI2DhGrLf U8pMn9UFUUPt/HFn8VmUeZ1UlKzNiGCNWRBbmxr0vho0TD8OqpITvx9Of4+WCxvrPz3H 24Ow== X-Gm-Message-State: AOJu0YzctCvEDRco+w5+xb+0rBDqAIQAZHK3sQY5LjXJEFeg+U9gxWKb MO91nxQwbWj/IXStgcGWWEQO8iwD/NgEpE9MUetc7GkB1roPaDBi8qYPSmDiXw8MxVipJwzoc9E V4df8DwJ+/vo= X-Received: by 2002:adf:e5d0:0:b0:324:8700:6421 with SMTP id a16-20020adfe5d0000000b0032487006421mr9940113wrn.3.1696244366409; Mon, 02 Oct 2023 03:59:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG7+/wspCQe+ttuEnailDH3oMbBRWqWZxM95GNarmAdNoJ0f4ILn2ZzlLcxnZxSeOljT6fouA== X-Received: by 2002:adf:e5d0:0:b0:324:8700:6421 with SMTP id a16-20020adfe5d0000000b0032487006421mr9940090wrn.3.1696244365935; Mon, 02 Oct 2023 03:59:25 -0700 (PDT) Received: from ?IPV6:2003:cb:c735:f200:cb49:cb8f:88fc:9446? (p200300cbc735f200cb49cb8f88fc9446.dip0.t-ipconnect.de. [2003:cb:c735:f200:cb49:cb8f:88fc:9446]) by smtp.gmail.com with ESMTPSA id x5-20020adfdcc5000000b0031c6581d55esm28162012wrm.91.2023.10.02.03.59.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Oct 2023 03:59:25 -0700 (PDT) Message-ID: <428d07a6-bdc6-c12b-1b7e-e271bd841ff5@redhat.com> Date: Mon, 2 Oct 2023 12:59:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 1/4] mm: make __access_remote_vm() static To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Will Deacon , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland Cc: Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Oleg Nesterov , Richard Cochran , Jason Gunthorpe , John Hubbard , Arnd Bergmann References: <70436dcf596565770e604a4fc4e8f27a14c85166.1696174961.git.lstoakes@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <70436dcf596565770e604a4fc4e8f27a14c85166.1696174961.git.lstoakes@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 402A01A0014 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: wygfg3kwrgoq36gogorwqkkj8u6i1x74 X-HE-Tag: 1696244384-452450 X-HE-Meta: U2FsdGVkX1+PMRP6lgYLBiLCx0z22U+GPpmauEHgVKSyEuTY0O7ZI/jijzHwF/LSmSpTp5DQr3wWi2OvtZOPEHi2eQwNODZAemHj/FNH5Xc8Tij2WM5zofS+Baa6slPAai3BAFkUJrOuY0hrkq4fNVuzCVQpxiymDHojS5zZeUYUEMq7ptbbckx1rzX5qxDJ9jN1JJymmOwSfPLd1Obrd7AsaRstx6cc9ei1eREykmDdrwI+wqoUHYqrW0Vfc71D064JYGLZchKriPklthSE3CMOJyUB+uufYZydPWr5w3GGa4mYZL6ZrvAlkVIHPFSVnSDU/eL+Z0AIZphmByrYF8v9rDD9VylqDBiNn/E6FSZMRFdlWjh1iIHfmrDtMqi/iYAv9qu9oM9RL8DiVF5c7XmnvgEoRFe4S3XUKxnjypdvC04eiguGXbeIfJCZzENovkltZNN+225XctgcfwZDrToGcArNIg/Dcvr0fDZ73rX7mhSiOE2Lf9y2PmWWy6KiN7iDXqwN9unhbNYfyDtaQuDWg08LdyoUb6XIVHHJIZR/8ivUKEFd8xOUlyrQF4iGvb0Oa1TjW7CoG2b00W76N2IpXbwMPmWmiRsrdfx2JkztC0p2N7/14xHyGEewuYVLXWTDnco8rONZEJTOdRD8gcXxuzSSUYOXbLGDYF+kakfOI4DBIhR1UiD95hNPeOMIwuietYTMDrq2IUgY4NvNxyvT5lpO9R0M9kZun/+2sqTGHC5/YlljDIvZydjCdM7x3PaxBVFZiMJiXQZzFVjgU5NoD7IbqnVZY6tTjgCYOyQSosU8BGSpEVynrmseMCfkBOlYm8nRo9H/dTOWpM/6QV6Bh0Z2I5KuzQEllZefAxxT59y2bqNyVhGtPcVEHNx+/AcCaOH9U0qxLXjBdfGkSoTvdKFii84CR0pNVL1zLqNNkQXuGwpFMJGr/TPFK/xs0Z837QuIaw7+Ralblv9 Q14KAPP0 HrcfLW/xn4otwbe0yvdxhve8noo/k259+y5E4Du0wVDfpJlFExiTCWo+0UYeFEunok+BNR8PnicVHN19SSDYjnE8Lf18J31LiKIONJt0g/RG9BWY+jFG0zK9uluWrjwsJXHoBbR0jh6BcrPg5xiL0bcLwbp4ScM0mqwB/TqCvwamtzaKCNqZTV23ylbzOz+ATAPdgWYJQYo01x5CFTpo7ZnoF1NjJQ/0JOBz7zUQlqEkElCpFMcu2bTDPQwnuWu3vkoANW7C7PbEYLOP3qdtA872oCeqMHuYGQKYQu1b4U7gaK1W/Z2yk1WXppY3D56/V97MrHpzEYhyauLufY0XBNbxTUD/qcK4/p7T2gt0O5xOliscTkVoRY9ZFZM2/Mn5xOtnc7tPha/EN1WgA0xOp/jjo1s0QnuRUxmxwA3BOXStvPpnv5qYnLw6HFrXookcSputf4UHovlQ2Gy9Q3xet640CPdKF1mNDPRTr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.10.23 18:00, Lorenzo Stoakes wrote: > access_remote_vm() passes through parameters to __access_remote_vm() > directly, so remove the __access_remote_vm() function from mm.h aand use > access_remote_vm() in the one caller that needs it (ptrace_access_vm()). > Wondering why we even still have __access_remote_vm() in the first place, if it really should just be access_remote_vm() directly. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb