From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F60BC433FE for ; Thu, 26 May 2022 07:01:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05FD58D0003; Thu, 26 May 2022 03:01:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00C3F8D0001; Thu, 26 May 2022 03:01:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3E5D8D0003; Thu, 26 May 2022 03:01:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D3D6B8D0001 for ; Thu, 26 May 2022 03:01:51 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 52A7F80256 for ; Thu, 26 May 2022 07:01:51 +0000 (UTC) X-FDA: 79506999222.22.510D0E8 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf15.hostedemail.com (Postfix) with ESMTP id 78AD8A0020 for ; Thu, 26 May 2022 07:01:30 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C76D31474; Thu, 26 May 2022 00:01:47 -0700 (PDT) Received: from [10.162.43.8] (unknown [10.162.43.8]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 236A63F73D; Thu, 26 May 2022 00:01:44 -0700 (PDT) Message-ID: <428c7c69-6ac1-51d5-7c26-5f31de61a909@arm.com> Date: Thu, 26 May 2022 12:31:40 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] mm/hugetlb: Remove unnecessary huge_ptep_set_access_flags() in hugetlb_mcopy_atomic_pte() Content-Language: en-US To: Baolin Wang , mike.kravetz@oracle.com, akpm@linux-foundation.org, songmuchun@bytedance.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <7cd55152c1a00910afda570d1543a97198b3665b.1653468078.git.baolin.wang@linux.alibaba.com> From: Anshuman Khandual In-Reply-To: <7cd55152c1a00910afda570d1543a97198b3665b.1653468078.git.baolin.wang@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 78AD8A0020 X-Stat-Signature: mnezeie1go63uaae46434ofymccern8d X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-HE-Tag: 1653548490-591550 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/25/22 15:56, Baolin Wang wrote: > There is no need to update the hugetlb access flags after just setting the > hugetlb page table entry by set_huge_pte_at(), since the page table entry > value has no changes. Thus remove the unnecessary huge_ptep_set_access_flags() WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #9: value has no changes. Thus remove the unnecessary huge_ptep_set_access_flags() total: 0 errors, 1 warnings, 8 lines checked > in hugetlb_mcopy_atomic_pte(). > > Signed-off-by: Baolin Wang Otherwise LGTM, Reviewed-by: Anshuman Khandual > --- > mm/hugetlb.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 7c468ac..3ad49bf 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -6032,8 +6032,6 @@ int hugetlb_mcopy_atomic_pte(struct mm_struct *dst_mm, > > set_huge_pte_at(dst_mm, dst_addr, dst_pte, _dst_pte); > > - (void)huge_ptep_set_access_flags(dst_vma, dst_addr, dst_pte, _dst_pte, > - dst_vma->vm_flags & VM_WRITE); > hugetlb_count_add(pages_per_huge_page(h), dst_mm); > > /* No need to invalidate - it was non-present before */