From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6552EB64D9 for ; Thu, 6 Jul 2023 13:13:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 411566B0071; Thu, 6 Jul 2023 09:13:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C1136B0072; Thu, 6 Jul 2023 09:13:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AFDD8D0001; Thu, 6 Jul 2023 09:13:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1B4BD6B0071 for ; Thu, 6 Jul 2023 09:13:51 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DA6181C8FC2 for ; Thu, 6 Jul 2023 13:13:50 +0000 (UTC) X-FDA: 80981229420.28.180A5CB Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf22.hostedemail.com (Postfix) with ESMTP id 497E3C00A6 for ; Thu, 6 Jul 2023 13:11:08 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688649071; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eCkW1bLK9YYNgf9r3vo4Z+suXxO8FqdPwwZKbAjoGxc=; b=F7c9gWQy81PkTuevR0O827YVkI9jnWDFp0B9xBe4wtX4sNueLK6lk02a1imrAalorUTYae BeTjxe/5iN/8Ti0t7veYsfLfPeRLFgsHdPscA3bH+yCMMuRFW5IPaU9hou5pmWO2DHoq5d BGByyIRsT5YFPqzdaXu4yGsyZ9/BLRQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688649071; a=rsa-sha256; cv=none; b=8pdGWhECTaRfkRJKvB/wdh5mJfy3Uhl5K/YDR08rLnB2qGreDvrEN0icBswBjyVbw8UglW lcK0MZuoA2mgn/BFQQIXkAJPUJHabknK5vViWjE8qQEmCy7jtaaGQsBs3REtWVNZirfifJ UJ18OMNE7Eclx0Yrb1Z6ft0UerlUSyo= Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QxcJh5BrJzMqHn; Thu, 6 Jul 2023 21:07:48 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 6 Jul 2023 21:11:02 +0800 Subject: Re: [PATCH] memory tier: rename destroy_memory_type() to put_memory_type() To: Xiao Yang CC: , , , , , , , , References: <20230706063905.543800-1-linmiaohe@huawei.com> <7956e695-3eac-25ef-4412-3a0ff33e3574@fujitsu.com> From: Miaohe Lin Message-ID: <428b3127-6b48-c19f-ae87-a1975b162e5c@huawei.com> Date: Thu, 6 Jul 2023 21:11:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <7956e695-3eac-25ef-4412-3a0ff33e3574@fujitsu.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 497E3C00A6 X-Stat-Signature: emxs17rexgrfmrrfxia4tn1ndre9ybzf X-HE-Tag: 1688649068-967743 X-HE-Meta: U2FsdGVkX182+f3j43cHIU3ODKE1kTc7wIsi1iEIhmn6FHGyXcE9lUlYXure/p9xqN2k7TpKBNVdeW1zTcl4mga/4fKH4LcFr2SXXy+/J+s3+o0/5jem0qal/ds24vV7Ad+VYpe3auf0ne46zwxh7jkPkZivr2RzVFEeN+8rdGab501XqF9Lo1LFzDmI4TYvn4TxvYyhPmah7xYhFjQI6JwESpqjnAjx2SZ+kCzIi3uXiFjkZEVqhmNiNA8tbPu9T4VMAJGAoYm1nUbvGQM/arqG7K0OEGeFSYlqS2mZL16M6JDhA81Dzm0WcEFKoW7nrBAffMennzgvzcBdX7Hfq1njUw5v0WUynZ5V8dv9YLFXa+RqS6e3sLPwLR4JvYNNgqXK1KyXR2E+X8J6IKYnj1Fh7H1hXoTrmMA7qMGpZ47IzfPl9C7V+hhhDJnC2j3qInpL7BCb58I5ZVhwcR7KJxXo0QvB3V/+N34kXR2vfwR0npx8DIgyb9+/ZlyIRxYuxpCi7ilByhG2UALtUh9sjE1jlMVEJIbAswz9wNzHLoiJfM8fq68jULXhvJDk/mWiKDSxJkAUBONLj+XJHMPLnR21cfI43ImEGFVg0u3pRmVe6gnwuHSaVZ3Ym3KpHzDOxkyQr0/aPcB4+X1fu/JA/9OUyiboLfZxyahCM3q0RvnfVxMKfqcbqbrL69GFEizkOCaHXy2EgimREUwomUG26nuofJ+9WmSr0RTMpWJ2aApGd4HAo0Lcqo3d8WWFbEPsFY6SIf3CTv9e5hu7nXghcE1hw7HZl8RoJeHx7qJ8WzpcSbAvvRQaJvMmo4zqFzIZ5X1JdPBhrwfNs0WlXWHWxONW392m6mNApSwlIws05L1V5Bo5WkrqKsttxnkTN0V8Yb/8QIBSlb5FRNbB8GdloMar4KoFZYYY17wQUGqwbicjFiY71iA1yiLBIpJVxUseBVUfbUJFsTpX4UPL7Xh b0AWkhvD hUd5uhH/Yff8vZ+TDAXS0jFWv3GNszVcB2uWCfsW7tqvn91bEPe89WS9bCOeYvdFXiNTkhHDvQpwk0ExaAYcMEqHV1CtVcOJ9EMCO91Ejxqb2GXGzUnzVyQ1xjnjcQxtKJoYs+Cf/CUa2oVDIDlEXTVfm4vAcKYr9EwTjEZTmy2nKiuo3SxmU5PFX2xZBPn4cAQjtRlDwMCBYv9w2TZdh2WJW/m4jXE/AIgG756mp5zeIePRfjNcrRiCFVOGbrnI16SHCbnq1Dm1auVQuYRiIl5bLl9K9hb+b/bJYUAtLw5GwpB6bU7B6T+umdQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/6 19:58, Xiao Yang wrote: > On 2023/7/6 14:39, Miaohe Lin wrote: >> It appears that destroy_memory_type() isn't a very good name because >> we usually will not free the memory_type here. So rename it to a more >> appropriate name i.e. put_memory_type(). >> >> Suggested-by: Huang, Ying >> Signed-off-by: Miaohe Lin >> --- >>   drivers/dax/kmem.c           | 4 ++-- >>   include/linux/memory-tiers.h | 4 ++-- >>   mm/memory-tiers.c            | 6 +++--- >>   3 files changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c >> index 898ca9505754..c57acb73e3db 100644 >> --- a/drivers/dax/kmem.c >> +++ b/drivers/dax/kmem.c >> @@ -264,7 +264,7 @@ static int __init dax_kmem_init(void) >>       return rc; >>     error_dax_driver: >> -    destroy_memory_type(dax_slowmem_type); >> +    put_memory_type(dax_slowmem_type); >>   err_dax_slowmem_type: >>       kfree_const(kmem_name); >>       return rc; >> @@ -275,7 +275,7 @@ static void __exit dax_kmem_exit(void) >>       dax_driver_unregister(&device_dax_kmem_driver); >>       if (!any_hotremove_failed) >>           kfree_const(kmem_name); >> -    destroy_memory_type(dax_slowmem_type); >> +    put_memory_type(dax_slowmem_type); >>   } >>     MODULE_AUTHOR("Intel Corporation"); >> diff --git a/include/linux/memory-tiers.h b/include/linux/memory-tiers.h >> index fc9647b1b4f9..437441cdf78f 100644 >> --- a/include/linux/memory-tiers.h >> +++ b/include/linux/memory-tiers.h >> @@ -33,7 +33,7 @@ struct memory_dev_type { >>   #ifdef CONFIG_NUMA >>   extern bool numa_demotion_enabled; >>   struct memory_dev_type *alloc_memory_type(int adistance); >> -void destroy_memory_type(struct memory_dev_type *memtype); >> +void put_memory_type(struct memory_dev_type *memtype); >>   void init_node_memory_type(int node, struct memory_dev_type *default_type); >>   void clear_node_memory_type(int node, struct memory_dev_type *memtype); >>   #ifdef CONFIG_MIGRATION >> @@ -68,7 +68,7 @@ static inline struct memory_dev_type *alloc_memory_type(int adistance) >>       return NULL; >>   } >>   -static inline void destroy_memory_type(struct memory_dev_type *memtype) >> +static inline void put_memory_type(struct memory_dev_type *memtype) >>   { >>     } >> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c >> index 1719fa3bcf02..c49ab03f49b1 100644 >> --- a/mm/memory-tiers.c >> +++ b/mm/memory-tiers.c >> @@ -560,11 +560,11 @@ struct memory_dev_type *alloc_memory_type(int adistance) >>   } >>   EXPORT_SYMBOL_GPL(alloc_memory_type); >>   -void destroy_memory_type(struct memory_dev_type *memtype) >> +void put_memory_type(struct memory_dev_type *memtype) >>   { >>       kref_put(&memtype->kref, release_memtype); >>   } >> -EXPORT_SYMBOL_GPL(destroy_memory_type); >> +EXPORT_SYMBOL_GPL(put_memory_type); >>     void init_node_memory_type(int node, struct memory_dev_type *memtype) >>   { >> @@ -586,7 +586,7 @@ void clear_node_memory_type(int node, struct memory_dev_type *memtype) >>        */ >>       if (!node_memory_types[node].map_count) { >>           node_memory_types[node].memtype = NULL; >> -        destroy_memory_type(memtype); >> +        put_memory_type(memtype); > Hi Maohe, > > I didn't find that destroy_memory_type(memtype) is called here on mainline kernel. Did I miss something? It's on linux-next tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=e5bf0402b80d80b66e9765b2c160b5199a5c7d3b > > Other than that, it looks good to me. > Reviewed-by: Xiao Yang Thanks for your review and comment.